Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-spinner): adopt custom JSX pragma #27622

Conversation

bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-spinner

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 260ac56:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d340ff4b1c3aa7e1818780ec4d41f46c86e451c9 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.031 kB
57.838 kB
207.849 kB
57.856 kB
-182 B
18 B
react-spinner
Spinner
24.202 kB
7.42 kB
23.498 kB
7.244 kB
-704 B
-176 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
68.69 kB
18.686 kB
react-components
react-components: FluentProvider & webLightTheme
38.773 kB
12.375 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against b61892e1d2e6b8bef5b5b1ba22e08247238fb45c

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
Button mount 394 377 5000 Possible regression
InfoButton mount 22 18 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 695 711 5000
Button mount 394 377 5000 Possible regression
Field mount 1304 1261 5000
FluentProvider mount 895 923 5000
FluentProviderWithTheme mount 112 115 10
FluentProviderWithTheme virtual-rerender 95 92 10
FluentProviderWithTheme virtual-rerender-with-unmount 113 116 10
InfoButton mount 22 18 5000 Possible regression
MakeStyles mount 1114 1132 50000
Persona mount 2020 1939 5000
SpinButton mount 1617 1627 5000

@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2023 11:22
@bsunderhus bsunderhus requested review from a team and tomi-msft as code owners April 18, 2023 11:22
@bsunderhus bsunderhus enabled auto-merge (squash) April 18, 2023 14:51
@bsunderhus bsunderhus force-pushed the react-spinner/chore--adopt-custom-JSX-pragma branch from dcfaf2f to 260ac56 Compare April 18, 2023 19:16
@bsunderhus bsunderhus merged commit cc2d9e2 into microsoft:master Apr 18, 2023
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants