-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react-spinner): adopt custom JSX pragma #27622
Merged
bsunderhus
merged 1 commit into
microsoft:master
from
bsunderhus:react-spinner/chore--adopt-custom-JSX-pragma
Apr 18, 2023
Merged
chore(react-spinner): adopt custom JSX pragma #27622
bsunderhus
merged 1 commit into
microsoft:master
from
bsunderhus:react-spinner/chore--adopt-custom-JSX-pragma
Apr 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 260ac56:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d340ff4b1c3aa7e1818780ec4d41f46c86e451c9 (build) |
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Button | mount | 394 | 377 | 5000 | Possible regression |
InfoButton | mount | 22 | 18 | 5000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 695 | 711 | 5000 | |
Button | mount | 394 | 377 | 5000 | Possible regression |
Field | mount | 1304 | 1261 | 5000 | |
FluentProvider | mount | 895 | 923 | 5000 | |
FluentProviderWithTheme | mount | 112 | 115 | 10 | |
FluentProviderWithTheme | virtual-rerender | 95 | 92 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 113 | 116 | 10 | |
InfoButton | mount | 22 | 18 | 5000 | Possible regression |
MakeStyles | mount | 1114 | 1132 | 50000 | |
Persona | mount | 2020 | 1939 | 5000 | |
SpinButton | mount | 1617 | 1627 | 5000 |
khmakoto
approved these changes
Apr 18, 2023
bsunderhus
force-pushed
the
react-spinner/chore--adopt-custom-JSX-pragma
branch
from
April 18, 2023 19:16
dcfaf2f
to
260ac56
Compare
tomi-msft
approved these changes
Apr 18, 2023
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
react-jsx-runtime
custom pragma onreact-spinner