Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-text): adopt custom JSX pragma #27626

Conversation

bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-text

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a59e4c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 391878bf4d8a8210a8279a6ced8bf9a64daf4c64 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Button, FluentProvider & webLightTheme
68.803 kB
18.728 kB
68.69 kB
18.686 kB
-113 B
-42 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.156 kB
57.857 kB
208.043 kB
57.817 kB
-113 B
-40 B
react-components
react-components: FluentProvider & webLightTheme
38.886 kB
12.41 kB
38.773 kB
12.375 kB
-113 B
-35 B
react-datepicker-compat
DatePicker Compat
252.153 kB
67.645 kB
252.04 kB
67.61 kB
-113 B
-35 B
react-text
Text - Default
15.03 kB
5.339 kB
15.08 kB
5.353 kB
50 B
14 B
react-text
Text - Wrappers
15.584 kB
5.245 kB
15.63 kB
5.25 kB
46 B
5 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-input
Input
26.796 kB
8.148 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against 85c36e249b33b0bad79be4edd1a943dfc5233b11

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 701 646 5000
Button mount 342 357 5000
Field mount 1324 1308 5000
FluentProvider mount 913 885 5000
FluentProviderWithTheme mount 112 119 10
FluentProviderWithTheme virtual-rerender 102 101 10
FluentProviderWithTheme virtual-rerender-with-unmount 107 111 10
InfoButton mount 29 15 5000
MakeStyles mount 1146 1153 50000
Persona mount 2037 2037 5000
SpinButton mount 1615 1592 5000

@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2023 11:23
@bsunderhus bsunderhus requested a review from a team as a code owner April 18, 2023 11:23
@bsunderhus bsunderhus merged commit 8b1ce88 into microsoft:master Apr 18, 2023
@bsunderhus bsunderhus deleted the react-text/chore--adopt-custom-JSX-pragma branch April 18, 2023 14:51
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants