Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tools): add conformance setup migration to migrate-converged-pkg generator #27668

Merged
merged 1 commit into from
Apr 26, 2023
Merged

feat(tools): add conformance setup migration to migrate-converged-pkg generator #27668

merged 1 commit into from
Apr 26, 2023

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Apr 24, 2023 •
edited
Loading

New Behavior

implements conformance setup migration automation for migrate-converged-pkg generator

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 24, 2023
@Hotell Hotell changed the title Hotell/build/faster ci/conformance tests fix 2 feat(tools): add conformance setup migration to migrate-converged-pkg generator Apr 24, 2023
@Hotell Hotell force-pushed the hotell/build/faster-ci/conformance-tests-fix-2 branch from 709f9e9 to 8024472 Compare April 24, 2023 13:21
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 42ecce73761a3bac89a6870dd6d84fde421bfe71

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 684 708 5000
Button mount 396 399 5000
Field mount 1244 1259 5000
FluentProvider mount 792 798 5000
FluentProviderWithTheme mount 107 106 10
FluentProviderWithTheme virtual-rerender 95 88 10
FluentProviderWithTheme virtual-rerender-with-unmount 104 102 10
InfoButton mount 15 17 5000
MakeStyles mount 1165 1157 50000
Persona mount 1919 1836 5000
SpinButton mount 1446 1473 5000

@Hotell Hotell mentioned this pull request Apr 24, 2023
Merged
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 24, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e9991b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 24, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3a6bbb0ca32a62a60195d248074236709d7e2b2d (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 154 140 1.1:1
ChatDuplicateMessagesPerf.default 208 192 1.08:1
PortalMinimalPerf.default 125 117 1.07:1
VideoMinimalPerf.default 555 532 1.04:1
LabelMinimalPerf.default 306 297 1.03:1
ListCommonPerf.default 527 511 1.03:1
MenuMinimalPerf.default 667 645 1.03:1
SkeletonMinimalPerf.default 276 268 1.03:1
TextMinimalPerf.default 273 264 1.03:1
ToolbarMinimalPerf.default 691 674 1.03:1
ButtonSlotsPerf.default 375 367 1.02:1
ChatMinimalPerf.default 563 554 1.02:1
DatepickerMinimalPerf.default 4454 4364 1.02:1
DividerMinimalPerf.default 287 280 1.02:1
DropdownMinimalPerf.default 1793 1755 1.02:1
InputMinimalPerf.default 679 663 1.02:1
PopupMinimalPerf.default 486 477 1.02:1
ReactionMinimalPerf.default 293 286 1.02:1
AnimationMinimalPerf.default 394 391 1.01:1
ButtonMinimalPerf.default 113 112 1.01:1
ChatWithPopoverPerf.default 250 248 1.01:1
DialogMinimalPerf.default 616 610 1.01:1
ListMinimalPerf.default 410 406 1.01:1
MenuButtonMinimalPerf.default 1203 1194 1.01:1
ProviderMergeThemesPerf.default 846 840 1.01:1
RadioGroupMinimalPerf.default 358 354 1.01:1
SliderMinimalPerf.default 853 843 1.01:1
IconMinimalPerf.default 500 494 1.01:1
TextAreaMinimalPerf.default 373 370 1.01:1
CustomToolbarPrototype.default 1826 1810 1.01:1
AlertMinimalPerf.default 204 204 1:1
BoxMinimalPerf.default 265 266 1:1
ButtonOverridesMissPerf.default 768 770 1:1
CardMinimalPerf.default 394 393 1:1
HeaderSlotsPerf.default 628 626 1:1
ItemLayoutMinimalPerf.default 901 900 1:1
ListWith60ListItems.default 463 465 1:1
RosterPerf.default 1665 1660 1:1
RefMinimalPerf.default 146 146 1:1
SplitButtonMinimalPerf.default 2766 2754 1:1
TableManyItemsPerf.default 1415 1416 1:1
TableMinimalPerf.default 321 322 1:1
TreeWith60ListItems.default 111 111 1:1
EmbedMinimalPerf.default 2063 2091 0.99:1
FormMinimalPerf.default 285 289 0.99:1
ImageMinimalPerf.default 306 309 0.99:1
ProviderMinimalPerf.default 252 255 0.99:1
StatusMinimalPerf.default 538 545 0.99:1
TreeMinimalPerf.default 608 613 0.99:1
AttachmentSlotsPerf.default 775 790 0.98:1
DropdownManyItemsPerf.default 477 485 0.98:1
GridMinimalPerf.default 256 261 0.98:1
HeaderMinimalPerf.default 281 286 0.98:1
LayoutMinimalPerf.default 272 277 0.98:1
ListNestedPerf.default 404 414 0.98:1
LoaderMinimalPerf.default 226 230 0.98:1
AccordionMinimalPerf.default 105 108 0.97:1
CarouselMinimalPerf.default 305 316 0.97:1
CheckboxMinimalPerf.default 1335 1374 0.97:1
SegmentMinimalPerf.default 267 279 0.96:1
FlexMinimalPerf.default 211 222 0.95:1
TooltipMinimalPerf.default 1546 1619 0.95:1
AttachmentMinimalPerf.default 102 108 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@Hotell Hotell mentioned this pull request Apr 24, 2023
Closed
11 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 791 792 5000
Breadcrumb mount 2028 2079 1000
Checkbox mount 2121 2153 5000
CheckboxBase mount 1855 1850 5000
ChoiceGroup mount 3536 3518 5000
ComboBox mount 802 800 1000
CommandBar mount 7691 7681 1000
ContextualMenu mount 14728 14116 1000
DefaultButton mount 943 923 5000
DetailsRow mount 2638 2625 5000
DetailsRowFast mount 2636 2651 5000
DetailsRowNoStyles mount 2440 2449 5000
Dialog mount 3200 3244 1000
DocumentCardTitle mount 296 290 1000
Dropdown mount 2470 2448 5000
FocusTrapZone mount 1425 1413 5000
FocusZone mount 1351 1400 5000
GroupedList mount 45613 45521 2
GroupedList virtual-rerender 22187 22064 2
GroupedList virtual-rerender-with-unmount 62823 62612 2
GroupedListV2 mount 284 280 2
GroupedListV2 virtual-rerender 260 261 2
GroupedListV2 virtual-rerender-with-unmount 290 284 2
IconButton mount 1305 1288 5000
Label mount 456 438 5000
Layer mount 3377 3346 5000
Link mount 524 514 5000
MenuButton mount 1152 1160 5000
MessageBar mount 25862 26049 5000
Nav mount 2340 2315 1000
OverflowSet mount 1021 1020 5000
Panel mount 2171 2173 1000
Persona mount 924 917 1000
Pivot mount 1056 1071 1000
PrimaryButton mount 1054 1043 5000
Rating mount 5806 5794 5000
SearchBox mount 1114 1116 5000
Shimmer mount 2331 2346 5000
Slider mount 1665 1697 5000
SpinButton mount 3416 3432 5000
Spinner mount 519 517 5000
SplitButton mount 2173 2185 5000
Stack mount 531 525 5000
StackWithIntrinsicChildren mount 1089 1082 5000
StackWithTextChildren mount 3362 3370 5000
SwatchColorPicker mount 7386 7432 5000
TagPicker mount 1694 1709 5000
Text mount 490 497 5000
TextField mount 1142 1140 5000
ThemeProvider mount 1011 1019 5000
ThemeProvider virtual-rerender 805 789 5000
ThemeProvider virtual-rerender-with-unmount 1564 1542 5000
Toggle mount 799 803 5000
buttonNative mount 247 241 5000

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v0 No visual regressions between this PR and main

@Hotell Hotell force-pushed the hotell/build/faster-ci/conformance-tests-fix-2 branch from 3de64fd to f89f5b8 Compare April 25, 2023 12:54
@Hotell Hotell force-pushed the hotell/build/faster-ci/conformance-tests-fix-2 branch from f89f5b8 to 3e9991b Compare April 25, 2023 12:55
@Hotell Hotell marked this pull request as ready for review April 25, 2023 13:16
@Hotell Hotell requested a review from a team as a code owner April 25, 2023 13:16
@Hotell Hotell merged commit 232c4b3 into microsoft:master Apr 26, 2023
@Hotell Hotell deleted the hotell/build/faster-ci/conformance-tests-fix-2 branch April 26, 2023 12:30
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 27, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-components
cbca31c 
* master:
  chore: enforce files naming to use .styles.ts [cxe-prg files] (microsoft#27707)
  chore: migrate to NodeJS v16 (microsoft#27711)
  remove react-avatar-context package (microsoft#27709)
  test: migrate all v9 libraries to use new conformance setup which improves test execution by approx 46% (microsoft#27669)
  chore: Add caret to react-datepicker-compat dependencies (microsoft#27671)
  test(fluentui/react): fix initial global leaks that were causing OOM issues (microsoft#27661)
  chore(react-utilities): simplifies useControllableState hook internals (microsoft#27702)
  chore: enforce files naming to use .styles.ts (microsoft#27698)
  feat: adds lazy loading example (microsoft#27587)
  feat: react-combobox space conditionally inserts character when freeform is true (microsoft#27025)
  chore(react-tree): updates useOpenItemsState internals (microsoft#27697)
  feat(tools): add conformance setup migration to migrate-converged-pkg generator (microsoft#27668)
  test: use `isolatedModules` for all ts-jest configs to lower memory footprint on CI (microsoft#27670)
  chore: bump @griffel/eslint-plugin & enable @griffel/hook-naming (microsoft#27687)
  feat(react-tree): makes useFlatTree generic (microsoft#27682)
  Enable export to codepen for charting library (microsoft#27539)
  Overflow: added useOverflowCount to exports (microsoft#27678)
  fix: Menu should not steal focus on re-render (microsoft#27688)
  feat(react-conformance): add new TS config api to be able to specify configName and configDir (microsoft#27664)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 27, 2023
@marcosmoura
Merge branch 'feat/drawer-components' into feat/drawer-header
275aae4 
* feat/drawer-components: (28 commits)
  docs: update API
  feat: add style overrides for upcoming drawer components
  feat: add support to override drawer styles
  fix: prevent elements from stretching
  chore: upgrade devcontainer node version to 16 (microsoft#27716)
  fix: rename styles file to use the newer naming conventions
  test: add cypress tests for scroll positions
  chore: enforce files naming to use .styles.ts [cxe-prg files] (microsoft#27707)
  feat: add support to override drawer body styles
  chore: migrate to NodeJS v16 (microsoft#27711)
  remove react-avatar-context package (microsoft#27709)
  test: migrate all v9 libraries to use new conformance setup which improves test execution by approx 46% (microsoft#27669)
  chore: Add caret to react-datepicker-compat dependencies (microsoft#27671)
  test(fluentui/react): fix initial global leaks that were causing OOM issues (microsoft#27661)
  chore(react-utilities): simplifies useControllableState hook internals (microsoft#27702)
  chore: enforce files naming to use .styles.ts (microsoft#27698)
  feat: adds lazy loading example (microsoft#27587)
  feat: react-combobox space conditionally inserts character when freeform is true (microsoft#27025)
  chore(react-tree): updates useOpenItemsState internals (microsoft#27697)
  feat(tools): add conformance setup migration to migrate-converged-pkg generator (microsoft#27668)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

Assignees
No one assigned
Labels
Area: Build System Area: Testing
Projects
None yet
Milestone
April Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @ling1726