feat(react-tree): creates TreeItemAside component
#27701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
force-pushed
the
react-tree/feat--adds-active-state-to-TreeItem
branch
from
ef7f8fe to
200cfab
Compare
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 689 | 714 | 5000 | |
| Button | mount | 367 | 377 | 5000 | |
| Field | mount | 1258 | 1283 | 5000 | |
| FluentProvider | mount | 912 | 911 | 5000 | |
| FluentProviderWithTheme | mount | 119 | 116 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 99 | 103 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 108 | 121 | 10 | |
| InfoButton | mount | 19 | 21 | 5000 | |
| MakeStyles | mount | 1148 | 1124 | 50000 | |
| Persona | mount | 1994 | 2012 | 5000 | |
| SpinButton | mount | 1557 | 1554 | 5000 |
bsunderhus
force-pushed
the
react-tree/feat--adds-active-state-to-TreeItem
branch
from
200cfab to
fa982b7
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1267096:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0ffdc48b94a76bfd209015b1a9c49eb62aca1ba0 (build) |
bsunderhus
force-pushed
the
react-tree/feat--adds-active-state-to-TreeItem
branch
2 times, most recently
from
bc255c3 to
2804ffa
Compare
github-actions
bot
modified the milestones:
April Project Cycle Q2 2023,
May Project Cycle Q2 2023
bsunderhus
force-pushed
the
react-tree/feat--adds-active-state-to-TreeItem
branch
3 times, most recently
from
08eb844 to
e35f835
Compare
layershifter
reviewed
May 4, 2023
There was a problem hiding this comment.
Few notes:
- Navigation in actions is a bit non-intuitive to me, may be something to check
-
Open
packages/react-components/react-tree/stories/B_TreeItem/TreeItemActions.stories.tsx -
Focus an item with actions
-
Press Tab ➡️ an item with a pencil is focused
-
Press Tab ➡️ an item with dots is focused
-
Press Tab ➡️ URL bar is focused
-
- Hover behavior with actions is also a bit strange, once I hover a tree item ➡️ actions will close
packages/react-components/react-tree/src/components/TreeItemActions/renderTreeItemActions.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tree/src/components/TreeItemActions/TreeItemActions.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-tree/src/components/TreeItemActions/TreeItemActions.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tree/src/components/TreeItem/useTreeItemContextValues.ts
Show resolved
Hide resolved
packages/react-components/react-tree/src/components/TreeItem/useTreeItem.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tree/src/components/TreeItem/useTreeItem.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tree/src/components/TreeItem/useTreeItem.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tree/src/components/TreeItem/useTreeItem.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tree/src/components/TreeItem/TreeItem.test.tsx
Outdated
Show resolved
Hide resolved
The whole navigation is still an ongoing discussion, Milan has already raised some good points against current model. I'll see to have your perceptions included. |
ling1726
reviewed
May 4, 2023
packages/react-components/react-tree/src/components/TreeItem/useTreeItem.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 4, 2023
packages/react-components/react-tree/src/components/TreeItem/useTreeItem.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 4, 2023
packages/react-components/react-tree/src/components/TreeItem/useTreeItemStyles.styles.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 4, 2023
packages/react-components/react-tree/src/components/TreeItemActions/TreeItemActions.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 4, 2023
...eact-components/react-tree/src/components/TreeItemActions/useTreeItemActionsStyles.styles.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 4, 2023
packages/react-components/react-tree/stories/C_Layouts/LayoutsDefault.stories.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 4, 2023
packages/react-components/react-tree/src/components/Tree/useSubtree.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-tree/feat--adds-active-state-to-TreeItem
branch
2 times, most recently
from
6f84da4 to
5f01600
Compare
ling1726
reviewed
May 10, 2023
packages/react-components/react-tree/src/components/TreeItem/useTreeItem.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
May 10, 2023
packages/react-components/react-tree/src/components/TreeItemAside/renderTreeItemAside.tsx
Show resolved
Hide resolved
ling1726
reviewed
May 10, 2023
packages/react-components/react-tree/src/components/TreeItemAside/renderTreeItemAside.tsx
Show resolved
Hide resolved
ling1726
reviewed
May 10, 2023
...es/react-components/react-tree/src/components/TreeItemAside/useTreeItemAsideStyles.styles.ts
Show resolved
Hide resolved
ling1726
reviewed
May 10, 2023
bsunderhus
force-pushed
the
react-tree/feat--adds-active-state-to-TreeItem
branch
2 times, most recently
from
8734b5e to
1b5bce3
Compare
bsunderhus
changed the title
TreeItemAside component
bsunderhus
force-pushed
the
react-tree/feat--adds-active-state-to-TreeItem
branch
from
1b5bce3 to
2f03acd
Compare
bsunderhus
force-pushed
the
react-tree/feat--adds-active-state-to-TreeItem
branch
3 times, most recently
from
c082a8e to
0a53d10
Compare
2 tasks
ling1726
reviewed
May 12, 2023
packages/react-components/react-tree/src/components/TreeItemAside/useTreeItemAside.ts
Outdated
Show resolved
Hide resolved
ling1726
approved these changes
May 12, 2023
bsunderhus
force-pushed
the
react-tree/feat--adds-active-state-to-TreeItem
branch
from
0a53d10 to
1267096
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 12, 2023
* feat/drawer-header: feat: Update existing toasts (microsoft#27827) bugfix: fix horizontal overflow on tree (microsoft#27825) feat: Allow toast options to be configured from the toaster (microsoft#27820) feat: creates TreeItemAside component (microsoft#27701) fix: generate API fix: use composition to build DrawerHeaderTitle Virtualizer: Dynamic scroll view and optimizations (microsoft#27298) bugfix(react-dialog): change DialogTitle default action icon size (microsoft#27815) feat: Implement Toast pause (microsoft#27811) fix: ToolbarToggleButton should not follow Toolbar size (microsoft#27797) feat: defers useControllableState state to initializer method (microsoft#27717) feat: Implement toast dismiss (microsoft#27810)
|
🎉 Handy links: |
|
🎉 Handy links: |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
TreeItemAsidecomponent withvisibleproperty that allows the control of the visibility of actionsactionsandasideslots from layout componentsRelated Issue(s)