ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule issues #27729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
Hotell
changed the title
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1e4ad6831b1e626009674a63d480eedd7045fd05 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 743977d:
|
tudorpopams
approved these changes
Apr 28, 2023
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 107 | 99 | 1.08:1 |
| LoaderMinimalPerf.default | 254 | 238 | 1.07:1 |
| TreeWith60ListItems.default | 112 | 105 | 1.07:1 |
| PortalMinimalPerf.default | 124 | 117 | 1.06:1 |
| AvatarMinimalPerf.default | 136 | 130 | 1.05:1 |
| ButtonSlotsPerf.default | 416 | 395 | 1.05:1 |
| MenuMinimalPerf.default | 642 | 610 | 1.05:1 |
| SegmentMinimalPerf.default | 258 | 245 | 1.05:1 |
| ChatWithPopoverPerf.default | 250 | 240 | 1.04:1 |
| GridMinimalPerf.default | 245 | 235 | 1.04:1 |
| HeaderMinimalPerf.default | 278 | 267 | 1.04:1 |
| HeaderSlotsPerf.default | 603 | 580 | 1.04:1 |
| LabelMinimalPerf.default | 288 | 276 | 1.04:1 |
| AnimationMinimalPerf.default | 376 | 365 | 1.03:1 |
| CardMinimalPerf.default | 386 | 374 | 1.03:1 |
| DialogMinimalPerf.default | 590 | 571 | 1.03:1 |
| TextMinimalPerf.default | 253 | 246 | 1.03:1 |
| AttachmentSlotsPerf.default | 838 | 819 | 1.02:1 |
| CarouselMinimalPerf.default | 346 | 339 | 1.02:1 |
| DropdownManyItemsPerf.default | 493 | 484 | 1.02:1 |
| PopupMinimalPerf.default | 460 | 449 | 1.02:1 |
| ReactionMinimalPerf.default | 269 | 265 | 1.02:1 |
| TableManyItemsPerf.default | 1445 | 1415 | 1.02:1 |
| TooltipMinimalPerf.default | 1653 | 1621 | 1.02:1 |
| ChatMinimalPerf.default | 540 | 537 | 1.01:1 |
| CheckboxMinimalPerf.default | 1577 | 1556 | 1.01:1 |
| DividerMinimalPerf.default | 261 | 258 | 1.01:1 |
| EmbedMinimalPerf.default | 2416 | 2386 | 1.01:1 |
| FormMinimalPerf.default | 273 | 270 | 1.01:1 |
| InputMinimalPerf.default | 732 | 722 | 1.01:1 |
| ListCommonPerf.default | 494 | 490 | 1.01:1 |
| RefMinimalPerf.default | 134 | 133 | 1.01:1 |
| SliderMinimalPerf.default | 926 | 917 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3050 | 3033 | 1.01:1 |
| TreeMinimalPerf.default | 604 | 600 | 1.01:1 |
| DatepickerMinimalPerf.default | 4775 | 4762 | 1:1 |
| ItemLayoutMinimalPerf.default | 898 | 900 | 1:1 |
| ListMinimalPerf.default | 379 | 379 | 1:1 |
| ListNestedPerf.default | 418 | 420 | 1:1 |
| ListWith60ListItems.default | 481 | 481 | 1:1 |
| MenuButtonMinimalPerf.default | 1280 | 1280 | 1:1 |
| ProviderMergeThemesPerf.default | 983 | 980 | 1:1 |
| ProviderMinimalPerf.default | 271 | 272 | 1:1 |
| TableMinimalPerf.default | 300 | 299 | 1:1 |
| TextAreaMinimalPerf.default | 354 | 355 | 1:1 |
| CustomToolbarPrototype.default | 1928 | 1925 | 1:1 |
| ToolbarMinimalPerf.default | 668 | 669 | 1:1 |
| BoxMinimalPerf.default | 248 | 251 | 0.99:1 |
| ButtonOverridesMissPerf.default | 831 | 840 | 0.99:1 |
| DropdownMinimalPerf.default | 1807 | 1832 | 0.99:1 |
| RadioGroupMinimalPerf.default | 335 | 337 | 0.99:1 |
| StatusMinimalPerf.default | 509 | 514 | 0.99:1 |
| ButtonMinimalPerf.default | 106 | 108 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 199 | 204 | 0.98:1 |
| FlexMinimalPerf.default | 195 | 198 | 0.98:1 |
| LayoutMinimalPerf.default | 267 | 272 | 0.98:1 |
| RosterPerf.default | 1818 | 1859 | 0.98:1 |
| SkeletonMinimalPerf.default | 250 | 254 | 0.98:1 |
| ImageMinimalPerf.default | 273 | 285 | 0.96:1 |
| AlertMinimalPerf.default | 197 | 208 | 0.95:1 |
| VideoMinimalPerf.default | 510 | 538 | 0.95:1 |
| AccordionMinimalPerf.default | 103 | 110 | 0.94:1 |
| IconMinimalPerf.default | 427 | 491 | 0.87:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 697 | 683 | 5000 | |
| Button | mount | 373 | 376 | 5000 | |
| Field | mount | 1289 | 1293 | 5000 | |
| FluentProvider | mount | 939 | 929 | 5000 | |
| FluentProviderWithTheme | mount | 106 | 117 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 97 | 105 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 102 | 109 | 10 | |
| InfoButton | mount | 22 | 20 | 5000 | |
| MakeStyles | mount | 1144 | 1110 | 50000 | |
| Persona | mount | 1987 | 1985 | 5000 | |
| SpinButton | mount | 1573 | 1609 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 834 | 816 | 5000 | |
| Breadcrumb | mount | 2348 | 2324 | 1000 | |
| Checkbox | mount | 2129 | 2165 | 5000 | |
| CheckboxBase | mount | 1873 | 1916 | 5000 | |
| ChoiceGroup | mount | 3720 | 3772 | 5000 | |
| ComboBox | mount | 889 | 913 | 1000 | |
| CommandBar | mount | 8266 | 8184 | 1000 | |
| ContextualMenu | mount | 19139 | 20106 | 1000 | |
| DefaultButton | mount | 972 | 980 | 5000 | |
| DetailsRow | mount | 2955 | 2925 | 5000 | |
| DetailsRowFast | mount | 2932 | 2936 | 5000 | |
| DetailsRowNoStyles | mount | 2700 | 2715 | 5000 | |
| Dialog | mount | 3523 | 3485 | 1000 | |
| DocumentCardTitle | mount | 312 | 336 | 1000 | |
| Dropdown | mount | 2573 | 2581 | 5000 | |
| FocusTrapZone | mount | 1514 | 1516 | 5000 | |
| FocusZone | mount | 1512 | 1473 | 5000 | |
| GroupedList | mount | 50848 | 58945 | 2 | |
| GroupedList | virtual-rerender | 24585 | 22148 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 75602 | 75663 | 2 | |
| GroupedListV2 | mount | 326 | 323 | 2 | |
| GroupedListV2 | virtual-rerender | 300 | 300 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 325 | 317 | 2 | |
| IconButton | mount | 1429 | 1462 | 5000 | |
| Label | mount | 469 | 455 | 5000 | |
| Layer | mount | 3619 | 3614 | 5000 | |
| Link | mount | 533 | 524 | 5000 | |
| MenuButton | mount | 1262 | 1224 | 5000 | |
| MessageBar | mount | 27828 | 27686 | 5000 | |
| Nav | mount | 2547 | 2526 | 1000 | |
| OverflowSet | mount | 1021 | 1028 | 5000 | |
| Panel | mount | 2297 | 2315 | 1000 | |
| Persona | mount | 1006 | 988 | 1000 | |
| Pivot | mount | 1176 | 1197 | 1000 | |
| PrimaryButton | mount | 1098 | 1118 | 5000 | |
| Rating | mount | 5856 | 5863 | 5000 | |
| SearchBox | mount | 1196 | 1162 | 5000 | |
| Shimmer | mount | 2371 | 2396 | 5000 | |
| Slider | mount | 1757 | 1737 | 5000 | |
| SpinButton | mount | 3751 | 3782 | 5000 | |
| Spinner | mount | 533 | 527 | 5000 | |
| SplitButton | mount | 2448 | 2438 | 5000 | |
| Stack | mount | 538 | 549 | 5000 | |
| StackWithIntrinsicChildren | mount | 1134 | 1131 | 5000 | |
| StackWithTextChildren | mount | 3247 | 3240 | 5000 | |
| SwatchColorPicker | mount | 8166 | 8134 | 5000 | |
| TagPicker | mount | 2030 | 1992 | 5000 | |
| Text | mount | 505 | 501 | 5000 | |
| TextField | mount | 1229 | 1226 | 5000 | |
| ThemeProvider | mount | 1140 | 1142 | 5000 | |
| ThemeProvider | virtual-rerender | 783 | 787 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1741 | 1762 | 5000 | |
| Toggle | mount | 800 | 808 | 5000 | |
| buttonNative | mount | 279 | 290 | 5000 |
🕵 FluentUI-v0 No visual regressions between this PR and main |
…y import plugin lint rule
Hotell
force-pushed
the
hotell/build/make-lint-task-dependt-on-build-to-resolve-lint-issue
branch
from
83d9381
to
743977d
Compare
🕵 fluentuiv8 No visual regressions between this PR and main |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 2, 2023
* master: applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) codeowner update (microsoft#27719) Tag/TagButton init component setup (microsoft#27102)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 2, 2023
* feat/drawer-components: (120 commits) fix: add missing change file Component testing - Donut chart (microsoft#27033) fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages (microsoft#27741) chore: add .swcrc to .npmignore (generator) (microsoft#27739) docs: update API Autogenerate react-toast package (microsoft#27730) applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) ...
Hotell
deleted the
hotell/build/make-lint-task-dependt-on-build-to-resolve-lint-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
lint task doesn't depend on any other task
New Behavior
adding "2. add back build pre-requirement to be able to run lint ( will slow down PR pipeline )" as temporary workaround
Related Issue(s)
import/no-extraneous-dependencieslint rule doesn't work without building monorepo packages first #27727