Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add .swcrc to .npmignore (file updates) #27740

Merged
merged 1 commit into from
May 3, 2023
Merged

chore: add .swcrc to .npmignore (file updates) #27740

merged 1 commit into from
May 3, 2023

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented May 2, 2023 •
edited
Loading

Follows #27739.

Previous Behavior

image

New Behavior

.swcrc is excluded from publishing. This PR that updates .npmignore, changes in a generator happened in #27739.

@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 2, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 2, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0bc0701:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@layershifter layershifter force-pushed the chore/swc-publish-files branch 2 times, most recently from 2bffa49 to 610cbe8 Compare May 2, 2023 12:43
@layershifter layershifter marked this pull request as ready for review May 2, 2023 12:45
@layershifter layershifter force-pushed the chore/swc-publish-files branch from 610cbe8 to b25b407 Compare May 2, 2023 12:48
@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
priority-overflow
createOverflowManager		 3.194 kB
1.314 kB
react-accordion
Accordion (including children components)		 86.012 kB
26.086 kB
react-alert
Alert		 93.799 kB
22.502 kB
react-avatar
Avatar		 57.564 kB
14.976 kB
react-avatar
AvatarGroup		 15.632 kB
6.258 kB
react-avatar
AvatarGroupItem		 73.778 kB
19.491 kB
react-badge
Badge		 23.512 kB
7.197 kB
react-badge
CounterBadge		 24.416 kB
7.506 kB
react-badge
PresenceBadge		 31.904 kB
8.296 kB
react-button
Button		 37.179 kB
9.534 kB
react-button
CompoundButton		 44.328 kB
11.016 kB
react-button
MenuButton		 41.866 kB
10.861 kB
react-button
SplitButton		 50.254 kB
12.441 kB
react-button
ToggleButton		 55.397 kB
11.435 kB
react-card
Card - All		 86.061 kB
24.345 kB
react-card
Card		 80.997 kB
22.895 kB
react-card
CardFooter		 9.158 kB
3.844 kB
react-card
CardHeader		 11.048 kB
4.538 kB
react-card
CardPreview		 9.963 kB
4.192 kB
react-checkbox
Checkbox		 34.216 kB
10.784 kB
react-combobox
Combobox (including child components)		 87.199 kB
28.095 kB
react-combobox
Dropdown (including child components)		 85.583 kB
27.692 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 65.31 kB
17.931 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 204.34 kB
57.141 kB
react-components
react-components: FluentProvider & webLightTheme		 36.086 kB
11.9 kB
react-datepicker-compat
DatePicker Compat		 220.251 kB
58.471 kB
react-dialog
Dialog (including children components)		 90.867 kB
27.047 kB
react-divider
Divider		 17.399 kB
6.298 kB
react-field
Field		 18.864 kB
7.004 kB
react-image
Image		 11.479 kB
4.573 kB
react-infobutton
InfoButton		 127.925 kB
39.003 kB
react-infobutton
InfoLabel		 131.208 kB
39.996 kB
react-input
Input		 23.972 kB
7.676 kB
react-label
Label		 10.104 kB
4.185 kB
react-link
Link		 12.357 kB
5.091 kB
react-menu
Menu (including children components)		 128.202 kB
39.18 kB
react-menu
Menu (including selectable components)		 131.186 kB
39.696 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 64.485 kB
16.9 kB
react-popover
Popover		 114.917 kB
35.388 kB
react-portal
Portal		 11.649 kB
4.262 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.186 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 13.856 kB
5.434 kB
react-provider
FluentProvider		 18.033 kB
6.666 kB
react-radio
Radio		 27.282 kB
8.661 kB
react-radio
RadioGroup		 11.312 kB
4.71 kB
react-select
Select		 25.357 kB
8.798 kB
react-slider
Slider		 34.112 kB
11.018 kB
react-spinbutton
SpinButton		 33.882 kB
10.325 kB
react-spinner
Spinner		 20.882 kB
6.798 kB
react-switch
Switch		 29.806 kB
9.274 kB
react-table
DataGrid		 147.659 kB
40.567 kB
react-table
Table (Primitives only)		 44.348 kB
12.347 kB
react-table
Table as DataGrid		 130.218 kB
33.128 kB
react-table
Table (Selection only)		 78.132 kB
19.127 kB
react-table
Table (Sort only)		 77.462 kB
18.939 kB
react-text
Text - Default		 12.492 kB
4.92 kB
react-text
Text - Wrappers		 15.624 kB
5.232 kB
react-textarea
Textarea		 27.399 kB
9.041 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.33 kB
6.764 kB
react-theme
Teams: Light theme		 17.895 kB
5.162 kB
react-tooltip
Tooltip		 46.656 kB
16.369 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 43d6e99d28aa0e7bd7111f1043348683646eaa5b

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 710 716 5000
Button mount 390 368 5000
Field mount 1288 1284 5000
FluentProvider mount 913 895 5000
FluentProviderWithTheme mount 113 110 10
FluentProviderWithTheme virtual-rerender 92 95 10
FluentProviderWithTheme virtual-rerender-with-unmount 108 103 10
InfoButton mount 18 16 5000
MakeStyles mount 1141 1111 50000
Persona mount 2041 1977 5000
SpinButton mount 1596 1600 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 116 104 1.12:1
BoxMinimalPerf.default 257 243 1.06:1
VideoMinimalPerf.default 527 498 1.06:1
ReactionMinimalPerf.default 279 266 1.05:1
DropdownManyItemsPerf.default 498 479 1.04:1
LayoutMinimalPerf.default 270 259 1.04:1
LoaderMinimalPerf.default 250 240 1.04:1
TreeWith60ListItems.default 108 104 1.04:1
FlexMinimalPerf.default 201 196 1.03:1
GridMinimalPerf.default 248 241 1.03:1
ItemLayoutMinimalPerf.default 914 889 1.03:1
AnimationMinimalPerf.default 371 362 1.02:1
MenuMinimalPerf.default 624 613 1.02:1
RadioGroupMinimalPerf.default 341 334 1.02:1
ToolbarMinimalPerf.default 669 658 1.02:1
AttachmentSlotsPerf.default 833 821 1.01:1
AvatarMinimalPerf.default 133 132 1.01:1
ChatDuplicateMessagesPerf.default 194 193 1.01:1
ChatMinimalPerf.default 538 534 1.01:1
InputMinimalPerf.default 726 719 1.01:1
MenuButtonMinimalPerf.default 1269 1261 1.01:1
PopupMinimalPerf.default 456 451 1.01:1
ProviderMergeThemesPerf.default 978 973 1.01:1
SliderMinimalPerf.default 918 909 1.01:1
TableManyItemsPerf.default 1449 1441 1.01:1
TextMinimalPerf.default 251 249 1.01:1
ButtonSlotsPerf.default 402 404 1:1
CarouselMinimalPerf.default 345 345 1:1
CheckboxMinimalPerf.default 1576 1570 1:1
DatepickerMinimalPerf.default 4549 4567 1:1
DividerMinimalPerf.default 255 255 1:1
DropdownMinimalPerf.default 1819 1820 1:1
ListMinimalPerf.default 383 383 1:1
ListNestedPerf.default 408 407 1:1
RosterPerf.default 1814 1808 1:1
PortalMinimalPerf.default 120 120 1:1
ProviderMinimalPerf.default 268 268 1:1
SplitButtonMinimalPerf.default 3006 3009 1:1
StatusMinimalPerf.default 506 507 1:1
CustomToolbarPrototype.default 1906 1904 1:1
TooltipMinimalPerf.default 1599 1606 1:1
AccordionMinimalPerf.default 102 103 0.99:1
AlertMinimalPerf.default 192 194 0.99:1
ButtonOverridesMissPerf.default 818 827 0.99:1
DialogMinimalPerf.default 580 583 0.99:1
EmbedMinimalPerf.default 2389 2404 0.99:1
HeaderSlotsPerf.default 577 581 0.99:1
ImageMinimalPerf.default 279 281 0.99:1
LabelMinimalPerf.default 279 283 0.99:1
RefMinimalPerf.default 137 139 0.99:1
SegmentMinimalPerf.default 253 255 0.99:1
TableMinimalPerf.default 297 299 0.99:1
TreeMinimalPerf.default 586 589 0.99:1
ChatWithPopoverPerf.default 244 248 0.98:1
ListCommonPerf.default 485 493 0.98:1
CardMinimalPerf.default 370 380 0.97:1
HeaderMinimalPerf.default 263 270 0.97:1
SkeletonMinimalPerf.default 249 257 0.97:1
TextAreaMinimalPerf.default 345 355 0.97:1
AttachmentMinimalPerf.default 95 99 0.96:1
FormMinimalPerf.default 270 284 0.95:1
ListWith60ListItems.default 471 498 0.95:1
IconMinimalPerf.default 453 475 0.95:1

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tabs@v9.3.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-theme@v9.1.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-theme-sass@v9.0.0-alpha.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-progress@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-overflow@v9.0.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-field@v9.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-jsx-runtime@v9.0.0-alpha.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-menu@v9.7.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-label@v9.1.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-utilities@v9.8.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-migration-v8-v9@v9.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-slider@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-popover@v9.5.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-positioning@v9.5.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-virtualizer@v9.0.0-alpha.19 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-table@v9.2.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-switch@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-select@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-infobutton@v9.0.0-beta.29 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-spinbutton@v9.2.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-divider@v9.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-toolbar@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-portal@v9.2.7 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-persona@v9.2.10 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-spinner@v9.1.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-link@v9.0.37 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tooltip@v9.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-dialog@v9.5.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tree@v9.0.0-beta.13 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-input@v9.4.12 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell approved these changes

@sopranopillow sopranopillow sopranopillow approved these changes

@ling1726 ling1726 ling1726 approved these changes

@behowell behowell behowell approved these changes

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@khmakoto khmakoto Awaiting requested review from khmakoto

@YuanboXue-Amber YuanboXue-Amber Awaiting requested review from YuanboXue-Amber

@Mitch-At-Work Mitch-At-Work Awaiting requested review from Mitch-At-Work

@tomi-msft tomi-msft Awaiting requested review from tomi-msft

@ms-acalzaretto ms-acalzaretto Awaiting requested review from ms-acalzaretto ms-acalzaretto is a code owner

@chpalac chpalac Awaiting requested review from chpalac

@spmonahan spmonahan Awaiting requested review from spmonahan

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

@smhigley smhigley Awaiting requested review from smhigley

Assignees

@bsunderhus bsunderhus

Labels
None yet
Projects
None yet
Milestone
May Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
8 participants
@layershifter @fabricteam @Hotell @msft-fluent-ui-bot @sopranopillow @ling1726 @behowell @bsunderhus