Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-skeleton): Release react-skeleton to stable #27767

Merged
merged 7 commits into from
May 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "chore: Releasing react-skeleton to stable.",
"packageName": "@fluentui/react-components",
"email": "ololubek@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "none",
"comment": "chore: move makeStyles() calls to .styles.ts files",
"packageName": "@fluentui/react-skeleton",
"email": "olfedias@microsoft.com",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "none",
"comment": "chore: exclude .swcrc from being published",
"packageName": "@fluentui/react-skeleton",
"email": "olfedias@microsoft.com",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "chore: Releasing react-skeleton to stable.",
"packageName": "@fluentui/react-skeleton",
"email": "ololubek@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "none",
"comment": "fix: Scale pulse animation with percentages and flip wave animation's direction.",
"packageName": "@fluentui/react-skeleton",
"email": "ololubek@microsoft.com",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,8 @@ import { renderProgressBar_unstable } from '@fluentui/react-progress';
import { renderRadio_unstable } from '@fluentui/react-radio';
import { renderRadioGroup_unstable } from '@fluentui/react-radio';
import { renderSelect_unstable } from '@fluentui/react-select';
import { renderSkeleton_unstable } from '@fluentui/react-skeleton';
import { renderSkeletonItem_unstable } from '@fluentui/react-skeleton';
import { renderSlider_unstable } from '@fluentui/react-slider';
import { renderSpinButton_unstable } from '@fluentui/react-spinbutton';
import { renderSpinner_unstable } from '@fluentui/react-spinner';
Expand Down Expand Up @@ -573,6 +575,18 @@ import { SelectTabEventHandler } from '@fluentui/react-tabs';
import { ShadowBrandTokens } from '@fluentui/react-theme';
import { ShadowTokens } from '@fluentui/react-theme';
import { shorthands } from '@griffel/react';
import { Skeleton } from '@fluentui/react-skeleton';
import { skeletonClassNames } from '@fluentui/react-skeleton';
import { SkeletonContextProvider } from '@fluentui/react-skeleton';
import { SkeletonContextValue } from '@fluentui/react-skeleton';
import { SkeletonItem } from '@fluentui/react-skeleton';
import { skeletonItemClassNames } from '@fluentui/react-skeleton';
import { SkeletonItemProps } from '@fluentui/react-skeleton';
import { SkeletonItemSlots } from '@fluentui/react-skeleton';
import { SkeletonItemState } from '@fluentui/react-skeleton';
import { SkeletonProps } from '@fluentui/react-skeleton';
import { SkeletonSlots } from '@fluentui/react-skeleton';
import { SkeletonState } from '@fluentui/react-skeleton';
import { Slider } from '@fluentui/react-slider';
import { sliderClassNames } from '@fluentui/react-slider';
import { sliderCSSVars } from '@fluentui/react-slider';
Expand Down Expand Up @@ -933,6 +947,11 @@ import { useRadioStyles_unstable } from '@fluentui/react-radio';
import { useScrollbarWidth } from '@fluentui/react-utilities';
import { useSelect_unstable } from '@fluentui/react-select';
import { useSelectStyles_unstable } from '@fluentui/react-select';
import { useSkeleton_unstable } from '@fluentui/react-skeleton';
import { useSkeletonContext } from '@fluentui/react-skeleton';
import { useSkeletonItem_unstable } from '@fluentui/react-skeleton';
import { useSkeletonItemStyles_unstable } from '@fluentui/react-skeleton';
import { useSkeletonStyles_unstable } from '@fluentui/react-skeleton';
import { useSlider_unstable } from '@fluentui/react-slider';
import { useSliderState_unstable } from '@fluentui/react-slider';
import { useSliderStyles_unstable } from '@fluentui/react-slider';
Expand Down Expand Up @@ -2060,6 +2079,10 @@ export { renderRadioGroup_unstable }

export { renderSelect_unstable }

export { renderSkeleton_unstable }

export { renderSkeletonItem_unstable }

export { renderSlider_unstable }

export { renderSpinButton_unstable }
Expand Down Expand Up @@ -2142,6 +2165,30 @@ export { ShadowTokens }

export { shorthands }

export { Skeleton }

export { skeletonClassNames }

export { SkeletonContextProvider }

export { SkeletonContextValue }

export { SkeletonItem }

export { skeletonItemClassNames }

export { SkeletonItemProps }

export { SkeletonItemSlots }

export { SkeletonItemState }

export { SkeletonProps }

export { SkeletonSlots }

export { SkeletonState }

export { Slider }

export { sliderClassNames }
Expand Down Expand Up @@ -2862,6 +2909,16 @@ export { useSelect_unstable }

export { useSelectStyles_unstable }

export { useSkeleton_unstable }

export { useSkeletonContext }

export { useSkeletonItem_unstable }

export { useSkeletonItemStyles_unstable }

export { useSkeletonStyles_unstable }

export { useSlider_unstable }

export { useSliderState_unstable }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,12 @@ import { NestedTreeItem } from '@fluentui/react-tree';
import { renderAlert_unstable } from '@fluentui/react-alert';
import { renderInfoButton_unstable } from '@fluentui/react-infobutton';
import { renderInfoLabel_unstable } from '@fluentui/react-infobutton';
import { renderSkeleton_unstable } from '@fluentui/react-skeleton';
import { renderSkeletonItem_unstable } from '@fluentui/react-skeleton';
import { renderTree_unstable } from '@fluentui/react-tree';
import { renderTreeItem_unstable } from '@fluentui/react-tree';
import { renderTreeItemLayout_unstable } from '@fluentui/react-tree';
import { renderTreeItemPersonaLayout_unstable } from '@fluentui/react-tree';
import { renderVirtualizer_unstable } from '@fluentui/react-virtualizer';
import { renderVirtualizerScrollView_unstable } from '@fluentui/react-virtualizer';
import { Skeleton } from '@fluentui/react-skeleton';
import { skeletonClassNames } from '@fluentui/react-skeleton';
import { SkeletonContextProvider } from '@fluentui/react-skeleton';
import { SkeletonContextValue } from '@fluentui/react-skeleton';
import { SkeletonItem } from '@fluentui/react-skeleton';
import { skeletonItemClassNames } from '@fluentui/react-skeleton';
import { SkeletonItemProps } from '@fluentui/react-skeleton';
import { SkeletonItemSlots } from '@fluentui/react-skeleton';
import { SkeletonItemState } from '@fluentui/react-skeleton';
import { SkeletonProps } from '@fluentui/react-skeleton';
import { SkeletonSlots } from '@fluentui/react-skeleton';
import { SkeletonState } from '@fluentui/react-skeleton';
import { Tree } from '@fluentui/react-tree';
import { treeClassNames } from '@fluentui/react-tree';
import { TreeContextValue } from '@fluentui/react-tree';
Expand Down Expand Up @@ -84,11 +70,6 @@ import { useInfoButtonStyles_unstable } from '@fluentui/react-infobutton';
import { useInfoLabel_unstable } from '@fluentui/react-infobutton';
import { useInfoLabelStyles_unstable } from '@fluentui/react-infobutton';
import { useIntersectionObserver } from '@fluentui/react-virtualizer';
import { useSkeleton_unstable } from '@fluentui/react-skeleton';
import { useSkeletonContext } from '@fluentui/react-skeleton';
import { useSkeletonItem_unstable } from '@fluentui/react-skeleton';
import { useSkeletonItemStyles_unstable } from '@fluentui/react-skeleton';
import { useSkeletonStyles_unstable } from '@fluentui/react-skeleton';
import { useStaticVirtualizerMeasure } from '@fluentui/react-virtualizer';
import { useTree_unstable } from '@fluentui/react-tree';
import { useTreeContext_unstable } from '@fluentui/react-tree';
Expand Down Expand Up @@ -164,10 +145,6 @@ export { renderInfoButton_unstable }

export { renderInfoLabel_unstable }

export { renderSkeleton_unstable }

export { renderSkeletonItem_unstable }

export { renderTree_unstable }

export { renderTreeItem_unstable }
Expand All @@ -180,30 +157,6 @@ export { renderVirtualizer_unstable }

export { renderVirtualizerScrollView_unstable }

export { Skeleton }

export { skeletonClassNames }

export { SkeletonContextProvider }

export { SkeletonContextValue }

export { SkeletonItem }

export { skeletonItemClassNames }

export { SkeletonItemProps }

export { SkeletonItemSlots }

export { SkeletonItemState }

export { SkeletonProps }

export { SkeletonSlots }

export { SkeletonState }

export { Tree }

export { treeClassNames }
Expand Down Expand Up @@ -276,16 +229,6 @@ export { useInfoLabelStyles_unstable }

export { useIntersectionObserver }

export { useSkeleton_unstable }

export { useSkeletonContext }

export { useSkeletonItem_unstable }

export { useSkeletonItemStyles_unstable }

export { useSkeletonStyles_unstable }

export { useStaticVirtualizerMeasure }

export { useTree_unstable }
Expand Down
23 changes: 23 additions & 0 deletions packages/react-components/react-components/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,29 @@ export {
useSelect_unstable,
} from '@fluentui/react-select';
export type { SelectOnChangeData, SelectProps, SelectSlots, SelectState } from '@fluentui/react-select';
export {
Skeleton,
renderSkeleton_unstable,
skeletonClassNames,
useSkeletonStyles_unstable,
useSkeleton_unstable,
SkeletonItem,
renderSkeletonItem_unstable,
skeletonItemClassNames,
useSkeletonItemStyles_unstable,
useSkeletonItem_unstable,
SkeletonContextProvider,
useSkeletonContext,
} from '@fluentui/react-skeleton';
export type {
SkeletonProps,
SkeletonSlots,
SkeletonState,
SkeletonItemProps,
SkeletonItemSlots,
SkeletonItemState,
SkeletonContextValue,
} from '@fluentui/react-skeleton';
export {
Slider,
sliderClassNames,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,30 +30,6 @@ export type {
InfoLabelState,
} from '@fluentui/react-infobutton';

export {
Skeleton,
renderSkeleton_unstable,
skeletonClassNames,
useSkeletonStyles_unstable,
useSkeleton_unstable,
SkeletonItem,
renderSkeletonItem_unstable,
skeletonItemClassNames,
useSkeletonItemStyles_unstable,
useSkeletonItem_unstable,
SkeletonContextProvider,
useSkeletonContext,
} from '@fluentui/react-skeleton';
export type {
SkeletonProps,
SkeletonSlots,
SkeletonState,
SkeletonItemProps,
SkeletonItemSlots,
SkeletonItemState,
SkeletonContextValue,
} from '@fluentui/react-skeleton';

export {
Virtualizer,
virtualizerClassNames,
Expand Down
8 changes: 7 additions & 1 deletion packages/react-components/react-skeleton/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,10 @@

**React Skeleton components for [Fluent UI React](https://react.fluentui.dev/)**

These are not production-ready components and **should never be used in product**. This space is useful for testing new components whose APIs might change before final release.
## Usage

To import `Skeleton`:

```js
import { Skeleton, SkeletonItem } from '@fluentui/react-components';
```
3 changes: 1 addition & 2 deletions packages/react-components/react-skeleton/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@
"beachball": {
"disallowedChangeTypes": [
"major",
"minor",
"patch"
"prerelease"
]
},
"exports": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as React from 'react';
import { Field, makeStyles, tokens } from '@fluentui/react-components';
import type { SkeletonProps } from '@fluentui/react-components/unstable';
import { Skeleton, SkeletonItem } from '@fluentui/react-components/unstable';
import { Field, Skeleton, SkeletonItem, makeStyles, tokens } from '@fluentui/react-components';
import type { SkeletonProps } from '@fluentui/react-components';

const useStyles = makeStyles({
invertedWrapper: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as React from 'react';
import { Field, makeStyles, tokens } from '@fluentui/react-components';
import type { SkeletonProps } from '@fluentui/react-components/unstable';
import { Skeleton, SkeletonItem } from '@fluentui/react-components/unstable';
import { Field, Skeleton, SkeletonItem, makeStyles, tokens } from '@fluentui/react-components';
import type { SkeletonProps } from '@fluentui/react-components';

const useStyles = makeStyles({
invertedWrapper: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import { Skeleton, SkeletonItem } from '@fluentui/react-components/unstable';
import type { SkeletonProps } from '@fluentui/react-components/unstable';
import { Skeleton, SkeletonItem } from '@fluentui/react-components';
import type { SkeletonProps } from '@fluentui/react-components';

export const Default = (props: Partial<SkeletonProps>) => (
<Skeleton {...props}>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
<!-- Don't allow prettier to collapse code block into single line -->
<!-- prettier-ignore -->
> **⚠️ Preview components are considered unstable:**
>
> ```jsx
>
> import { Skeleton, SkeletonItem } from '@fluentui/react-components/unstable';
> import { Skeleton, SkeletonItem } from '@fluentui/react-components';
>
> ```
>
> - Features and APIs may change before final release
> - Please contact us if you intend to use this in your product

The `Skeleton` component is a temporary animation placeholder for when a service call takes time to return data and we don't want to block rendering the rest of the UI.
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as React from 'react';
import { makeStyles, shorthands, tokens } from '@fluentui/react-components';
import type { SkeletonProps } from '@fluentui/react-components/unstable';
import { Skeleton, SkeletonItem } from '@fluentui/react-components/unstable';
import { Skeleton, SkeletonItem, makeStyles, shorthands, tokens } from '@fluentui/react-components';
import type { SkeletonProps } from '@fluentui/react-components';

const useStyles = makeStyles({
invertedWrapper: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Skeleton } from '@fluentui/react-components/unstable';
import { Skeleton } from '@fluentui/react-components';

import descriptionMd from './SkeletonDescription.md';
import bestPracticesMd from './SkeletonBestPractices.md';
Expand Down