Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react-skeleton): fix section and update description #27959

Merged
merged 1 commit into from
May 23, 2023

Conversation

layershifter
Copy link
Member

Skeleton was promoted to stable (#27767), but it's still under "Preview". This PR fixes that:

image

@layershifter layershifter marked this pull request as ready for review May 23, 2023 13:45
@layershifter layershifter requested a review from a team as a code owner May 23, 2023 13:45
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 580 571 5000
Button mount 296 296 5000
Field mount 1031 1000 5000
FluentProvider mount 639 646 5000
FluentProviderWithTheme mount 80 76 10
FluentProviderWithTheme virtual-rerender 64 75 10
FluentProviderWithTheme virtual-rerender-with-unmount 67 76 10
InfoButton mount 18 13 5000
MakeStyles mount 839 856 50000
Persona mount 1617 1522 5000
SpinButton mount 1208 1259 5000

@size-auditor
Copy link

size-auditor bot commented May 23, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ab53a4c86a49a4d4268f3d87809bee263f818c5d (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 025a3b2:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
64.855 kB
17.852 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
205.944 kB
57.706 kB
react-components
react-components: FluentProvider & webLightTheme
36.086 kB
11.9 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.186 kB
🤖 This report was generated against ab53a4c86a49a4d4268f3d87809bee263f818c5d

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 23, 2023
@layershifter layershifter merged commit 83e39d4 into microsoft:master May 23, 2023
@layershifter layershifter deleted the docs/fix-skeleton-state branch May 23, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants