Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve v9 type-checking speed by ~80% with manual ghost dependencies build step on CI #28002

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 43 additions & 28 deletions .devops/templates/build-test-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,43 +6,58 @@ steps:
filePath: yarn-ci.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots

Pivot - Overflow 2 screenshots
Image Name Diff(in Pixels) Image Type
Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png 0 Added
Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png 0 Added

displayName: yarn (install packages)

- script: |
yarn nx run @fluentui/workspace-plugin:check-graph
yarn nx g @fluentui/workspace-plugin:tsconfig-base-all --verify
yarn nx g @fluentui/workspace-plugin:normalize-package-dependencies --verify

displayName: Workspace lint
# - script: |
# yarn nx run @fluentui/workspace-plugin:check-graph
# yarn nx g @fluentui/workspace-plugin:tsconfig-base-all --verify
# yarn nx g @fluentui/workspace-plugin:normalize-package-dependencies --verify

# displayName: Workspace lint

# - script: |
# # @fluentui/api-docs is used within apps/public-docsite-resources/just.config.ts, thus it needs to be build in advance
# yarn workspace @fluentui/api-docs build
# # @fluentui/digest is used within packages/fluentui/perf-test-northstar/just.config.ts, thus it needs to be build in advance
# yarn workspace @fluentui/digest build
# yarn tsc -p ./tsconfig.json
# displayName: Type-check just.config.ts files

# - script: |
# yarn check:installed-dependencies-versions
# displayName: 'check packages: installed dependencies versions'

# - script: |
# if [[ -n "$(targetBranch)" ]]; then
# yarn format --since $(targetBranch) --check
# else
# yarn format --all --check
# fi
# displayName: check formatting

- script: |
# @fluentui/api-docs is used within apps/public-docsite-resources/just.config.ts, thus it needs to be build in advance
yarn workspace @fluentui/api-docs build
# @fluentui/digest is used within packages/fluentui/perf-test-northstar/just.config.ts, thus it needs to be build in advance
yarn workspace @fluentui/digest build
yarn tsc -p ./tsconfig.json
displayName: Type-check just.config.ts files
## Danger.js checks for Fluent UI N*
# - script: |
# DANGER_DISABLE_TRANSPILATION="true" yarn danger ci
# displayName: danger
# condition: eq(variables.isPR, true)
# env:
# DANGER_GITHUB_API_TOKEN: $(DANGER_GITHUB_API_TOKEN)

- script: |
yarn check:installed-dependencies-versions
displayName: 'check packages: installed dependencies versions'
node ./scripts/executors/type-check-ci-hack.js --base $(targetBranch)
yarn lage build --to react-storybook-addon-export-to-sandbox --verbose
displayName: type-check perf preparation

- script: |
if [[ -n "$(targetBranch)" ]]; then
yarn format --since $(targetBranch) --check
else
yarn format --all --check
fi
displayName: check formatting
yarn lage type-check --to react-text --verbose
cat packages/react-components/react-text/tsconfig.json
displayName: type-check via just

## Danger.js checks for Fluent UI N*
- script: |
DANGER_DISABLE_TRANSPILATION="true" yarn danger ci
displayName: danger
condition: eq(variables.isPR, true)
env:
DANGER_GITHUB_API_TOKEN: $(DANGER_GITHUB_API_TOKEN)
cat packages/react-components/react-text/tsconfig.json
yarn workspace @fluentui/react-text tsc -b
displayName: type-check via tsc -b

- script: |
yarn buildci $(sinceArg)
displayName: build, test, lint, test-ssr
displayName: build, test, lint, test-ssr, type-check

- template: cleanup.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/babel-preset-global-context",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/global-context",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/keyboard-keys",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/priority-overflow",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-accordion",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-alert",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-aria",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-avatar",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-badge",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-breadcrumb",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-button",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-card",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-checkbox",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-combobox",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-components",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "chore: add generate-api task to react-conformance in order to be able to run generate-api task for v9",
"packageName": "@fluentui/react-conformance",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-conformance-griffel",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-context-selector",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-data-grid-react-window",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-datepicker-compat",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-dialog",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-divider",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-drawer",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-field",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-image",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-infobutton",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-input",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-jsx-runtime",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-label",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-link",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-menu",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-motions-preview",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-overflow",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-persona",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-popover",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-portal",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-portal-compat",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-portal-compat-context",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "perf: use type-check task to improve type-checking speeds up to 60%",
"packageName": "@fluentui/react-positioning",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
Loading
Loading