Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-accordion): fix memory leak caused by context assignment #29193

Merged

Conversation

layershifter
Copy link
Member

Previous Behavior

Accordion causes memory leaks.

New Behavior

Accordion does not cause memory leaks via a workaround.

Related Issue(s)

@layershifter layershifter requested a review from a team as a code owner September 20, 2023 12:03
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3958902:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 15 16 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 627 653 5000
Button mount 306 335 5000
Field mount 1117 1092 5000
FluentProvider mount 680 697 5000
FluentProviderWithTheme mount 81 80 10
FluentProviderWithTheme virtual-rerender 71 72 10
FluentProviderWithTheme virtual-rerender-with-unmount 78 71 10
InfoButton mount 15 16 5000 Possible regression
MakeStyles mount 855 839 50000
Persona mount 1753 1710 5000
SpinButton mount 1358 1372 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
91.584 kB
27.965 kB
91.583 kB
27.954 kB
-1 B
-11 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.347 kB
59.369 kB
208.346 kB
59.359 kB
-1 B
-10 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.526 kB
19.647 kB
react-components
react-components: FluentProvider & webLightTheme
40.92 kB
13.553 kB
react-portal-compat
PortalCompatProvider
6.541 kB
2.227 kB
🤖 This report was generated against 54f2d12c318d44326f91d9db9ef7855e48de4520

@size-auditor
Copy link

size-auditor bot commented Sep 20, 2023

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: b824db7

Possible causes

  • The baseline build b824db7 is broken
  • The Size Auditor run for the baseline build b824db7 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@layershifter
Copy link
Member Author

layershifter commented Sep 20, 2023

Force merged to unblock upgrade of Fluent in Teams: approvals from team members are present, CI is green.

@layershifter layershifter merged commit c60d4e7 into microsoft:master Sep 20, 2023
24 checks passed
@layershifter layershifter deleted the fix/memory-leak-by-context branch September 20, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants