Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-drawer): use context to fetch dialog id #29273

Conversation

marcosmoura
Copy link
Contributor

Previous Behavior

The Drawer was creating the title to fetch the generated id, as the dialog context was not exported by the react-dialog package.

New Behavior

Now that the dialog context is available publicly, it is now using the context to fetch the generated dialog id.

@marcosmoura marcosmoura requested a review from a team as a code owner September 25, 2023 11:35
@marcosmoura marcosmoura self-assigned this Sep 25, 2023
@marcosmoura marcosmoura added the Component: Drawer The Fluent v9 Drawer component label Sep 25, 2023
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 656 631 5000
Button mount 313 324 5000
Field mount 1116 1152 5000
FluentProvider mount 692 691 5000
FluentProviderWithTheme mount 80 83 10
FluentProviderWithTheme virtual-rerender 65 63 10
FluentProviderWithTheme virtual-rerender-with-unmount 77 77 10
InfoButton mount 18 11 5000
MakeStyles mount 851 841 50000
Persona mount 1718 1700 5000
SpinButton mount 1370 1337 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b667feb:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.572 kB
19.658 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.688 kB
59.552 kB
react-components
react-components: FluentProvider & webLightTheme
40.966 kB
13.569 kB
react-portal-compat
PortalCompatProvider
6.541 kB
2.227 kB
🤖 This report was generated against 9512bd6fd80ba221b1c9adf5c5ea85972e3b879e

@size-auditor
Copy link

size-auditor bot commented Sep 25, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3056ec3f0035e3dd2210cd2a91986111ff8ce82a (build)

@marcosmoura marcosmoura merged commit a56c408 into microsoft:master Sep 25, 2023
24 checks passed
@marcosmoura marcosmoura deleted the fix/react-drawer/use-context-tofetch-dialog-id branch November 15, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Drawer The Fluent v9 Drawer component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants