Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): increase pipeline agent timeout threshold #29710

Merged
merged 4 commits into from
Nov 1, 2023
Merged

fix(CI): increase pipeline agent timeout threshold #29710

merged 4 commits into from
Nov 1, 2023

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Oct 31, 2023 •
edited
Loading

Issue:

Previous Behavior

  • agents for the CI pipeline timeout after 60 minutes.

New Behavior

@TristanWatanabe TristanWatanabe self-assigned this Oct 31, 2023
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner October 31, 2023 18:45
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 31, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 648 631 5000
Button mount 321 317 5000
Field mount 1138 1140 5000
FluentProvider mount 730 722 5000
FluentProviderWithTheme mount 75 84 10
FluentProviderWithTheme virtual-rerender 68 61 10
FluentProviderWithTheme virtual-rerender-with-unmount 75 77 10
MakeStyles mount 855 860 50000
Persona mount 1777 1775 5000
SpinButton mount 1386 1344 5000

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Oct 31, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a50dfb:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 31, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 31, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AttachmentMinimalPerf.default 81 76 1.07:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
VideoMinimalPerf.default 446 407 1.1:1
LoaderMinimalPerf.default 203 186 1.09:1
RosterPerf.default 1616 1492 1.08:1
CardMinimalPerf.default 320 298 1.07:1
PortalMinimalPerf.default 91 85 1.07:1
RadioGroupMinimalPerf.default 264 246 1.07:1
CarouselMinimalPerf.default 269 254 1.06:1
ListNestedPerf.default 326 308 1.06:1
ButtonMinimalPerf.default 88 84 1.05:1
DividerMinimalPerf.default 203 193 1.05:1
SkeletonMinimalPerf.default 200 191 1.05:1
ButtonSlotsPerf.default 315 302 1.04:1
GridMinimalPerf.default 187 179 1.04:1
TableMinimalPerf.default 232 223 1.04:1
ButtonOverridesMissPerf.default 662 640 1.03:1
LabelMinimalPerf.default 220 213 1.03:1
StatusMinimalPerf.default 405 393 1.03:1
IconMinimalPerf.default 400 388 1.03:1
TextMinimalPerf.default 191 185 1.03:1
AnimationMinimalPerf.default 297 290 1.02:1
AttachmentSlotsPerf.default 640 629 1.02:1
BoxMinimalPerf.default 191 187 1.02:1
ChatDuplicateMessagesPerf.default 154 151 1.02:1
CheckboxMinimalPerf.default 1137 1113 1.02:1
DropdownManyItemsPerf.default 395 388 1.02:1
ListMinimalPerf.default 318 312 1.02:1
TooltipMinimalPerf.default 1291 1262 1.02:1
DatepickerMinimalPerf.default 3612 3574 1.01:1
EmbedMinimalPerf.default 1900 1876 1.01:1
FormMinimalPerf.default 222 219 1.01:1
ProviderMergeThemesPerf.default 631 626 1.01:1
SegmentMinimalPerf.default 196 194 1.01:1
SliderMinimalPerf.default 722 716 1.01:1
TableManyItemsPerf.default 1111 1098 1.01:1
TextAreaMinimalPerf.default 283 279 1.01:1
HeaderSlotsPerf.default 458 460 1:1
ImageMinimalPerf.default 220 221 1:1
InputMinimalPerf.default 545 545 1:1
ItemLayoutMinimalPerf.default 729 730 1:1
ListWith60ListItems.default 358 358 1:1
MenuMinimalPerf.default 496 497 1:1
ToolbarMinimalPerf.default 529 529 1:1
DialogMinimalPerf.default 436 439 0.99:1
ListCommonPerf.default 385 387 0.99:1
PopupMinimalPerf.default 345 349 0.99:1
SplitButtonMinimalPerf.default 2198 2219 0.99:1
CustomToolbarPrototype.default 1492 1501 0.99:1
DropdownMinimalPerf.default 1411 1440 0.98:1
MenuButtonMinimalPerf.default 948 968 0.98:1
TreeMinimalPerf.default 474 486 0.98:1
AlertMinimalPerf.default 155 159 0.97:1
FlexMinimalPerf.default 154 158 0.97:1
AccordionMinimalPerf.default 76 79 0.96:1
ChatMinimalPerf.default 430 447 0.96:1
LayoutMinimalPerf.default 193 201 0.96:1
TreeWith60ListItems.default 82 85 0.96:1
ChatWithPopoverPerf.default 180 189 0.95:1
RefMinimalPerf.default 105 110 0.95:1
HeaderMinimalPerf.default 208 221 0.94:1
ReactionMinimalPerf.default 214 227 0.94:1
AvatarMinimalPerf.default 108 116 0.93:1
ProviderMinimalPerf.default 187 203 0.92:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 31, 2023 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 31, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
330 B
global-context
createContextSelector		 537 B
342 B
priority-overflow
createOverflowManager		 4.341 kB
1.81 kB
react-accordion
Accordion (including children components)		 92.983 kB
28.418 kB
react-alert
Alert		 84.293 kB
23.456 kB
react-avatar
Avatar		 50.534 kB
15.923 kB
react-avatar
AvatarGroup		 20.064 kB
7.894 kB
react-avatar
AvatarGroupItem		 65.19 kB
20.259 kB
react-badge
Badge		 27.264 kB
8.808 kB
react-badge
CounterBadge		 28.165 kB
9.101 kB
react-badge
PresenceBadge		 25.67 kB
9.313 kB
react-button
Button		 40.074 kB
11.292 kB
react-button
CompoundButton		 47.43 kB
12.787 kB
react-button
MenuButton		 44.848 kB
12.668 kB
react-button
SplitButton		 52.862 kB
14.254 kB
react-button
ToggleButton		 57.122 kB
13.194 kB
react-calendar-compat
Calendar Compat		 141.324 kB
36.821 kB
react-card
Card - All		 92.955 kB
26.977 kB
react-card
Card		 87.781 kB
25.462 kB
react-card
CardFooter		 13.423 kB
5.481 kB
react-card
CardHeader		 15.666 kB
6.235 kB
react-card
CardPreview		 14.374 kB
5.854 kB
react-checkbox
Checkbox		 37.505 kB
12.327 kB
react-combobox
Combobox (including child components)		 92.033 kB
30.008 kB
react-combobox
Dropdown (including child components)		 90.475 kB
29.668 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 70.007 kB
20.164 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 207.417 kB
59.289 kB
react-components
react-components: FluentProvider & webLightTheme		 42.291 kB
14.005 kB
react-datepicker-compat
DatePicker Compat		 212.494 kB
59.326 kB
react-dialog
Dialog (including children components)		 94.473 kB
28.28 kB
react-divider
Divider		 21.179 kB
7.839 kB
react-field
Field		 22.788 kB
8.639 kB
react-image
Image		 16.096 kB
6.317 kB
react-infobutton
InfoButton		 130.729 kB
41.194 kB
react-infobutton
InfoLabel		 134.413 kB
42.351 kB
react-input
Input		 27.247 kB
9.194 kB
react-jsx-runtime
Classic Pragma		 1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime		 4.14 kB
1.741 kB
react-jsx-runtime
JSX Runtime		 4.734 kB
1.983 kB
react-label
Label		 14.508 kB
5.857 kB
react-link
Link		 17.4 kB
6.977 kB
react-menu
Menu (including children components)		 140.176 kB
43.004 kB
react-menu
Menu (including selectable components)		 142.862 kB
43.51 kB
react-message-bar
MessageBar (all components)		 25.54 kB
9.102 kB
react-overflow
hooks only		 12.598 kB
4.754 kB
react-persona
Persona		 57.425 kB
17.798 kB
react-popover
Popover		 119.46 kB
37.714 kB
react-portal
Portal		 12.4 kB
4.541 kB
react-portal-compat
PortalCompatProvider		 6.651 kB
2.252 kB
react-positioning
usePositioning		 25.305 kB
9.162 kB
react-progress
ProgressBar		 17.788 kB
6.986 kB
react-provider
FluentProvider		 22.831 kB
8.429 kB
react-radio
Radio		 31.266 kB
10.267 kB
react-radio
RadioGroup		 15.704 kB
6.35 kB
react-select
Select		 28.968 kB
10.269 kB
react-slider
Slider		 38.349 kB
12.595 kB
react-spinbutton
SpinButton		 37.133 kB
11.856 kB
react-spinner
Spinner		 23.762 kB
8.556 kB
react-switch
Switch		 33.731 kB
10.899 kB
react-table
DataGrid		 157.084 kB
43.906 kB
react-table
Table (Primitives only)		 43.941 kB
13.76 kB
react-table
Table as DataGrid		 130.165 kB
35.174 kB
react-table
Table (Selection only)		 75.777 kB
20.477 kB
react-table
Table (Sort only)		 74.384 kB
20.075 kB
react-tags
InteractionTag		 15.618 kB
6.152 kB
react-tags
Tag		 30.341 kB
9.505 kB
react-tags
TagGroup		 73.816 kB
22.097 kB
react-text
Text - Default		 17.065 kB
6.645 kB
react-text
Text - Wrappers		 20.237 kB
6.965 kB
react-textarea
Textarea		 31.306 kB
10.549 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 34.616 kB
7.299 kB
react-theme
Teams: Light theme		 19.287 kB
5.49 kB
react-toast
Toast (including Toaster)		 92.725 kB
27.876 kB
react-tooltip
Tooltip		 52.466 kB
18.466 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 88574cc717e7bffe6f8f0f5fce191350066e7a62

@size-auditor Size Auditor
Copy link

size-auditor bot commented Oct 31, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 88574cc717e7bffe6f8f0f5fce191350066e7a62 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 31, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 31, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 636 632 5000
Breadcrumb mount 1659 1663 1000
Checkbox mount 1692 1677 5000
CheckboxBase mount 1428 1502 5000
ChoiceGroup mount 2949 2926 5000
ComboBox mount 644 677 1000
CommandBar mount 6179 6196 1000
ContextualMenu mount 11862 12064 1000
DefaultButton mount 745 741 5000
DetailsRow mount 2180 2186 5000
DetailsRowFast mount 2171 2191 5000
DetailsRowNoStyles mount 2056 1998 5000
Dialog mount 2767 2642 1000
DocumentCardTitle mount 229 236 1000
Dropdown mount 1954 2004 5000
FocusTrapZone mount 1129 1116 5000
FocusZone mount 1080 1057 5000
GroupedList mount 41145 41686 2
GroupedList virtual-rerender 19832 19946 2
GroupedList virtual-rerender-with-unmount 51056 50619 2
GroupedListV2 mount 226 233 2
GroupedListV2 virtual-rerender 214 209 2
GroupedListV2 virtual-rerender-with-unmount 242 216 2
IconButton mount 1067 1092 5000
Label mount 346 337 5000
Layer mount 2717 2777 5000
Link mount 398 394 5000
MenuButton mount 962 965 5000
MessageBar mount 21573 21566 5000
Nav mount 1924 1947 1000
OverflowSet mount 784 787 5000
Panel mount 1837 1820 1000
Persona mount 733 740 1000
Pivot mount 902 879 1000
PrimaryButton mount 846 839 5000
Rating mount 4604 4681 5000
SearchBox mount 961 905 5000
Shimmer mount 1868 1866 5000
Slider mount 1349 1324 5000
SpinButton mount 2927 2867 5000
Spinner mount 382 407 5000
SplitButton mount 1852 1844 5000
Stack mount 400 419 5000
StackWithIntrinsicChildren mount 854 841 5000
StackWithTextChildren mount 2623 2619 5000
SwatchColorPicker mount 6210 6111 5000
TagPicker mount 1456 1489 5000
Text mount 371 382 5000
TextField mount 942 946 5000
ThemeProvider mount 813 830 5000
ThemeProvider virtual-rerender 593 585 5000
ThemeProvider virtual-rerender-with-unmount 1269 1272 5000
Toggle mount 633 633 5000
buttonNative mount 194 197 5000

Hotell
Hotell reviewed Nov 1, 2023
View reviewed changes
@TristanWatanabe TristanWatanabe merged commit e6b58cd into microsoft:master Nov 1, 2023
@TristanWatanabe TristanWatanabe deleted the tristan/increase-pipeline-timeout branch November 1, 2023 15:50
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Nov 2, 2023
@marcosmoura
Merge branch 'master' into feat/react-drawer/release-to-stable
9bca8b3 
* master:
  breaking(react-drawer): open now only accepts a boolean instead of MotionShorthand (microsoft#29736)
  fix (breadcrumb): Overflow examples refactoring (microsoft#29723)
  refactor(tools): replace deprecated apis (microsoft#29624)
  [Part 3] Update documentation content for all charts (microsoft#29727)
  chore: throws if FlatTree is used as a subtree (microsoft#29729)
  feat(react-storybook-addon-export-to-sandbox): make addon generic so it can be published and use by others (microsoft#29674)
  chore(TimePicker-compat): add bundle size fixture (microsoft#29717)
  applying package updates
  Move CredScanSuppression file to root so 1ESPT output task picks it up (microsoft#29722)
  fix(CI): increase pipeline agent timeout threshold to 90 minutes (microsoft#29710)
  fix(breadcrumb): examples and styles (microsoft#29679)
  chore(react-tree): stop unnecessary re-rendering when no actions are available (microsoft#29694)
  applying package updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell approved these changes

@khmakoto khmakoto khmakoto approved these changes

Assignees

@TristanWatanabe TristanWatanabe

Labels
Area: Build System CI
Projects
None yet
Milestone
November Project Cycle Q1 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@TristanWatanabe @fabricteam @Hotell @khmakoto