Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axe-core integration into react-charting #3 #30157

Conversation

Shubhabrata08
Copy link
Contributor

@Shubhabrata08 Shubhabrata08 commented Dec 22, 2023

Previous Behavior

axe-core was added to certain charts in react charting through the following PRs-

  1. Accessibility tests added to AreaChart, LineChart, VerticalBarChart #30059
  2. Axe-core Integration into react-charting #2 #30139

New Behavior

axe-core has been integrated with the remaining of react-charting library.
This PR includes:

  1. GaugeChart
  2. HeatMapChart
  3. PieChart
  4. SankeyChart
  5. SparklineChart
  6. TreeChart

Related Issue(s)

Copy link

codesandbox-ci bot commented Dec 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 78858e3:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@Shubhabrata08 Shubhabrata08 marked this pull request as ready for review December 23, 2023 04:57
@Shubhabrata08 Shubhabrata08 requested a review from a team as a code owner December 23, 2023 04:57
@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 23, 2023

📊 Bundle size report

🤖 This report was generated against 5cb51c1747c839ac8c50eb2c3b527200607e5253

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 23, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Copy link

size-auditor bot commented Dec 23, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5cb51c1747c839ac8c50eb2c3b527200607e5253 (build)

@AtishayMsft
Copy link
Contributor

@Shubhabrata08 Could you pull latest changes for this PR.

@Shubhabrata08
Copy link
Contributor Author

Sure, @AtishayMsft

@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@AtishayMsft AtishayMsft merged commit 8ab18b0 into microsoft:master Dec 27, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with axe-core in charting controls to automate accessibility testing
3 participants