-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web-components): remove final dependencies on fast-foundation #31009
fix(web-components): remove final dependencies on fast-foundation #31009
Conversation
📊 Bundle size reportUnchanged fixtures
|
"type": "prerelease", | ||
"comment": "fix(web-components): remove final dependencies on fast-foundation", | ||
"packageName": "@fluentui/web-components", | ||
"email": "=", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it matters - I'll look and see why it's "not" setting.
615fb50
to
c33493b
Compare
@@ -2,12 +2,9 @@ import * as React from 'react'; | |||
import { StoryContext } from '@storybook/addons'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Text 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Text.Block.normal.chromium.png | 995 | Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't update with the last one - the background is expected
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving v-build related changes
…1009) Co-authored-by: Christopher Holt <=>
…crosoft#31009) Co-authored-by: Christopher Holt <=>
…crosoft#31009) Co-authored-by: Christopher Holt <=>
…crosoft#31009) Co-authored-by: Christopher Holt <=>
…1009) Co-authored-by: Christopher Holt <=>
…1009) Co-authored-by: Christopher Holt <=>
…1009) Co-authored-by: Christopher Holt <=>
…1009) Co-authored-by: Christopher Holt <=>
…1009) Co-authored-by: Christopher Holt <=>
…1009) Co-authored-by: Christopher Holt <=>
…1009) Co-authored-by: Christopher Holt <=>
…1009) Co-authored-by: Christopher Holt <=>
…1009) Co-authored-by: Christopher Holt <=>
This is the final PR to fully remove the dependency on the fast-foundation project. There are two utilities being moved here (along with some cleanup found while changing/removing imports): the
display
helper and thematch-media-stylesheet
behavior and corresponding code.