(web-components) Resolve output warnings for storybook and api-extractor #31467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report✅ No changes found |
janechu
approved these changes
May 23, 2024
change/@fluentui-web-components-777f3360-25b3-4060-9042-001475420001.json
Outdated
Show resolved
Hide resolved
chrisdholt
approved these changes
May 23, 2024
fabricteam
reviewed
May 23, 2024
change/@fluentui-web-components-777f3360-25b3-4060-9042-001475420001.json
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
davatron5000
approved these changes
May 23, 2024
radium-v
force-pushed
the
users/radium-v/fix-warnings
branch
from
6359e58 to
3061f7a
Compare
radium-v
force-pushed
the
users/radium-v/fix-warnings
branch
from
3061f7a to
5bc2a4f
Compare
Hotell
reviewed
May 31, 2024
change/@fluentui-web-components-777f3360-25b3-4060-9042-001475420001.json
Outdated
Show resolved
Hide resolved
Contributor
I'd suggest to set those to |
Hotell
approved these changes
May 31, 2024
radium-v
force-pushed
the
users/radium-v/fix-warnings
branch
from
5bc2a4f to
8864258
Compare
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
api-extractorstep outputs a long list of warnings due to problems with documentation blocks in the component modules.Additionally, Storybook outputs a long list of warnings for all exported types as values (
import/exportvsimport type/export type).New Behavior
This PR resolves the warnings and modifies the
api-extractorandtsdocconfigurations to reduce the number of warnings. Any warnings generated during thecompile/buildsteps should be more relevant and actionable going forward.Related Issue(s)