chore: migrate to TS 4.9 #31496

Hotell · 2024-05-28T15:44:16Z

Previous Behavior

New Behavior

api-extractor:

bumps to last api-extractor version that support TS 4.8 -> we are setting yarn resolutions to override this to use monorepo TS (4.9.5)
api-extractor-model and ts-doc bumps to match api-extractor version for deduplication

web-components

html-react-parser used within vr tests ships invalid types for nodeResolution: node16 setup. Simplest solution was to provide local type override for parse api usage
- more context Resolution error when using TypeScript with moduleResolution set to node16 or nodenext remarkablemark/html-react-parser#1305 (comment)

react-northstar

as v9 package (we use strict type checking in all v9) relies on v0 ( react-migration-v0-v9 ), type errors were exposed when generating api.md:
- unconstrained generics issues https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-8.html#unconstrained-generics-no-longer-assignable-to-
- also @popperjs/core has not ts 4.9 compliant types and only 3 recent versions mitigate this issue - that's why I needed to bump it ( which increases v0 bundle size )
- there is a 1% bundle size increase in some packages - seems related to poppejs which size increased by 3kB ( from 17.6 kB -> 20.9 kB )

Perf bench

yarn lage type-check

Before (4.7)	After (4.9)
12m 11s	11m 7s / 𝚫 9% 🚅 faster

Related Issue(s)

Resolution error when using TypeScript with moduleResolution set to node16 or nodenext remarkablemark/html-react-parser#1305

Fixes #

fabricteam · 2024-05-28T15:49:50Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-northstar` Chat	`152.378 kB` `45.964 kB`	`154.09 kB` `46.847 kB`	`1.712 kB` `883 B`
`react-northstar` Datepicker	`184.939 kB` `56.194 kB`	`186.651 kB` `56.973 kB`	`1.712 kB` `779 B`
`react-northstar` Dropdown	`196.499 kB` `59.455 kB`	`198.211 kB` `60.214 kB`	`1.712 kB` `759 B`
`react-northstar` Menu	`126.89 kB` `39.872 kB`	`128.602 kB` `40.717 kB`	`1.712 kB` `845 B`
`react-northstar` MenuButton	`161.296 kB` `48.883 kB`	`163.008 kB` `49.606 kB`	`1.712 kB` `723 B`
`react-northstar` Popup	`133.604 kB` `41.483 kB`	`135.316 kB` `42.242 kB`	`1.712 kB` `759 B`
`react-northstar` SplitButton	`176.534 kB` `52.63 kB`	`178.246 kB` `53.42 kB`	`1.712 kB` `790 B`
`react-northstar` Toolbar	`173.345 kB` `52.08 kB`	`175.057 kB` `52.832 kB`	`1.712 kB` `752 B`
`react-northstar` Tooltip	`108.261 kB` `34.482 kB`	`109.973 kB` `35.227 kB`	`1.712 kB` `745 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`keyboard-key` keyboard-key package	`3.746 kB` `1.928 kB`
`priority-overflow` createOverflowManager	`4.457 kB` `1.856 kB`
`react` ActivityItem	`71.019 kB` `23.288 kB`
`react` Announced	`38.291 kB` `13.239 kB`
`react` Autofill	`15.365 kB` `4.743 kB`
`react` Breadcrumb	`201.877 kB` `60.317 kB`
`react` Button	`195.341 kB` `56.521 kB`
`react` ButtonGrid	`180.288 kB` `54.565 kB`
`react` Calendar	`121.542 kB` `36.943 kB`
`react` Callout	`84.108 kB` `27.552 kB`
`react` Check	`52.963 kB` `17.773 kB`
`react` Checkbox	`59.751 kB` `19.806 kB`
`react` ChoiceGroup	`65.276 kB` `21.438 kB`
`react` ChoiceGroupOption	`58.531 kB` `19.309 kB`
`react` Coachmark	`92.937 kB` `29.356 kB`
`react` Color	`7.737 kB` `3.106 kB`
`react` ColorPicker	`132.985 kB` `41.502 kB`
`react` ComboBox	`251.642 kB` `72.135 kB`
`react` CommandBar	`202.91 kB` `60.025 kB`
`react` ContextualMenu	`154.87 kB` `48.119 kB`
`react` DatePicker	`183.939 kB` `56.079 kB`
`react` DateTimeUtilities	`5.244 kB` `1.849 kB`
`react` DetailsList	`229.317 kB` `65.63 kB`
`react` Dialog	`211.201 kB` `63.036 kB`
`react` Divider	`19.399 kB` `6.798 kB`
`react` DocumentCard	`216.886 kB` `64.32 kB`
`react` DragDrop	`8.343 kB` `2.724 kB`
`react` DraggableZone	`34.109 kB` `11.448 kB`
`react` Dropdown	`233.807 kB` `68.507 kB`
`react` ExtendedPicker	`96.565 kB` `27.809 kB`
`react` Fabric	`41.537 kB` `14.283 kB`
`react` Facepile	`210.458 kB` `63.087 kB`
`react` FloatingPicker	`241.932 kB` `68.878 kB`
`react` FocusTrapZone	`16.975 kB` `5.917 kB`
`react` FocusZone	`54.844 kB` `17.402 kB`
`react` Grid	`180.288 kB` `54.565 kB`
`react` GroupedList	`134.634 kB` `40.596 kB`
`react` GroupedListV2	`122.251 kB` `37.703 kB`
`react` HoverCard	`96.969 kB` `30.741 kB`
`react` Icon	`51.644 kB` `17.197 kB`
`react` Icons	`66.305 kB` `24.379 kB`
`react` Image	`46.701 kB` `15.646 kB`
`react` Keytip	`81.482 kB` `26.712 kB`
`react` KeytipData	`13.969 kB` `4.57 kB`
`react` KeytipLayer	`103.278 kB` `31.961 kB`
`react` Keytips	`106.046 kB` `32.966 kB`
`react` Label	`38.134 kB` `13.207 kB`
`react` Layer	`47.887 kB` `16.295 kB`
`react` Link	`39.488 kB` `13.614 kB`
`react` List	`39.176 kB` `12.384 kB`
`react` MarqueeSelection	`74.321 kB` `22.385 kB`
`react` MessageBar	`190.392 kB` `56.991 kB`
`react` Modal	`93.44 kB` `30.18 kB`
`react` Nav	`187.87 kB` `56.43 kB`
`react` OverflowSet	`33.191 kB` `11.252 kB`
`react` Overlay	`40.694 kB` `14.023 kB`
`react` Panel	`200.912 kB` `59.92 kB`
`react` Persona	`114.617 kB` `36.442 kB`
`react` PersonaCoin	`114.617 kB` `36.442 kB`
`react` PersonaPresence	`57.833 kB` `19.303 kB`
`react` Pickers	`293.618 kB` `82.223 kB`
`react` Pivot	`188.784 kB` `57.162 kB`
`react` Popup	`12.242 kB` `4.181 kB`
`react` Positioning	`22.608 kB` `7.63 kB`
`react` PositioningContainer	`73.643 kB` `23.706 kB`
`react` ProgressIndicator	`39.286 kB` `13.482 kB`
`react` Rating	`81.762 kB` `26.057 kB`
`react` Fluent UI React (entire library)	`1.013 MB` `281.343 kB`
`react` ResizeGroup	`13.286 kB` `4.365 kB`
`react` ResponsiveMode	`8.078 kB` `2.95 kB`
`react` ScrollablePane	`55.325 kB` `17.669 kB`
`react` SearchBox	`188.667 kB` `56.595 kB`
`react` SelectableOption	`724 B` `413 B`
`react` SelectedItemsList	`232.427 kB` `67.829 kB`
`react` Selection	`42.252 kB` `12.203 kB`
`react` Separator	`35.183 kB` `12.088 kB`
`react` Shimmer	`49.049 kB` `16.206 kB`
`react` ShimmeredDetailsList	`240.092 kB` `68.397 kB`
`react` Slider	`57.449 kB` `19.143 kB`
`react` SpinButton	`192.395 kB` `57.716 kB`
`react` Spinner	`41.481 kB` `14.412 kB`
`react` Stack	`41.547 kB` `14.233 kB`
`react` Sticky	`32.541 kB` `10.49 kB`
`react` Styling	`45.853 kB` `15.082 kB`
`react` SwatchColorPicker	`190.614 kB` `58.051 kB`
`react` TeachingBubble	`205.667 kB` `60.945 kB`
`react` Text	`36.723 kB` `12.763 kB`
`react` TextField	`80.555 kB` `25.262 kB`
`react` Theme	`43.321 kB` `14.129 kB`
`react` ThemeGenerator	`12.34 kB` `4.106 kB`
`react` TimePicker	`241.446 kB` `69.904 kB`
`react` Toggle	`46.02 kB` `15.903 kB`
`react` Tooltip	`87.136 kB` `28.164 kB`
`react` Utilities	`82.495 kB` `25.047 kB`
`react` Viewport	`23.703 kB` `7.589 kB`
`react` WeeklyDayPicker	`101.682 kB` `31.738 kB`
`react` WindowProvider	`1.059 kB` `541 B`
`react-accordion` Accordion (including children components)	`100.003 kB` `30.524 kB`
`react-alert` Alert	`78.817 kB` `22.543 kB`
`react-avatar` Avatar	`49.299 kB` `15.837 kB`
`react-avatar` AvatarGroup	`20.107 kB` `7.973 kB`
`react-avatar` AvatarGroupItem	`63.316 kB` `20.017 kB`
`react-badge` Badge	`25.95 kB` `8.612 kB`
`react-badge` CounterBadge	`26.729 kB` `8.886 kB`
`react-badge` PresenceBadge	`25.717 kB` `9.483 kB`
`react-breadcrumb` @fluentui/react-breadcrumb - package	`114.486 kB` `31.821 kB`
`react-button` Button	`37.103 kB` `10.784 kB`
`react-button` CompoundButton	`43.514 kB` `12.074 kB`
`react-button` MenuButton	`41.884 kB` `12.132 kB`
`react-button` SplitButton	`49.896 kB` `13.724 kB`
`react-button` ToggleButton	`53.03 kB` `12.543 kB`
`react-calendar-compat` Calendar Compat	`150.361 kB` `40.087 kB`
`react-card` Card - All	`101.184 kB` `29.049 kB`
`react-card` Card	`94.218 kB` `27.333 kB`
`react-card` CardFooter	`14.354 kB` `5.795 kB`
`react-card` CardHeader	`16.618 kB` `6.555 kB`
`react-card` CardPreview	`14.418 kB` `5.931 kB`
`react-checkbox` Checkbox	`35.103 kB` `12.11 kB`
`react-combobox` Combobox (including child components)	`100.496 kB` `33.156 kB`
`react-combobox` Dropdown (including child components)	`101.129 kB` `33.096 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`69.141 kB` `20.157 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`212.631 kB` `61.228 kB`
`react-components` react-components: FluentProvider & webLightTheme	`44.442 kB` `14.607 kB`
`react-components` react-components: entire library	`1.092 MB` `269.885 kB`
`react-datepicker-compat` DatePicker Compat	`223.932 kB` `63.41 kB`
`react-dialog` Dialog (including children components)	`99.303 kB` `29.994 kB`
`react-divider` Divider	`21.326 kB` `7.963 kB`
`react-field` Field	`23.382 kB` `8.901 kB`
`react-image` Image	`15.36 kB` `6.245 kB`
`react-input` Input	`27.985 kB` `9.444 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.781 kB` `1.646 kB`
`react-jsx-runtime` JSX Runtime	`4.377 kB` `1.881 kB`
`react-label` Label	`14.67 kB` `6 kB`
`react-link` Link	`17.191 kB` `6.991 kB`
`react-menu` Menu (including children components)	`152.023 kB` `45.98 kB`
`react-menu` Menu (including selectable components)	`154.709 kB` `46.477 kB`
`react-message-bar` MessageBar (all components)	`24.411 kB` `9.114 kB`
`react-northstar` Accordion	`85.392 kB` `26.518 kB`
`react-northstar` Alert	`87.45 kB` `26.902 kB`
`react-northstar` Animation	`55.34 kB` `17.829 kB`
`react-northstar` Attachment	`86.844 kB` `26.692 kB`
`react-northstar` Avatar	`80.279 kB` `24.629 kB`
`react-northstar` Box	`75.248 kB` `23.806 kB`
`react-northstar` Breadcrumb	`79.92 kB` `24.709 kB`
`react-northstar` Button	`83.16 kB` `25.947 kB`
`react-northstar` Card	`82.705 kB` `25.023 kB`
`react-northstar` Carousel	`105.182 kB` `31.871 kB`
`react-northstar` Checkbox	`79.807 kB` `25.078 kB`
`react-northstar` Debug	`8.801 kB` `3.594 kB`
`react-northstar` Design	`36.589 kB` `12.067 kB`
`react-northstar` Dialog	`112.058 kB` `33.615 kB`
`react-northstar` Divider	`76.619 kB` `24.129 kB`
`react-northstar` Embed	`81.477 kB` `25.417 kB`
`react-northstar` Flex	`47.728 kB` `15.438 kB`
`react-northstar` Form	`92.527 kB` `28.879 kB`
`react-northstar` Grid	`70.584 kB` `22.278 kB`
`react-northstar` Header	`74.756 kB` `23.461 kB`
`react-northstar` Image	`73.591 kB` `23.329 kB`
`react-northstar` Input	`88.346 kB` `27.78 kB`
`react-northstar` ItemLayout	`78.231 kB` `24.454 kB`
`react-northstar` Label	`77.92 kB` `24.41 kB`
`react-northstar` Layout	`75.393 kB` `23.798 kB`
`react-northstar` List	`88.493 kB` `27.547 kB`
`react-northstar` Loader	`78.616 kB` `24.729 kB`
`react-northstar` Pill	`83.722 kB` `26.069 kB`
`react-northstar` Portal	`58.338 kB` `18.852 kB`
`react-northstar` Provider	`93.138 kB` `29.63 kB`
`react-northstar` RadioGroup	`83.282 kB` `26.053 kB`
`react-northstar` Reaction	`77.28 kB` `24.122 kB`
`react-northstar` Segment	`76.209 kB` `23.892 kB`
`react-northstar` Skeleton	`77.765 kB` `24.2 kB`
`react-northstar` Slider	`84.27 kB` `26.737 kB`
`react-northstar` Status	`76.272 kB` `24.05 kB`
`react-northstar` SvgIcon	`36.823 kB` `11.743 kB`
`react-northstar` Table	`80.796 kB` `25.154 kB`
`react-northstar` Text	`74.114 kB` `23.507 kB`
`react-northstar` TextArea	`74.248 kB` `23.492 kB`
`react-northstar` Tree	`87.855 kB` `27.217 kB`
`react-northstar` Video	`75.411 kB` `23.799 kB`
`react-overflow` hooks only	`12.87 kB` `4.83 kB`
`react-persona` Persona	`56.19 kB` `17.726 kB`
`react-popover` Popover	`127.766 kB` `40.096 kB`
`react-portal` Portal	`14.563 kB` `5.118 kB`
`react-portal-compat` PortalCompatProvider	`8.39 kB` `2.64 kB`
`react-positioning` usePositioning	`26.489 kB` `9.552 kB`
`react-progress` ProgressBar	`17.084 kB` `6.904 kB`
`react-provider` FluentProvider	`24.616 kB` `8.903 kB`
`react-radio` Radio	`32.671 kB` `10.348 kB`
`react-radio` RadioGroup	`15.758 kB` `6.431 kB`
`react-select` Select	`27.636 kB` `10.106 kB`
`react-slider` Slider	`37.195 kB` `12.559 kB`
`react-spinbutton` SpinButton	`36.047 kB` `11.833 kB`
`react-spinner` Spinner	`25.244 kB` `8.552 kB`
`react-swatch-picker` @fluentui/react-swatch-picker - package	`104.378 kB` `30.355 kB`
`react-switch` Switch	`35.299 kB` `11.345 kB`
`react-table` DataGrid	`162.843 kB` `46.317 kB`
`react-table` Table (Primitives only)	`42.48 kB` `13.866 kB`
`react-table` Table as DataGrid	`131.934 kB` `36.682 kB`
`react-table` Table (Selection only)	`70.334 kB` `20.026 kB`
`react-table` Table (Sort only)	`68.977 kB` `19.63 kB`
`react-tag-picker` @fluentui/react-tag-picker - package	`181.063 kB` `54.547 kB`
`react-tags` InteractionTag	`15.165 kB` `6.134 kB`
`react-tags` Tag	`28.994 kB` `9.518 kB`
`react-tags` TagGroup	`82.911 kB` `24.642 kB`
`react-text` Text - Default	`17.061 kB` `6.731 kB`
`react-text` Text - Wrappers	`20.233 kB` `7.061 kB`
`react-textarea` Textarea	`26.519 kB` `9.739 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`35.666 kB` `7.453 kB`
`react-theme` Teams: Light theme	`19.642 kB` `5.549 kB`
`react-timepicker-compat` TimePicker	`103.487 kB` `34.632 kB`
`react-toast` Toast (including Toaster)	`99.625 kB` `30.033 kB`
`react-tooltip` Tooltip	`54.556 kB` `19.226 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against de236343a2ea7e2e53fbb8f66a294890ea3d1bbb}

fabricteam · 2024-05-28T15:54:45Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	mount	89	85	10	Possible regression
FluentProviderWithTheme	virtual-rerender	37	32	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	645	669	5000
Button	mount	309	289	5000
Field	mount	1152	1154	5000
FluentProvider	mount	704	710	5000
FluentProviderWithTheme	mount	89	85	10	Possible regression
FluentProviderWithTheme	virtual-rerender	37	32	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	75	70	10
MakeStyles	mount	847	878	50000
Persona	mount	1779	1729	5000
SpinButton	mount	1411	1434	5000
SwatchPicker	mount	1569	1565	5000

codesandbox-ci · 2024-05-28T15:55:23Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

change/@fluentui-api-docs-44f3b6cf-e2ae-452b-bf50-ef1af35445bb.json

fabricteam · 2024-05-28T16:01:47Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	95	83	1.14:1
PortalMinimalPerf.default	88	79	1.11:1
AccordionMinimalPerf.default	89	81	1.1:1
AlertMinimalPerf.default	165	150	1.1:1
LayoutMinimalPerf.default	205	186	1.1:1
ChatWithPopoverPerf.default	213	196	1.09:1
TextMinimalPerf.default	203	188	1.08:1
ProviderMinimalPerf.default	211	198	1.07:1
ButtonSlotsPerf.default	322	305	1.06:1
DialogMinimalPerf.default	450	429	1.05:1
StatusMinimalPerf.default	401	381	1.05:1
CarouselMinimalPerf.default	277	266	1.04:1
CheckboxMinimalPerf.default	1144	1099	1.04:1
DropdownManyItemsPerf.default	409	393	1.04:1
DropdownMinimalPerf.default	1436	1382	1.04:1
FlexMinimalPerf.default	163	157	1.04:1
FormMinimalPerf.default	225	217	1.04:1
MenuButtonMinimalPerf.default	975	937	1.04:1
TextAreaMinimalPerf.default	301	290	1.04:1
TreeMinimalPerf.default	491	472	1.04:1
VideoMinimalPerf.default	422	406	1.04:1
AnimationMinimalPerf.default	306	296	1.03:1
AttachmentMinimalPerf.default	81	79	1.03:1
AvatarMinimalPerf.default	106	103	1.03:1
GridMinimalPerf.default	195	190	1.03:1
HeaderMinimalPerf.default	214	207	1.03:1
InputMinimalPerf.default	543	526	1.03:1
ItemLayoutMinimalPerf.default	716	698	1.03:1
TooltipMinimalPerf.default	1284	1242	1.03:1
ButtonOverridesMissPerf.default	666	654	1.02:1
ImageMinimalPerf.default	235	231	1.02:1
ListMinimalPerf.default	310	303	1.02:1
LoaderMinimalPerf.default	193	189	1.02:1
SkeletonMinimalPerf.default	206	201	1.02:1
ChatDuplicateMessagesPerf.default	144	143	1.01:1
ReactionMinimalPerf.default	214	212	1.01:1
SliderMinimalPerf.default	747	738	1.01:1
TableManyItemsPerf.default	1098	1090	1.01:1
TableMinimalPerf.default	236	233	1.01:1
DatepickerMinimalPerf.default	3684	3683	1:1
ListCommonPerf.default	416	418	1:1
ListNestedPerf.default	324	324	1:1
RosterPerf.default	1584	1583	1:1
ProviderMergeThemesPerf.default	646	644	1:1
CustomToolbarPrototype.default	1480	1476	1:1
ToolbarMinimalPerf.default	535	533	1:1
AttachmentSlotsPerf.default	639	644	0.99:1
EmbedMinimalPerf.default	1855	1875	0.99:1
LabelMinimalPerf.default	217	220	0.99:1
ListWith60ListItems.default	363	368	0.99:1
RadioGroupMinimalPerf.default	267	270	0.99:1
RefMinimalPerf.default	106	107	0.99:1
SplitButtonMinimalPerf.default	2275	2288	0.99:1
ButtonMinimalPerf.default	87	89	0.98:1
MenuMinimalPerf.default	506	515	0.98:1
PopupMinimalPerf.default	344	351	0.98:1
ChatMinimalPerf.default	439	452	0.97:1
CardMinimalPerf.default	300	313	0.96:1
HeaderSlotsPerf.default	458	476	0.96:1
IconMinimalPerf.default	374	389	0.96:1
DividerMinimalPerf.default	192	202	0.95:1
BoxMinimalPerf.default	186	198	0.94:1
SegmentMinimalPerf.default	186	201	0.93:1

change/@fluentui-api-docs-44f3b6cf-e2ae-452b-bf50-ef1af35445bb.json

fabricteam · 2024-05-28T16:12:19Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	613	621	5000
Breadcrumb	mount	1695	1668	1000
Checkbox	mount	1726	1721	5000
CheckboxBase	mount	1508	1501	5000
ChoiceGroup	mount	2989	3038	5000
ComboBox	mount	673	658	1000
CommandBar	mount	6463	6477	1000
ContextualMenu	mount	12754	12483	1000
DefaultButton	mount	800	817	5000
DetailsRow	mount	2213	2246	5000
DetailsRowFast	mount	2236	2206	5000
DetailsRowNoStyles	mount	2012	2031	5000
Dialog	mount	2719	2809	1000
DocumentCardTitle	mount	230	240	1000
Dropdown	mount	2012	1978	5000
FocusTrapZone	mount	1159	1132	5000
FocusZone	mount	1079	1103	5000
GroupedList	mount	42337	42071	2
GroupedList	virtual-rerender	17985	20189	2
GroupedList	virtual-rerender-with-unmount	51341	50887	2
GroupedListV2	mount	217	229	2
GroupedListV2	virtual-rerender	211	224	2
GroupedListV2	virtual-rerender-with-unmount	225	231	2
IconButton	mount	1141	1148	5000
Label	mount	350	339	5000
Layer	mount	2742	2735	5000
Link	mount	396	394	5000
MenuButton	mount	985	981	5000
MessageBar	mount	21340	21409	5000
Nav	mount	2036	2049	1000
OverflowSet	mount	804	782	5000
Panel	mount	1831	1789	1000
Persona	mount	724	753	1000
Pivot	mount	911	896	1000
PrimaryButton	mount	933	926	5000
Rating	mount	4694	4684	5000
SearchBox	mount	920	915	5000
Shimmer	mount	1920	1930	5000
Slider	mount	1343	1358	5000
SpinButton	mount	2945	3037	5000
Spinner	mount	390	389	5000
SplitButton	mount	1838	1876	5000
Stack	mount	415	418	5000
StackWithIntrinsicChildren	mount	875	874	5000
StackWithTextChildren	mount	2662	2684	5000
SwatchColorPicker	mount	6369	6326	5000
TagPicker	mount	1478	1479	5000
Text	mount	378	390	5000
TextField	mount	956	940	5000
ThemeProvider	mount	838	843	5000
ThemeProvider	virtual-rerender	579	584	5000
ThemeProvider	virtual-rerender-with-unmount	1302	1301	5000
Toggle	mount	607	610	5000
buttonNative	mount	181	191	5000

change/@fluentui-api-docs-44f3b6cf-e2ae-452b-bf50-ef1af35445bb.json

packages/react-conformance/src/utils/getCallbackArguments.test.ts

apps/vr-tests-web-components/tsconfig.json

Hotell · 2024-05-30T11:52:00Z

Note

popper bump - discussed offline with @layershifter

I can do one of 2 follow ups regarding popper in order to bump the version back to current

copy paste popper types and set our local override within every v0 package

difficulty: hard
maintenence: pure pain
api reliablitiy: same

turn off skipLib check for api generation within v0-v9-migration package

difficulty: medium
maintenance: okay
api reliability: degradation

As a follow-up we'll go with option 2. which will require generate-api task target overhaul

JustSlone · 2024-05-30T17:54:37Z

Note

popper bump - discussed offline with @layershifter

I can do one of 2 follow ups regarding popper in order to bump the version back to current

copy paste popper types and set our local override within every v0 package

difficulty: hard

maintenence: pure pain

api reliablitiy: same

turn off skipLib check for api generation within v0-v9-migration package

difficulty: medium

maintenance: okay

api reliability: degradation

As a follow-up we'll go with option 2. which will require generate-api task target overhaul

on this approach, will we be able to unwind this when we fully drop support for v0?

Hotell · 2024-05-31T08:58:13Z

on this approach, will we be able to unwind this when we fully drop support for v0?

No 🥲

context: v0 will contain those popperjs types, so skipLibCheck: false will go through them thus exploding on generate-api task.

From teams POV i think it's safe enough to not have this restrictive check within the migration-v0-v9 package. The recommendation is for any consumer of v9 to have set skipLibCheck: true within their tsconfig

they should not care about all the bag of types shipped from library surface low level
not having that drastically slows down tsc ( imagine it as having to parse all node modules within your bundle step .... 🐌)

… tests

…des to be compliant with ts 4.9

…cs check

…ant with ts 4.9 unconstrained generics check

…rjs/core

Hotell added the Area: Typescript label May 28, 2024

github-actions bot added this to the April Project Cycle Q1 2024 milestone May 28, 2024

Hotell added the Area: Build System label May 28, 2024

fabricteam reviewed May 28, 2024

View reviewed changes

change/@fluentui-api-docs-44f3b6cf-e2ae-452b-bf50-ef1af35445bb.json Show resolved Hide resolved

fabricteam reviewed May 28, 2024

View reviewed changes

change/@fluentui-api-docs-44f3b6cf-e2ae-452b-bf50-ef1af35445bb.json Show resolved Hide resolved

fabricteam reviewed May 28, 2024

View reviewed changes

change/@fluentui-api-docs-44f3b6cf-e2ae-452b-bf50-ef1af35445bb.json Show resolved Hide resolved

Hotell commented May 28, 2024

View reviewed changes

packages/react-conformance/src/utils/getCallbackArguments.test.ts Show resolved Hide resolved

fabricteam reviewed May 29, 2024

View reviewed changes

apps/vr-tests-web-components/tsconfig.json Show resolved Hide resolved

Hotell marked this pull request as ready for review May 29, 2024 14:16

Hotell requested review from a team as code owners May 29, 2024 14:16

Hotell force-pushed the deps/migrate-to-ts-4-9 branch from fec3757 to 74cf3b1 Compare May 29, 2024 15:36

layershifter approved these changes May 30, 2024

View reviewed changes

Hotell requested a review from marcosmoura May 30, 2024 12:09

chrisdholt approved these changes May 30, 2024

View reviewed changes

JustSlone approved these changes May 30, 2024

View reviewed changes

radium-v approved these changes May 30, 2024

View reviewed changes

marcosmoura approved these changes May 31, 2024

View reviewed changes

Hotell added 2 commits June 4, 2024 12:35

chore: migrate to TS 4.9

16ac952

change file

ea4d957

Hotell added 6 commits June 4, 2024 12:35

test(react-conformance): resolve compiler host creation issues within…

ea5a6aa

… tests

chore(vr-tests-web-components): provide html-react-parser type overri…

2ccb84a

…des to be compliant with ts 4.9

chore: resolve typescript to 4.9 within api-extractor

5d57717

fix(northstar): make types compliant with ts 4.9 unconstrained generi…

a4d9583

…cs check

fix(northstar): bump popperjs to latest in order to make types compli…

b02dbb8

…ant with ts 4.9 unconstrained generics check

fix(northstar): mitigate bundle-size increase caused by latest @poppe…

3a009fa

…rjs/core

Hotell force-pushed the deps/migrate-to-ts-4-9 branch from 74cf3b1 to 3a009fa Compare June 4, 2024 10:35

Hotell enabled auto-merge (squash) June 4, 2024 10:35

Hotell merged commit 7d6815a into microsoft:master Jun 4, 2024
22 checks passed

Hotell deleted the deps/migrate-to-ts-4-9 branch June 4, 2024 14:08

miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024

chore: migrate to TS 4.9 (microsoft#31496)

dc86826

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate to TS 4.9 #31496

chore: migrate to TS 4.9 #31496

Hotell commented May 28, 2024 •

edited

Loading

fabricteam commented May 28, 2024 •

edited

Loading

fabricteam commented May 28, 2024 •

edited

Loading

codesandbox-ci bot commented May 28, 2024 •

edited

Loading

fabricteam commented May 28, 2024 •

edited

Loading

fabricteam commented May 28, 2024 •

edited

Loading

Hotell commented May 30, 2024

JustSlone commented May 30, 2024 •

edited

Loading

Hotell commented May 31, 2024

chore: migrate to TS 4.9 #31496

chore: migrate to TS 4.9 #31496

Conversation

Hotell commented May 28, 2024 • edited Loading

Previous Behavior

New Behavior

Perf bench

Related Issue(s)

fabricteam commented May 28, 2024 • edited Loading

📊 Bundle size report

fabricteam commented May 28, 2024 • edited Loading

Perf Analysis (@fluentui/react-components)

codesandbox-ci bot commented May 28, 2024 • edited Loading

fabricteam commented May 28, 2024 • edited Loading

Perf Analysis (@fluentui/react-northstar)

fabricteam commented May 28, 2024 • edited Loading

Perf Analysis (@fluentui/react)

Hotell commented May 30, 2024

JustSlone commented May 30, 2024 • edited Loading

Hotell commented May 31, 2024

Hotell commented May 28, 2024 •

edited

Loading

fabricteam commented May 28, 2024 •

edited

Loading

fabricteam commented May 28, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

codesandbox-ci bot commented May 28, 2024 •

edited

Loading

fabricteam commented May 28, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented May 28, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react`)

JustSlone commented May 30, 2024 •

edited

Loading