fix(react-accordion): deprecate navigation prop #31587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 80 | 87 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 39 | 38 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 636 | 640 | 5000 | |
| Button | mount | 314 | 310 | 5000 | |
| Field | mount | 1098 | 1088 | 5000 | |
| FluentProvider | mount | 697 | 717 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 87 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 39 | 38 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 74 | 10 | |
| MakeStyles | mount | 876 | 860 | 50000 | |
| Persona | mount | 1764 | 1700 | 5000 | |
| SpinButton | mount | 1369 | 1439 | 5000 | |
| SwatchPicker | mount | 1555 | 1552 | 5000 |
fabricteam
reviewed
Jun 5, 2024
change/@fluentui-react-accordion-c3e0ad16-1578-49d3-90c0-422d2c2931e0.json
Outdated
Show resolved
Hide resolved
mainframev
force-pushed
the
fix/accordion-remove-arrow-nav
branch
from
98db5e2
to
0a28e71
Compare
mainframev
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
mainframev
force-pushed
the
fix/accordion-remove-arrow-nav
branch
from
0a28e71
to
1e86971
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
mainframev
force-pushed
the
fix/accordion-remove-arrow-nav
branch
2 times, most recently
from
c172ada
to
826aefc
Compare
smhigley
reviewed
Jun 6, 2024
There was a problem hiding this comment.
One small comment wording suggestion, & it would probably be good to remove the Navigation example from the storybook (the AccordionNavigation.stories.tsx file)
I think @bsunderhus should be the one to sign off on the overall deprecation approach
packages/react-components/react-accordion/src/components/Accordion/Accordion.types.ts
Outdated
Show resolved
Hide resolved
|
please make sure to update this branch with latest master - accordion was migrated to new structure. that's why there is no codeowner assigned. |
bsunderhus
reviewed
Jun 7, 2024
packages/react-components/react-accordion/src/components/Accordion/useAccordion.ts
Outdated
Show resolved
Hide resolved
bsunderhus
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Thanks for the contrib @mainframev, looks good to me. I'd follow up on @smhigley recommendation and remove the navigation story entirely (https://react.fluentui.dev/?path=/docs/components-accordion--default#navigation)
Open
2 tasks
mainframev
force-pushed
the
fix/accordion-remove-arrow-nav
branch
2 times, most recently
from
918018f
to
3308d6e
Compare
ValentinaKozlova
approved these changes
Jun 7, 2024
bsunderhus
approved these changes
Jun 7, 2024
bsunderhus
force-pushed
the
fix/accordion-remove-arrow-nav
branch
from
3308d6e
to
23b9b72
Compare
mainframev
force-pushed
the
fix/accordion-remove-arrow-nav
branch
from
23b9b72
to
883a05a
Compare
Update packages/react-components/react-accordion/src/components/Accordion/useAccordion.ts Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com> Update packages/react-components/react-accordion/src/components/Accordion/Accordion.types.ts Co-authored-by: Sarah Higley <smhigley@users.noreply.github.com>
mainframev
force-pushed
the
fix/accordion-remove-arrow-nav
branch
from
883a05a
to
9db4444
Compare
smhigley
approved these changes
Jun 10, 2024
|
@mainframev it looks ready to merge! Thanks for making this change 🎉 |
mainframev
added a commit
to mainframev/fluentui
that referenced
this pull request
Jun 11, 2024
Co-authored-by: Sarah Higley <smhigley@users.noreply.github.com>
2 tasks
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
…-and-drawer-compat * master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
* master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Co-authored-by: Sarah Higley <smhigley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #30799 , deprecated navigation prop in order to align react-accordion behaviour in the next version with w3 APG pattern