feat: update Avatar to leverage ElementInternals for role and color states #31693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
force-pushed
the
users/chhol/move-avatar-role-to-element-internals
branch
from
cc8f3b7
to
bbbbc31
Compare
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 13, 2024
change/@fluentui-web-components-a05b784c-1559-4ccd-b8f2-0c5e7818fdfb.json
Show resolved
Hide resolved
marchbox
approved these changes
Jun 13, 2024
chrisdholt
force-pushed
the
users/chhol/move-avatar-role-to-element-internals
branch
5 times, most recently
from
a846fb2
to
a0c6307
Compare
davatron5000
approved these changes
Jun 13, 2024
chrisdholt
force-pushed
the
users/chhol/move-avatar-role-to-element-internals
branch
3 times, most recently
from
da33ea2
to
8b2b2ec
Compare
chrisdholt
force-pushed
the
users/chhol/move-avatar-role-to-element-internals
branch
from
a0ba865
to
cb488e2
Compare
mlijanto
reviewed
Jun 13, 2024
mlijanto
approved these changes
Jun 13, 2024
janechu
reviewed
Jun 13, 2024
chrisdholt
force-pushed
the
users/chhol/move-avatar-role-to-element-internals
branch
from
cb488e2
to
2e3eec9
Compare
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Avatar applies the role and color in the DOM.
New Behavior
Avatar uses ElementInternals for the role and setting a custom state (with attribute fallback) for colors, to avoid sprouting unnecessary attributes.
Related Issue(s)