refactor(web-components): cleanup accordion and update to elementInternals for state #31866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
chrisdholt
reviewed
Jun 28, 2024
eljefe223
approved these changes
Jul 2, 2024
radium-v
reviewed
Jul 2, 2024
mlijanto
approved these changes
Jul 2, 2024
radium-v
approved these changes
Jul 3, 2024
davatron5000
force-pushed
the
davatron5000/refactor-accordion
branch
from
f076f30
to
34621b1
Compare
fabricteam
reviewed
Jul 3, 2024
apps/vr-tests-web-components/src/stories/accordion/accordion.stories.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Current accordion has unneeded and confusing features like
focusgroupand extra slots and grouping divs inside template.New Behavior
AccordionItemtemplateendslot in favor of consumer-supplied CSSAccordionItemCSSRelated Issue(s)