feat(web-components): enabling setting theme on an individual element and unsetting themes #31973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchbox
changed the title
Collaborator
📊 Bundle size report✅ No changes found |
Hotell
reviewed
Aug 16, 2024
change/@fluentui-web-components-d74234e0-b903-4c51-af61-599648aee92d.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
davatron5000
approved these changes
Aug 19, 2024
Contributor
davatron5000
left a comment
davatron5000
left a comment
There was a problem hiding this comment.
Looks good. I have some questions but nothing blocking.
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
setProperty()calls, which isn't ideal for performancesetThemeFor()New Behavior
setTheme()accepts a second argument for the node to set theme on, defaulting todocumentfor setting global themeShadowRoot.adoptedStyleSheetsRelated Issue(s)