Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: override tabindex attribute and default to 0 #32007

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: override tabindex attribute and default to 0 #32007

merged 1 commit into from
Jul 15, 2024

Conversation

chrisdholt
Copy link
Member

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@chrisdholt chrisdholt requested a review from a team as a code owner July 15, 2024 23:00
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 15, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@radium-v
Copy link
Contributor

This causes the tabindex="-1" to persist when disabled is toggled:

  1. Instantiate a <fluent-button>
  2. Add the disabled attribute. Observe that the tabindex attribute is changed to -1.
  3. Remove the disabled attribute. Observe that the tabindex attribute value doesn't update.

@chrisdholt chrisdholt force-pushed the users/chhol/fix-tabindex-fix-doh branch from da657b2 to a510873 Compare July 15, 2024 23:08
@chrisdholt chrisdholt force-pushed the users/chhol/fix-tabindex-fix-doh branch from a510873 to 0513b2e Compare July 15, 2024 23:23
@chrisdholt chrisdholt enabled auto-merge (squash) July 15, 2024 23:28
@chrisdholt chrisdholt merged commit 7a1434a into microsoft:master Jul 15, 2024
16 of 18 checks passed
@chrisdholt chrisdholt deleted the users/chhol/fix-tabindex-fix-doh branch July 15, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@radium-v radium-v radium-v approved these changes

@mlijanto mlijanto mlijanto approved these changes

Assignees
No one assigned
Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisdholt @fabricteam @radium-v @mlijanto @davatron5000