Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule #32072

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule #32072

merged 1 commit into from
Jul 23, 2024

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jul 23, 2024 •
edited
Loading

Previous Behavior

New Behavior

  1. removes dependency on "@fluentui/react-utilities/src/utils/isHTMLElement" file from ban-instanceof-html-element eslint rule

Related Issue(s)

  • Fixes #

@bsunderhus
chore(eslint-plugin): removes type dependency on @fluentui/react-util…
b7f41a4 
…ities internals in ban-instanceof-html-element rule
@bsunderhus bsunderhus self-assigned this Jul 23, 2024
@github-actions github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 23, 2024
@bsunderhus bsunderhus mentioned this pull request Jul 23, 2024
Merged
@fabricteam
Copy link
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 648 624 5000
Button mount 289 302 5000
Field mount 1140 1105 5000
FluentProvider mount 694 719 5000
FluentProviderWithTheme mount 76 86 10
FluentProviderWithTheme virtual-rerender 37 31 10
FluentProviderWithTheme virtual-rerender-with-unmount 80 71 10
MakeStyles mount 861 862 50000
Persona mount 1755 1744 5000
SpinButton mount 1413 1405 5000
SwatchPicker mount 1656 1655 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
ActivityItem		 0 B
0 B		 71.199 kB
23.342 kB		 🆕 New entry
react
Announced		 0 B
0 B		 38.48 kB
13.282 kB		 🆕 New entry
react
Autofill		 0 B
0 B		 15.428 kB
4.768 kB		 🆕 New entry
react
Breadcrumb		 0 B
0 B		 202.16 kB
60.414 kB		 🆕 New entry
react
Button		 0 B
0 B		 195.612 kB
56.635 kB		 🆕 New entry
react
ButtonGrid		 0 B
0 B		 180.546 kB
54.615 kB		 🆕 New entry
react
Calendar		 0 B
0 B		 121.738 kB
36.999 kB		 🆕 New entry
react
Callout		 0 B
0 B		 84.292 kB
27.63 kB		 🆕 New entry
react
Check		 0 B
0 B		 53.16 kB
17.832 kB		 🆕 New entry
react
Checkbox		 0 B
0 B		 59.946 kB
19.879 kB		 🆕 New entry
react
ChoiceGroup		 0 B
0 B		 65.455 kB
21.478 kB		 🆕 New entry
react
ChoiceGroupOption		 0 B
0 B		 58.723 kB
19.355 kB		 🆕 New entry
react
Coachmark		 0 B
0 B		 93.132 kB
29.416 kB		 🆕 New entry
react
Color		 0 B
0 B		 7.789 kB
3.127 kB		 🆕 New entry
react
ColorPicker		 0 B
0 B		 133.22 kB
41.588 kB		 🆕 New entry
react
ComboBox		 0 B
0 B		 252.052 kB
72.328 kB		 🆕 New entry
react
CommandBar		 0 B
0 B		 203.201 kB
60.138 kB		 🆕 New entry
react
ContextualMenu		 0 B
0 B		 155.083 kB
48.18 kB		 🆕 New entry
react
DatePicker		 0 B
0 B		 184.16 kB
56.164 kB		 🆕 New entry
react
DateTimeUtilities		 0 B
0 B		 5.244 kB
1.849 kB		 🆕 New entry
react
DetailsList		 0 B
0 B		 229.78 kB
65.894 kB		 🆕 New entry
react
Dialog		 0 B
0 B		 211.467 kB
63.157 kB		 🆕 New entry
react
Divider		 0 B
0 B		 19.591 kB
6.841 kB		 🆕 New entry
react
DocumentCard		 0 B
0 B		 217.153 kB
64.431 kB		 🆕 New entry
react
DragDrop		 0 B
0 B		 8.343 kB
2.724 kB		 🆕 New entry
react
DraggableZone		 0 B
0 B		 34.305 kB
11.509 kB		 🆕 New entry
react
Dropdown		 0 B
0 B		 234.099 kB
68.671 kB		 🆕 New entry
react
ExtendedPicker		 0 B
0 B		 96.795 kB
27.893 kB		 🆕 New entry
react
Fabric		 0 B
0 B		 41.732 kB
14.349 kB		 🆕 New entry
react
Facepile		 0 B
0 B		 210.755 kB
63.183 kB		 🆕 New entry
react
FloatingPicker		 0 B
0 B		 242.196 kB
69.02 kB		 🆕 New entry
react
FocusTrapZone		 0 B
0 B		 17.03 kB
5.924 kB		 🆕 New entry
react
FocusZone		 0 B
0 B		 55.053 kB
17.47 kB		 🆕 New entry
react
Grid		 0 B
0 B		 180.546 kB
54.615 kB		 🆕 New entry
react
GroupedList		 0 B
0 B		 135.005 kB
40.75 kB		 🆕 New entry
react
GroupedListV2		 0 B
0 B		 122.594 kB
37.849 kB		 🆕 New entry
react
HoverCard		 0 B
0 B		 97.16 kB
30.816 kB		 🆕 New entry
react
Icon		 0 B
0 B		 51.848 kB
17.254 kB		 🆕 New entry
react
Icons		 0 B
0 B		 66.361 kB
24.397 kB		 🆕 New entry
react
Image		 0 B
0 B		 46.887 kB
15.703 kB		 🆕 New entry
react
Keytip		 0 B
0 B		 81.661 kB
26.758 kB		 🆕 New entry
react
KeytipData		 0 B
0 B		 14.028 kB
4.587 kB		 🆕 New entry
react
KeytipLayer		 0 B
0 B		 103.459 kB
32.014 kB		 🆕 New entry
react
Keytips		 0 B
0 B		 106.227 kB
33.014 kB		 🆕 New entry
react
Label		 0 B
0 B		 38.335 kB
13.251 kB		 🆕 New entry
react
Layer		 0 B
0 B		 48.084 kB
16.358 kB		 🆕 New entry
react
Link		 0 B
0 B		 39.668 kB
13.662 kB		 🆕 New entry
react
List		 0 B
0 B		 39.4 kB
12.481 kB		 🆕 New entry
react
MarqueeSelection		 0 B
0 B		 74.528 kB
22.424 kB		 🆕 New entry
react
MessageBar		 0 B
0 B		 190.65 kB
57.064 kB		 🆕 New entry
react
Modal		 0 B
0 B		 93.632 kB
30.242 kB		 🆕 New entry
react
Nav		 0 B
0 B		 188.15 kB
56.514 kB		 🆕 New entry
react
OverflowSet		 0 B
0 B		 33.376 kB
11.317 kB		 🆕 New entry
react
Overlay		 0 B
0 B		 40.889 kB
14.084 kB		 🆕 New entry
react
Panel		 0 B
0 B		 201.208 kB
60.025 kB		 🆕 New entry
react
Persona		 0 B
0 B		 114.805 kB
36.493 kB		 🆕 New entry
react
PersonaCoin		 0 B
0 B		 114.805 kB
36.493 kB		 🆕 New entry
react
PersonaPresence		 0 B
0 B		 58.03 kB
19.368 kB		 🆕 New entry
react
Pickers		 0 B
0 B		 294.031 kB
82.422 kB		 🆕 New entry
react
Pivot		 0 B
0 B		 189.043 kB
57.242 kB		 🆕 New entry
react
Popup		 0 B
0 B		 12.294 kB
4.195 kB		 🆕 New entry
react
Positioning		 0 B
0 B		 22.807 kB
7.701 kB		 🆕 New entry
react
PositioningContainer		 0 B
0 B		 73.838 kB
23.759 kB		 🆕 New entry
react
ProgressIndicator		 0 B
0 B		 39.491 kB
13.54 kB		 🆕 New entry
react
Rating		 0 B
0 B		 81.97 kB
26.1 kB		 🆕 New entry
react
Fluent UI React (entire library)		 0 B
0 B		 1.014 MB
281.908 kB		 🆕 New entry
react
ResizeGroup		 0 B
0 B		 13.338 kB
4.377 kB		 🆕 New entry
react
ResponsiveMode		 0 B
0 B		 8.13 kB
2.966 kB		 🆕 New entry
react
ScrollablePane		 0 B
0 B		 55.53 kB
17.73 kB		 🆕 New entry
react
SearchBox		 0 B
0 B		 188.925 kB
56.674 kB		 🆕 New entry
react
SelectableOption		 0 B
0 B		 724 B
413 B		 🆕 New entry
react
SelectedItemsList		 0 B
0 B		 232.707 kB
67.921 kB		 🆕 New entry
react
Selection		 0 B
0 B		 42.464 kB
12.301 kB		 🆕 New entry
react
Separator		 0 B
0 B		 35.372 kB
12.142 kB		 🆕 New entry
react
Shimmer		 0 B
0 B		 49.238 kB
16.264 kB		 🆕 New entry
react
ShimmeredDetailsList		 0 B
0 B		 240.562 kB
68.628 kB		 🆕 New entry
react
Slider		 0 B
0 B		 57.639 kB
19.206 kB		 🆕 New entry
react
SpinButton		 0 B
0 B		 192.654 kB
57.781 kB		 🆕 New entry
react
Spinner		 0 B
0 B		 41.764 kB
14.469 kB		 🆕 New entry
react
Stack		 0 B
0 B		 41.734 kB
14.268 kB		 🆕 New entry
react
Sticky		 0 B
0 B		 32.613 kB
10.509 kB		 🆕 New entry
react
Styling		 0 B
0 B		 46.033 kB
15.135 kB		 🆕 New entry
react
SwatchColorPicker		 0 B
0 B		 190.871 kB
58.117 kB		 🆕 New entry
react
TeachingBubble		 0 B
0 B		 205.924 kB
61.042 kB		 🆕 New entry
react
Text		 0 B
0 B		 36.908 kB
12.822 kB		 🆕 New entry
react
TextField		 0 B
0 B		 80.767 kB
25.323 kB		 🆕 New entry
react
Theme		 0 B
0 B		 43.501 kB
14.183 kB		 🆕 New entry
react
ThemeGenerator		 0 B
0 B		 12.392 kB
4.126 kB		 🆕 New entry
react
TimePicker		 0 B
0 B		 241.834 kB
70.085 kB		 🆕 New entry
react
Toggle		 0 B
0 B		 46.21 kB
15.966 kB		 🆕 New entry
react
Tooltip		 0 B
0 B		 87.324 kB
28.217 kB		 🆕 New entry
react
Utilities		 0 B
0 B		 82.675 kB
25.119 kB		 🆕 New entry
react
Viewport		 0 B
0 B		 23.888 kB
7.656 kB		 🆕 New entry
react
WeeklyDayPicker		 0 B
0 B		 101.892 kB
31.818 kB		 🆕 New entry
react
WindowProvider		 0 B
0 B		 1.059 kB
541 B		 🆕 New entry
react-components
react-components: Button, FluentProvider & webLightTheme		 0 B
0 B		 69.141 kB
20.157 kB		 🆕 New entry
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 0 B
0 B		 211.781 kB
60.963 kB		 🆕 New entry
react-components
react-components: FluentProvider & webLightTheme		 0 B
0 B		 44.442 kB
14.607 kB		 🆕 New entry
react-components
react-components: entire library		 0 B
0 B		 1.096 MB
271.195 kB		 🆕 New entry
react-northstar
Accordion		 0 B
0 B		 85.392 kB
26.518 kB		 🆕 New entry
react-northstar
Alert		 0 B
0 B		 87.45 kB
26.902 kB		 🆕 New entry
react-northstar
Animation		 0 B
0 B		 55.34 kB
17.829 kB		 🆕 New entry
react-northstar
Attachment		 0 B
0 B		 86.844 kB
26.692 kB		 🆕 New entry
react-northstar
Avatar		 0 B
0 B		 80.279 kB
24.629 kB		 🆕 New entry
react-northstar
Box		 0 B
0 B		 75.248 kB
23.806 kB		 🆕 New entry
react-northstar
Breadcrumb		 0 B
0 B		 79.92 kB
24.709 kB		 🆕 New entry
react-northstar
Button		 0 B
0 B		 83.16 kB
25.947 kB		 🆕 New entry
react-northstar
Card		 0 B
0 B		 82.705 kB
25.023 kB		 🆕 New entry
react-northstar
Carousel		 0 B
0 B		 105.182 kB
31.871 kB		 🆕 New entry
react-northstar
Chat		 0 B
0 B		 154.09 kB
46.847 kB		 🆕 New entry
react-northstar
Checkbox		 0 B
0 B		 79.807 kB
25.078 kB		 🆕 New entry
react-northstar
Datepicker		 0 B
0 B		 186.651 kB
56.973 kB		 🆕 New entry
react-northstar
Debug		 0 B
0 B		 8.801 kB
3.594 kB		 🆕 New entry
react-northstar
Design		 0 B
0 B		 36.589 kB
12.067 kB		 🆕 New entry
react-northstar
Dialog		 0 B
0 B		 112.058 kB
33.615 kB		 🆕 New entry
react-northstar
Divider		 0 B
0 B		 76.619 kB
24.129 kB		 🆕 New entry
react-northstar
Dropdown		 0 B
0 B		 198.211 kB
60.214 kB		 🆕 New entry
react-northstar
Embed		 0 B
0 B		 81.477 kB
25.417 kB		 🆕 New entry
react-northstar
Flex		 0 B
0 B		 47.728 kB
15.438 kB		 🆕 New entry
react-northstar
Form		 0 B
0 B		 92.527 kB
28.879 kB		 🆕 New entry
react-northstar
Grid		 0 B
0 B		 70.584 kB
22.278 kB		 🆕 New entry
react-northstar
Header		 0 B
0 B		 74.756 kB
23.461 kB		 🆕 New entry
react-northstar
Image		 0 B
0 B		 73.591 kB
23.329 kB		 🆕 New entry
react-northstar
Input		 0 B
0 B		 88.346 kB
27.78 kB		 🆕 New entry
react-northstar
ItemLayout		 0 B
0 B		 78.231 kB
24.454 kB		 🆕 New entry
react-northstar
Label		 0 B
0 B		 77.92 kB
24.41 kB		 🆕 New entry
react-northstar
Layout		 0 B
0 B		 75.393 kB
23.798 kB		 🆕 New entry
react-northstar
List		 0 B
0 B		 88.493 kB
27.547 kB		 🆕 New entry
react-northstar
Loader		 0 B
0 B		 78.616 kB
24.729 kB		 🆕 New entry
react-northstar
Menu		 0 B
0 B		 128.602 kB
40.717 kB		 🆕 New entry
react-northstar
MenuButton		 0 B
0 B		 163.008 kB
49.606 kB		 🆕 New entry
react-northstar
Pill		 0 B
0 B		 83.722 kB
26.069 kB		 🆕 New entry
react-northstar
Popup		 0 B
0 B		 135.316 kB
42.242 kB		 🆕 New entry
react-northstar
Portal		 0 B
0 B		 58.338 kB
18.852 kB		 🆕 New entry
react-northstar
Provider		 0 B
0 B		 93.138 kB
29.63 kB		 🆕 New entry
react-northstar
RadioGroup		 0 B
0 B		 83.282 kB
26.053 kB		 🆕 New entry
react-northstar
Reaction		 0 B
0 B		 77.28 kB
24.122 kB		 🆕 New entry
react-northstar
Segment		 0 B
0 B		 76.209 kB
23.892 kB		 🆕 New entry
react-northstar
Skeleton		 0 B
0 B		 77.765 kB
24.2 kB		 🆕 New entry
react-northstar
Slider		 0 B
0 B		 84.27 kB
26.737 kB		 🆕 New entry
react-northstar
SplitButton		 0 B
0 B		 178.246 kB
53.42 kB		 🆕 New entry
react-northstar
Status		 0 B
0 B		 76.272 kB
24.05 kB		 🆕 New entry
react-northstar
SvgIcon		 0 B
0 B		 36.823 kB
11.743 kB		 🆕 New entry
react-northstar
Table		 0 B
0 B		 80.796 kB
25.154 kB		 🆕 New entry
react-northstar
Text		 0 B
0 B		 74.114 kB
23.507 kB		 🆕 New entry
react-northstar
TextArea		 0 B
0 B		 74.248 kB
23.492 kB		 🆕 New entry
react-northstar
Toolbar		 0 B
0 B		 175.057 kB
52.832 kB		 🆕 New entry
react-northstar
Tooltip		 0 B
0 B		 109.973 kB
35.227 kB		 🆕 New entry
react-northstar
Tree		 0 B
0 B		 87.855 kB
27.217 kB		 🆕 New entry
react-northstar
Video		 0 B
0 B		 75.411 kB
23.799 kB		 🆕 New entry
react-portal-compat
PortalCompatProvider		 0 B
0 B		 8.39 kB
2.64 kB		 🆕 New entry
react-timepicker-compat
TimePicker		 0 B
0 B		 106.611 kB
35.546 kB		 🆕 New entry
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
priority-overflow
createOverflowManager		 4.457 kB
1.856 kB
react-accordion
Accordion (including children components)		 99.137 kB
30.201 kB
react-avatar
Avatar		 49.301 kB
15.838 kB
react-avatar
AvatarGroup		 20.107 kB
7.973 kB
react-avatar
AvatarGroupItem		 63.445 kB
20.061 kB
react-badge
Badge		 25.952 kB
8.614 kB
react-badge
CounterBadge		 26.731 kB
8.887 kB
react-badge
PresenceBadge		 25.719 kB
9.485 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 113.697 kB
31.537 kB
react-button
Button		 37.105 kB
10.785 kB
react-button
CompoundButton		 43.516 kB
12.076 kB
react-button
MenuButton		 41.912 kB
12.137 kB
react-button
SplitButton		 49.924 kB
13.73 kB
react-button
ToggleButton		 53.035 kB
12.546 kB
react-calendar-compat
Calendar Compat		 149.573 kB
39.871 kB
react-card
Card - All		 100.845 kB
28.873 kB
react-card
Card		 93.629 kB
27.077 kB
react-card
CardFooter		 14.356 kB
5.798 kB
react-card
CardHeader		 16.879 kB
6.664 kB
react-card
CardPreview		 14.42 kB
5.934 kB
react-checkbox
Checkbox		 35.105 kB
12.112 kB
react-combobox
Combobox (including child components)		 103.623 kB
34.007 kB
react-combobox
Dropdown (including child components)		 104.209 kB
33.914 kB
react-datepicker-compat
DatePicker Compat		 223.049 kB
63.147 kB
react-dialog
Dialog (including children components)		 99.491 kB
29.895 kB
react-divider
Divider		 21.328 kB
7.965 kB
react-field
Field		 23.384 kB
8.903 kB
react-image
Image		 15.362 kB
6.248 kB
react-input
Input		 28.015 kB
9.456 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.781 kB
1.646 kB
react-jsx-runtime
JSX Runtime		 4.377 kB
1.881 kB
react-label
Label		 14.672 kB
6.002 kB
react-link
Link		 17.193 kB
6.993 kB
react-menu
Menu (including children components)		 151.286 kB
45.713 kB
react-menu
Menu (including selectable components)		 153.972 kB
46.205 kB
react-message-bar
MessageBar (all components)		 24.596 kB
9.18 kB
react-motion
@fluentui/react-motion - createMotionComponent()		 4.173 kB
1.847 kB
react-motion
@fluentui/react-motion - createPresenceComponent()		 4.934 kB
2.177 kB
react-motion
@fluentui/react-motion - PresenceGroup		 1.714 kB
819 B
react-overflow
hooks only		 12.821 kB
4.813 kB
react-persona
Persona		 56.192 kB
17.728 kB
react-popover
Popover		 127.198 kB
39.776 kB
react-portal
Portal		 14.563 kB
5.118 kB
react-positioning
usePositioning		 26.489 kB
9.552 kB
react-progress
ProgressBar		 17.086 kB
6.906 kB
react-provider
FluentProvider		 24.618 kB
8.906 kB
react-radio
Radio		 32.673 kB
10.351 kB
react-radio
RadioGroup		 15.76 kB
6.433 kB
react-select
Select		 27.723 kB
10.131 kB
react-slider
Slider		 37.17 kB
12.547 kB
react-spinbutton
SpinButton		 36.102 kB
11.85 kB
react-spinner
Spinner		 25.246 kB
8.554 kB
react-swatch-picker
@fluentui/react-swatch-picker - package		 103.73 kB
30.098 kB
react-switch
Switch		 35.301 kB
11.348 kB
react-table
DataGrid		 160.337 kB
45.661 kB
react-table
Table (Primitives only)		 42.482 kB
13.868 kB
react-table
Table as DataGrid		 131.142 kB
36.351 kB
react-table
Table (Selection only)		 70.336 kB
20.028 kB
react-table
Table (Sort only)		 68.979 kB
19.633 kB
react-tag-picker
@fluentui/react-tag-picker - package		 181.227 kB
54.489 kB
react-tags
InteractionTag		 15.167 kB
6.135 kB
react-tags
Tag		 28.996 kB
9.52 kB
react-tags
TagGroup		 82.124 kB
24.344 kB
react-text
Text - Default		 17.063 kB
6.733 kB
react-text
Text - Wrappers		 20.235 kB
7.064 kB
react-textarea
Textarea		 26.572 kB
9.769 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 35.666 kB
7.453 kB
react-theme
Teams: Light theme		 19.642 kB
5.549 kB
react-toast
Toast (including Toaster)		 97.701 kB
29.409 kB
react-tooltip
Tooltip		 54.558 kB
19.23 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against 8303652a141232be9e03658f295b8ab6512e43aa

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AttachmentMinimalPerf.default 76 83 0.92:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 116 102 1.14:1
TreeWith60ListItems.default 93 83 1.12:1
ImageMinimalPerf.default 243 221 1.1:1
DialogMinimalPerf.default 469 434 1.08:1
SegmentMinimalPerf.default 211 195 1.08:1
SkeletonMinimalPerf.default 210 194 1.08:1
CarouselMinimalPerf.default 271 254 1.07:1
ProviderMinimalPerf.default 208 195 1.07:1
RefMinimalPerf.default 117 109 1.07:1
BoxMinimalPerf.default 201 189 1.06:1
ToolbarMinimalPerf.default 556 525 1.06:1
LabelMinimalPerf.default 230 220 1.05:1
RadioGroupMinimalPerf.default 280 266 1.05:1
ReactionMinimalPerf.default 215 205 1.05:1
AccordionMinimalPerf.default 86 83 1.04:1
ButtonMinimalPerf.default 94 90 1.04:1
DividerMinimalPerf.default 215 206 1.04:1
HeaderSlotsPerf.default 468 449 1.04:1
ItemLayoutMinimalPerf.default 721 692 1.04:1
PortalMinimalPerf.default 87 84 1.04:1
TableMinimalPerf.default 235 225 1.04:1
VideoMinimalPerf.default 439 421 1.04:1
AttachmentSlotsPerf.default 670 649 1.03:1
FormMinimalPerf.default 220 214 1.03:1
AnimationMinimalPerf.default 304 297 1.02:1
ButtonSlotsPerf.default 319 312 1.02:1
ChatMinimalPerf.default 449 440 1.02:1
DropdownMinimalPerf.default 1435 1411 1.02:1
EmbedMinimalPerf.default 1918 1882 1.02:1
ListCommonPerf.default 392 386 1.02:1
StatusMinimalPerf.default 396 388 1.02:1
IconMinimalPerf.default 384 378 1.02:1
TextMinimalPerf.default 196 192 1.02:1
TextAreaMinimalPerf.default 293 287 1.02:1
AlertMinimalPerf.default 159 158 1.01:1
DatepickerMinimalPerf.default 3612 3585 1.01:1
GridMinimalPerf.default 191 189 1.01:1
InputMinimalPerf.default 547 540 1.01:1
MenuMinimalPerf.default 518 511 1.01:1
CustomToolbarPrototype.default 1472 1460 1.01:1
ChatWithPopoverPerf.default 205 204 1:1
CheckboxMinimalPerf.default 1139 1141 1:1
MenuButtonMinimalPerf.default 950 951 1:1
TableManyItemsPerf.default 1102 1104 1:1
TooltipMinimalPerf.default 1241 1242 1:1
ButtonOverridesMissPerf.default 669 677 0.99:1
HeaderMinimalPerf.default 206 209 0.99:1
ListMinimalPerf.default 298 300 0.99:1
PopupMinimalPerf.default 350 353 0.99:1
ProviderMergeThemesPerf.default 649 653 0.99:1
SliderMinimalPerf.default 737 744 0.99:1
SplitButtonMinimalPerf.default 2286 2304 0.99:1
ListNestedPerf.default 321 328 0.98:1
ListWith60ListItems.default 377 386 0.98:1
LoaderMinimalPerf.default 194 197 0.98:1
RosterPerf.default 1588 1618 0.98:1
CardMinimalPerf.default 306 315 0.97:1
DropdownManyItemsPerf.default 381 391 0.97:1
TreeMinimalPerf.default 489 502 0.97:1
FlexMinimalPerf.default 159 168 0.95:1
LayoutMinimalPerf.default 197 207 0.95:1
ChatDuplicateMessagesPerf.default 144 154 0.94:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 635 654 5000
Breadcrumb mount 1685 1700 1000
Checkbox mount 1677 1704 5000
CheckboxBase mount 1475 1476 5000
ChoiceGroup mount 2956 2977 5000
ComboBox mount 676 685 1000
CommandBar mount 6607 6600 1000
ContextualMenu mount 13676 14751 1000
DefaultButton mount 791 795 5000
DetailsRow mount 2255 2213 5000
DetailsRowFast mount 2184 2230 5000
DetailsRowNoStyles mount 2028 2054 5000
Dialog mount 2833 2684 1000
DocumentCardTitle mount 230 236 1000
Dropdown mount 1973 2020 5000
FocusTrapZone mount 1116 1145 5000
FocusZone mount 1076 1103 5000
GroupedList mount 42373 42344 2
GroupedList virtual-rerender 20412 20473 2
GroupedList virtual-rerender-with-unmount 52590 51912 2
GroupedListV2 mount 229 233 2
GroupedListV2 virtual-rerender 214 219 2
GroupedListV2 virtual-rerender-with-unmount 232 232 2
IconButton mount 1138 1156 5000
Label mount 343 343 5000
Layer mount 2743 2759 5000
Link mount 405 407 5000
MenuButton mount 987 955 5000
MessageBar mount 21398 21389 5000
Nav mount 2033 2040 1000
OverflowSet mount 810 801 5000
Panel mount 1835 1798 1000
Persona mount 747 766 1000
Pivot mount 915 905 1000
PrimaryButton mount 911 925 5000
Rating mount 4632 4673 5000
SearchBox mount 903 912 5000
Shimmer mount 1915 1912 5000
Slider mount 1342 1366 5000
SpinButton mount 2990 3025 5000
Spinner mount 396 388 5000
SplitButton mount 1893 1901 5000
Stack mount 416 435 5000
StackWithIntrinsicChildren mount 860 870 5000
StackWithTextChildren mount 2769 2779 5000
SwatchColorPicker mount 6457 6378 5000
TagPicker mount 1531 1491 5000
Text mount 389 382 5000
TextField mount 960 954 5000
ThemeProvider mount 878 841 5000
ThemeProvider virtual-rerender 578 601 5000
ThemeProvider virtual-rerender-with-unmount 1325 1308 5000
Toggle mount 632 606 5000
buttonNative mount 199 199 5000

@bsunderhus bsunderhus marked this pull request as ready for review July 23, 2024 08:08
@bsunderhus bsunderhus requested review from a team as code owners July 23, 2024 08:08
mainframev
mainframev approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@mainframev mainframev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick reaction on this! @bsunderhus 🚀

@bsunderhus bsunderhus merged commit 5e3705d into microsoft:master Jul 23, 2024
21 checks passed
@bsunderhus bsunderhus deleted the react-utilities/chore--removes-type-dependency-on-@fluentui/react-utilities-internals branch July 23, 2024 08:39
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jul 25, 2024
@marcosmoura
Merge branch 'master' into fix/react-card/HC-improvements
93f7b9c 
* master: (77 commits)
  chore(react-examples): replace storybook deprecated api with static stories (microsoft#32074)
  [chore]: create base class for accordion item and remove style and layout specific api (microsoft#32102)
  release: applying package updates - web-components
  chore(web-components): add test for complex focus management (microsoft#32009)
  [chore]: create base class for avatar and remove style and layout specific api (microsoft#32083)
  [chore]: create base class for text input and remove style and layout specific api (microsoft#32080)
  release: applying package updates - web-components
  chore:(react-nav-preview) Scaffold AppItem (microsoft#32088)
  docs(`react-teaching-popover`): Adding subcomponents' API to `TeachingPopover` documentation page (microsoft#32084)
  feat(web-components): relax setTheme() argument type to allow custom tokens (microsoft#32087)
  release: applying package updates - react-components
  [Chore]: Create Spinner base class to abstract out style and layout specific api. (microsoft#32067)
  [Chore]: Create Progress Bar base class to abstract out style and layout specific api. (microsoft#32066)
  fix(react-storybook-addon): transform decorator to function in withAriaLive() (microsoft#32011)
  fix(motion): improve Web Animations API detection in tests (microsoft#32029)
  chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule (microsoft#32072)
  release: applying package updates - react v8
  release: applying package updates - web-components
  Chore: Create Divider base class to abstract out style and layout specific api (microsoft#32065)
  fix(TimePicker): Clear text when date value changes to null (microsoft#31626)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@mainframev mainframev mainframev approved these changes

@ling1726 ling1726 ling1726 approved these changes

Assignees

@bsunderhus bsunderhus

Labels
None yet
Projects
None yet
Milestone
July Project Cycle Q3 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@bsunderhus @fabricteam @mainframev @ling1726