Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-components): remove type-check definition and follow repo target defaults for consistency and type-check speeds #32208

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Aug 2, 2024

Previous Behavior

  • wc use custom target dep override that is not consistent with monorepo best practices for lates code
  • this behaviour also breaks domain boundaries

New Behavior

Related Issue(s)

…arget defaults for consistency and type-check speeds
@Hotell Hotell changed the title chore(web-components): remove type-check definition and follow repo t… chore(web-components): remove type-check definition and follow repo target defaults for consistency and type-check speeds Aug 2, 2024
@github-actions github-actions bot added this to the August Project Cycle Q3 2024 milestone Aug 2, 2024
@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@Hotell Hotell marked this pull request as ready for review August 2, 2024 10:10
@Hotell Hotell requested review from a team as code owners August 2, 2024 10:10
@Hotell
Copy link
Contributor Author

Hotell commented Aug 5, 2024

can we get review on this pls @chrisdholt

@Hotell Hotell merged commit 30765e0 into microsoft:master Aug 6, 2024
18 checks passed
@Hotell Hotell deleted the nx/fix-task-deps-wc branch August 6, 2024 07:34
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 7, 2024
* master: (48 commits)
  chore: migrate to storybook v7 (microsoft#32018)
  release: applying package updates - react-components
  ci: make public-docsite-v9 deploy pipeline work and make it faster (microsoft#32248)
  fix(Toolbar): hardcode size of `ToolbarButton` (microsoft#32185)
  chore: deprecate @fluentui/react-motion-preview (microsoft#32190)
  release: applying package updates - web-components
  docs: add wrapping menu item example to ContextualMenu docs (microsoft#31289)
  docs: update title of v8 keyboard-accessible drag & drop example, add docs (microsoft#32216)
  release: applying package updates - react-components
  fix: Card does not override specified focusMode based on event listeners (microsoft#32200)
  Fix undefined reference in older browsers in useMessageBarReflow (microsoft#32238)
  feat: Add transparent appearance to ToolbarButton (microsoft#32205)
  fix(react-tabs): ignore ref for tab reserved space content slot (microsoft#31775)
  fix(Dialog): do not require ref forwarding (microsoft#32095)
  feat: add verify-packaging to react v8 release pipeline (microsoft#32212)
  chore(web-components): remove type-check definition and follow repo target defaults for consistency and type-check speeds (microsoft#32208)
  chore(react-tree): improve ImmutableSet and ImmutableMap internal implementation (microsoft#32167)
  release: applying package updates - web-components
  feat(web-components): add tablist (microsoft#32098)
  release: applying package updates - react-components
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants