fix(public-docsite-v9): add all stories project as implicit dependency in order to properly trigger affected build chain #32211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
spmonahan
approved these changes
Aug 2, 2024
dmytrokirpa
approved these changes
Aug 5, 2024
…y in order to properly trigger affected build chain
Hotell
force-pushed
the
public-docsite-v9/add-implicit-deps-on-story-projects
branch
from
bdf402d
to
59ba080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
If only source files of
*-storiesproject are changed within a PR it wont triggerpublic-docsite-v9build-storybookwhich will end up not having storybook deployed per PR in order to review your changesExample of issues:
#32176
V3vuSFj9I3.mp4
New Behavior
as we moved to nx we can leverage powerful capabilities like
implicitDependenciesdefinition which understands patterns set within our monorepo. This also nicely mirrors what is actually happening in real life as we load those project stories imperatively behind the scenes so they are not a direct dependency.Before
After
Related Issue(s)