chore: upgrade to typescript-eslint v8 #32369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
from
8594e22
to
6960670
Compare
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 38 | 28 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 629 | 625 | 5000 | |
| Button | mount | 296 | 302 | 5000 | |
| Field | mount | 1114 | 1156 | 5000 | |
| FluentProvider | mount | 708 | 703 | 5000 | |
| FluentProviderWithTheme | mount | 85 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 38 | 28 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 78 | 10 | |
| MakeStyles | mount | 859 | 864 | 50000 | |
| Persona | mount | 1784 | 1744 | 5000 | |
| SpinButton | mount | 1354 | 1405 | 5000 | |
| SwatchPicker | mount | 1660 | 1646 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| IconMinimalPerf.default | 423 | 385 | 1.1:1 |
| TextAreaMinimalPerf.default | 304 | 277 | 1.1:1 |
| ImageMinimalPerf.default | 236 | 219 | 1.08:1 |
| LabelMinimalPerf.default | 235 | 219 | 1.07:1 |
| ListMinimalPerf.default | 332 | 310 | 1.07:1 |
| AvatarMinimalPerf.default | 115 | 108 | 1.06:1 |
| ButtonMinimalPerf.default | 94 | 89 | 1.06:1 |
| ListNestedPerf.default | 330 | 310 | 1.06:1 |
| RadioGroupMinimalPerf.default | 276 | 261 | 1.06:1 |
| BoxMinimalPerf.default | 196 | 186 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 161 | 154 | 1.05:1 |
| FlexMinimalPerf.default | 162 | 155 | 1.05:1 |
| ItemLayoutMinimalPerf.default | 741 | 707 | 1.05:1 |
| ReactionMinimalPerf.default | 216 | 206 | 1.05:1 |
| CarouselMinimalPerf.default | 267 | 257 | 1.04:1 |
| ListWith60ListItems.default | 388 | 373 | 1.04:1 |
| ButtonSlotsPerf.default | 315 | 306 | 1.03:1 |
| HeaderMinimalPerf.default | 215 | 208 | 1.03:1 |
| HeaderSlotsPerf.default | 477 | 464 | 1.03:1 |
| ListCommonPerf.default | 414 | 401 | 1.03:1 |
| MenuMinimalPerf.default | 519 | 502 | 1.03:1 |
| MenuButtonMinimalPerf.default | 975 | 943 | 1.03:1 |
| PopupMinimalPerf.default | 357 | 347 | 1.03:1 |
| SkeletonMinimalPerf.default | 200 | 194 | 1.03:1 |
| SplitButtonMinimalPerf.default | 2311 | 2245 | 1.03:1 |
| AlertMinimalPerf.default | 165 | 162 | 1.02:1 |
| ButtonOverridesMissPerf.default | 670 | 658 | 1.02:1 |
| DropdownMinimalPerf.default | 1477 | 1450 | 1.02:1 |
| EmbedMinimalPerf.default | 1927 | 1887 | 1.02:1 |
| GridMinimalPerf.default | 199 | 196 | 1.02:1 |
| RefMinimalPerf.default | 115 | 113 | 1.02:1 |
| SegmentMinimalPerf.default | 198 | 194 | 1.02:1 |
| TextMinimalPerf.default | 196 | 192 | 1.02:1 |
| TreeWith60ListItems.default | 93 | 91 | 1.02:1 |
| CheckboxMinimalPerf.default | 1149 | 1142 | 1.01:1 |
| DialogMinimalPerf.default | 453 | 448 | 1.01:1 |
| DividerMinimalPerf.default | 209 | 207 | 1.01:1 |
| FormMinimalPerf.default | 237 | 235 | 1.01:1 |
| ProviderMinimalPerf.default | 206 | 204 | 1.01:1 |
| TableManyItemsPerf.default | 1126 | 1117 | 1.01:1 |
| AttachmentMinimalPerf.default | 80 | 80 | 1:1 |
| DatepickerMinimalPerf.default | 3571 | 3588 | 1:1 |
| PortalMinimalPerf.default | 85 | 85 | 1:1 |
| SliderMinimalPerf.default | 763 | 761 | 1:1 |
| TooltipMinimalPerf.default | 1299 | 1294 | 1:1 |
| TreeMinimalPerf.default | 491 | 489 | 1:1 |
| ChatWithPopoverPerf.default | 199 | 202 | 0.99:1 |
| InputMinimalPerf.default | 550 | 555 | 0.99:1 |
| LoaderMinimalPerf.default | 187 | 189 | 0.99:1 |
| ProviderMergeThemesPerf.default | 659 | 666 | 0.99:1 |
| CustomToolbarPrototype.default | 1463 | 1474 | 0.99:1 |
| ToolbarMinimalPerf.default | 527 | 535 | 0.99:1 |
| VideoMinimalPerf.default | 443 | 453 | 0.98:1 |
| DropdownManyItemsPerf.default | 393 | 405 | 0.97:1 |
| RosterPerf.default | 1557 | 1606 | 0.97:1 |
| StatusMinimalPerf.default | 382 | 394 | 0.97:1 |
| TableMinimalPerf.default | 230 | 237 | 0.97:1 |
| AnimationMinimalPerf.default | 300 | 313 | 0.96:1 |
| AttachmentSlotsPerf.default | 634 | 670 | 0.95:1 |
| CardMinimalPerf.default | 305 | 322 | 0.95:1 |
| ChatMinimalPerf.default | 429 | 453 | 0.95:1 |
| AccordionMinimalPerf.default | 74 | 80 | 0.93:1 |
| LayoutMinimalPerf.default | 188 | 205 | 0.92:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 633 | 642 | 5000 | |
| Breadcrumb | mount | 1726 | 1710 | 1000 | |
| Checkbox | mount | 1687 | 1730 | 5000 | |
| CheckboxBase | mount | 1479 | 1503 | 5000 | |
| ChoiceGroup | mount | 2964 | 2982 | 5000 | |
| ComboBox | mount | 679 | 670 | 1000 | |
| CommandBar | mount | 6572 | 6577 | 1000 | |
| ContextualMenu | mount | 12418 | 12282 | 1000 | |
| DefaultButton | mount | 794 | 806 | 5000 | |
| DetailsRow | mount | 2226 | 2253 | 5000 | |
| DetailsRowFast | mount | 2266 | 2237 | 5000 | |
| DetailsRowNoStyles | mount | 2047 | 2091 | 5000 | |
| Dialog | mount | 2675 | 2825 | 1000 | |
| DocumentCardTitle | mount | 240 | 233 | 1000 | |
| Dropdown | mount | 1998 | 2006 | 5000 | |
| FocusTrapZone | mount | 1187 | 1188 | 5000 | |
| FocusZone | mount | 1087 | 1091 | 5000 | |
| GroupedList | mount | 42337 | 42902 | 2 | |
| GroupedList | virtual-rerender | 20367 | 20434 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51841 | 52358 | 2 | |
| GroupedListV2 | mount | 234 | 229 | 2 | |
| GroupedListV2 | virtual-rerender | 213 | 216 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 229 | 232 | 2 | |
| IconButton | mount | 1156 | 1143 | 5000 | |
| Label | mount | 346 | 345 | 5000 | |
| Layer | mount | 2756 | 2799 | 5000 | |
| Link | mount | 406 | 395 | 5000 | |
| MenuButton | mount | 988 | 1013 | 5000 | |
| MessageBar | mount | 21501 | 21521 | 5000 | |
| Nav | mount | 2047 | 2044 | 1000 | |
| OverflowSet | mount | 798 | 788 | 5000 | |
| Panel | mount | 1905 | 1841 | 1000 | |
| Persona | mount | 726 | 778 | 1000 | |
| Pivot | mount | 895 | 905 | 1000 | |
| PrimaryButton | mount | 916 | 914 | 5000 | |
| Rating | mount | 4687 | 4655 | 5000 | |
| SearchBox | mount | 923 | 933 | 5000 | |
| Shimmer | mount | 1869 | 1887 | 5000 | |
| Slider | mount | 1370 | 1342 | 5000 | |
| SpinButton | mount | 3017 | 2993 | 5000 | |
| Spinner | mount | 393 | 390 | 5000 | |
| SplitButton | mount | 1911 | 1905 | 5000 | |
| Stack | mount | 423 | 429 | 5000 | |
| StackWithIntrinsicChildren | mount | 881 | 885 | 5000 | |
| StackWithTextChildren | mount | 2748 | 2779 | 5000 | |
| SwatchColorPicker | mount | 6486 | 6341 | 5000 | |
| TagPicker | mount | 1450 | 1467 | 5000 | |
| Text | mount | 377 | 387 | 5000 | |
| TextField | mount | 968 | 900 | 5000 | |
| ThemeProvider | mount | 848 | 840 | 5000 | |
| ThemeProvider | virtual-rerender | 577 | 586 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1334 | 1298 | 5000 | |
| Toggle | mount | 587 | 628 | 5000 | |
| buttonNative | mount | 193 | 196 | 5000 |
fabricteam
reviewed
Aug 23, 2024
mainframev
commented
Aug 23, 2024
mainframev
commented
Aug 23, 2024
packages/eslint-plugin/src/rules/ban-context-export/index.test.js
Outdated
Show resolved
Hide resolved
mainframev
commented
Aug 23, 2024
packages/eslint-plugin/src/rules/ban-instanceof-html-element/index.test.js
Show resolved
Hide resolved
mainframev
commented
Aug 23, 2024
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
from
6960670
to
768cec4
Compare
mainframev
commented
Aug 23, 2024
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
3 times, most recently
from
6e454c1
to
04f43ba
Compare
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
from
04f43ba
to
304a1a7
Compare
6 tasks
|
@mainframev once this lands #32923 we are good to go |
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
3 times, most recently
from
66001e4
to
4ff0cdc
Compare
fabricteam
reviewed
Oct 2, 2024
change/@fluentui-eslint-plugin-9708d729-ebb2-44cd-8fe1-30cf46fc403d.json
Show resolved
Hide resolved
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
4 times, most recently
from
8f513d2
to
3c35a63
Compare
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
from
b25f39e
to
3aa4272
Compare
mainframev
commented
Oct 15, 2024
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
from
859bf27
to
12fdcf2
Compare
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
from
12fdcf2
to
2297e2b
Compare
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Hotell
reviewed
Oct 18, 2024
change/@fluentui-eslint-plugin-9708d729-ebb2-44cd-8fe1-30cf46fc403d.json
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/src/rules/ban-context-export/index.test.js
Outdated
Show resolved
Hide resolved
packages/fluentui/docs/src/components/ComponentDoc/ComponentSourceManager/getExampleModule.ts
Show resolved
Hide resolved
…c403d.json Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
layershifter
approved these changes
Oct 21, 2024
|
would be great to get bench data as well ( is it slower/faster thatn ts-eslint v7 ) |
mainframev
force-pushed
the
chore/upgrade-typescript-eslint-v8
branch
from
9bbc6df
to
23df010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Upgraded
@typescript-eslintto v8Release notes
Related Issue(s)
❌ Currently blocked bynx. Whennxwill upgrade to the latest eslint and will bump@typescript-eslintto v8 as well in@nx/eslint-pluginwe can proceed forward with this.