-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-nav-preview]feat: Adds SplitNav*Sub*Item #32964
Merged
mltejera
merged 25 commits into
microsoft:master
from
mltejera:nav/build-out-split-nav-sub-item
Oct 7, 2024
Merged
[react-nav-preview]feat: Adds SplitNav*Sub*Item #32964
mltejera
merged 25 commits into
microsoft:master
from
mltejera:nav/build-out-split-nav-sub-item
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mltejera
commented
Oct 1, 2024
...onents/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItemStyles.styles.ts
Outdated
Show resolved
Hide resolved
📊 Bundle size report✅ No changes found |
mltejera
commented
Oct 1, 2024
change/@fluentui-react-nav-preview-b9aea238-32a9-438f-808c-724f85dd2f66.json
Outdated
Show resolved
Hide resolved
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
fabricteam
reviewed
Oct 2, 2024
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Oct 2, 2024
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 620 | 612 | 5000 | |
Breadcrumb | mount | 1703 | 1692 | 1000 | |
Checkbox | mount | 1682 | 1718 | 5000 | |
CheckboxBase | mount | 1494 | 1480 | 5000 | |
ChoiceGroup | mount | 2894 | 2935 | 5000 | |
ComboBox | mount | 693 | 669 | 1000 | |
CommandBar | mount | 6516 | 6603 | 1000 | |
ContextualMenu | mount | 11554 | 11891 | 1000 | |
DefaultButton | mount | 794 | 788 | 5000 | |
DetailsRow | mount | 2226 | 2202 | 5000 | |
DetailsRowFast | mount | 2238 | 2242 | 5000 | |
DetailsRowNoStyles | mount | 2065 | 2002 | 5000 | |
Dialog | mount | 2739 | 2680 | 1000 | |
DocumentCardTitle | mount | 233 | 248 | 1000 | |
Dropdown | mount | 1968 | 2027 | 5000 | |
FocusTrapZone | mount | 1153 | 1162 | 5000 | |
FocusZone | mount | 1093 | 1109 | 5000 | |
GroupedList | mount | 42391 | 42374 | 2 | |
GroupedList | virtual-rerender | 20269 | 20373 | 2 | |
GroupedList | virtual-rerender-with-unmount | 51551 | 51861 | 2 | |
GroupedListV2 | mount | 220 | 226 | 2 | |
GroupedListV2 | virtual-rerender | 217 | 216 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 221 | 229 | 2 | |
IconButton | mount | 1141 | 1099 | 5000 | |
Label | mount | 334 | 339 | 5000 | |
Layer | mount | 2739 | 2719 | 5000 | |
Link | mount | 388 | 395 | 5000 | |
MenuButton | mount | 968 | 980 | 5000 | |
MessageBar | mount | 21255 | 21314 | 5000 | |
Nav | mount | 2025 | 2040 | 1000 | |
OverflowSet | mount | 801 | 791 | 5000 | |
Panel | mount | 1804 | 1796 | 1000 | |
Persona | mount | 744 | 736 | 1000 | |
Pivot | mount | 908 | 910 | 1000 | |
PrimaryButton | mount | 931 | 941 | 5000 | |
Rating | mount | 4751 | 4643 | 5000 | |
SearchBox | mount | 928 | 928 | 5000 | |
Shimmer | mount | 1887 | 1909 | 5000 | |
Slider | mount | 1361 | 1330 | 5000 | |
SpinButton | mount | 2949 | 2994 | 5000 | |
Spinner | mount | 381 | 388 | 5000 | |
SplitButton | mount | 1856 | 1892 | 5000 | |
Stack | mount | 434 | 418 | 5000 | |
StackWithIntrinsicChildren | mount | 868 | 879 | 5000 | |
StackWithTextChildren | mount | 2734 | 2751 | 5000 | |
SwatchColorPicker | mount | 6465 | 6462 | 5000 | |
TagPicker | mount | 1493 | 1475 | 5000 | |
Text | mount | 390 | 393 | 5000 | |
TextField | mount | 918 | 927 | 5000 | |
ThemeProvider | mount | 864 | 861 | 5000 | |
ThemeProvider | virtual-rerender | 580 | 593 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1309 | 1296 | 5000 | |
Toggle | mount | 624 | 608 | 5000 | |
buttonNative | mount | 195 | 194 | 5000 |
packages/react-components/react-nav-preview/library/etc/react-nav-preview.api.md
Outdated
Show resolved
Hide resolved
...s/react-components/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItem.tsx
Outdated
Show resolved
Hide resolved
...s/react-components/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItem.tsx
Outdated
Show resolved
Hide resolved
...onents/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItemStyles.styles.ts
Outdated
Show resolved
Hide resolved
...onents/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItemStyles.styles.ts
Show resolved
Hide resolved
mltejera
commented
Oct 2, 2024
Mitch-At-Work
approved these changes
Oct 2, 2024
mltejera
requested review from
GeoffCoxMSFT,
a team,
marcosmoura,
khmakoto,
dzearing,
Jahnp,
bigbadcapers and
Jacqueline-ms
as code owners
October 3, 2024 22:54
mltejera
force-pushed
the
nav/build-out-split-nav-sub-item
branch
from
October 3, 2024 23:05
aa86d2d
to
6fbc39a
Compare
tudorpopams
approved these changes
Oct 4, 2024
mltejera
force-pushed
the
nav/build-out-split-nav-sub-item
branch
from
October 7, 2024 16:48
568aabb
to
f9bccbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
SplitNavSubItem
feature to the@fluentui/react-nav-preview
package. The changes focus on adding support fornavSubItem
withinSplitNavItem
components, updating the related styles, and modifying the storybook examples to demonstrate the new functionality. We also add optional Tooltips to the icon buttons.AI Gen below:
This pull request introduces several enhancements and new features to the
@fluentui/react-nav-preview
package, focusing on adding support for sub-navigation items, tooltips, and other UI improvements. The changes include updates to the component props, state management, and styles to accommodate these new features.Enhancements to Sub-Navigation and Tooltips:
packages/react-components/react-nav-preview/library/src/components/SplitNavItem/SplitNavItem.types.ts
: AddedNavSubItemProps
tonavItem
and introduced new slots foractionButtonTooltip
,toggleButtonTooltip
, andmenuButtonTooltip
. Also addedisSubNav
to theSplitNavItemState
. [1] [2] [3]packages/react-components/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItem.tsx
: Updated theuseSplitNavItem
hook to handle the new tooltip slots and theisSubNav
state. [1] [2] [3]Component and Style Updates:
packages/react-components/react-nav-preview/library/src/components/SplitNavItem/renderSplitNavItem.tsx
: Modified therenderSplitNavItem
function to wrap buttons with their respective tooltips if provided.packages/react-components/react-nav-preview/library/src/components/SplitNavItem/useSplitNavItemStyles.styles.ts
: Updated styles to align with new sub-navigation and tooltip features, including adding new class names for tooltips. [1] [2]Dependency and Documentation Updates:
packages/react-components/react-nav-preview/library/package.json
: Added@fluentui/react-tooltip
as a dependency.packages/react-components/react-nav-preview/library/etc/react-nav-preview.api.md
: Updated API documentation to include new props and types. [1] [2]Storybook Examples:
packages/react-components/react-nav-preview/stories/src/NavDrawer/SplitNavItems.stories.tsx
: Enhanced storybook examples to demonstrate the new sub-navigation and tooltip features. [1] [2]