-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel: Fade and Carousel Modal example (FRE) #33000
Merged
Mitch-At-Work
merged 6 commits into
microsoft:master
from
Mitch-At-Work:user/mifraser/carousel-fade
Oct 15, 2024
Merged
Carousel: Fade and Carousel Modal example (FRE) #33000
Mitch-At-Work
merged 6 commits into
microsoft:master
from
Mitch-At-Work:user/mifraser/carousel-fade
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Oct 7, 2024
change/@fluentui-react-carousel-973e8fc6-d327-490f-a135-a9100a53033c.json
Show resolved
Hide resolved
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AttachmentMinimalPerf.default | 88 | 76 | 1.16:1 |
PortalMinimalPerf.default | 97 | 86 | 1.13:1 |
ButtonMinimalPerf.default | 92 | 84 | 1.1:1 |
SegmentMinimalPerf.default | 206 | 189 | 1.09:1 |
RefMinimalPerf.default | 118 | 109 | 1.08:1 |
DividerMinimalPerf.default | 217 | 205 | 1.06:1 |
SkeletonMinimalPerf.default | 204 | 192 | 1.06:1 |
SliderMinimalPerf.default | 747 | 703 | 1.06:1 |
IconMinimalPerf.default | 390 | 368 | 1.06:1 |
ReactionMinimalPerf.default | 218 | 207 | 1.05:1 |
TableMinimalPerf.default | 242 | 231 | 1.05:1 |
AccordionMinimalPerf.default | 84 | 81 | 1.04:1 |
AlertMinimalPerf.default | 165 | 158 | 1.04:1 |
CheckboxMinimalPerf.default | 1148 | 1112 | 1.03:1 |
TreeMinimalPerf.default | 489 | 475 | 1.03:1 |
ButtonSlotsPerf.default | 311 | 305 | 1.02:1 |
DialogMinimalPerf.default | 449 | 440 | 1.02:1 |
EmbedMinimalPerf.default | 1898 | 1861 | 1.02:1 |
LoaderMinimalPerf.default | 190 | 186 | 1.02:1 |
ProviderMinimalPerf.default | 205 | 200 | 1.02:1 |
RadioGroupMinimalPerf.default | 261 | 256 | 1.02:1 |
TableManyItemsPerf.default | 1114 | 1090 | 1.02:1 |
ChatWithPopoverPerf.default | 195 | 193 | 1.01:1 |
DropdownManyItemsPerf.default | 388 | 384 | 1.01:1 |
InputMinimalPerf.default | 533 | 529 | 1.01:1 |
RosterPerf.default | 1583 | 1568 | 1.01:1 |
ProviderMergeThemesPerf.default | 658 | 652 | 1.01:1 |
ToolbarMinimalPerf.default | 552 | 549 | 1.01:1 |
AnimationMinimalPerf.default | 306 | 306 | 1:1 |
CarouselMinimalPerf.default | 266 | 266 | 1:1 |
FlexMinimalPerf.default | 156 | 156 | 1:1 |
HeaderMinimalPerf.default | 204 | 203 | 1:1 |
ImageMinimalPerf.default | 223 | 224 | 1:1 |
ListCommonPerf.default | 412 | 412 | 1:1 |
ListWith60ListItems.default | 365 | 366 | 1:1 |
MenuButtonMinimalPerf.default | 947 | 951 | 1:1 |
PopupMinimalPerf.default | 350 | 349 | 1:1 |
TextAreaMinimalPerf.default | 287 | 286 | 1:1 |
CustomToolbarPrototype.default | 1452 | 1449 | 1:1 |
VideoMinimalPerf.default | 452 | 453 | 1:1 |
ChatDuplicateMessagesPerf.default | 154 | 156 | 0.99:1 |
ChatMinimalPerf.default | 444 | 448 | 0.99:1 |
DatepickerMinimalPerf.default | 3531 | 3549 | 0.99:1 |
FormMinimalPerf.default | 225 | 227 | 0.99:1 |
CardMinimalPerf.default | 301 | 307 | 0.98:1 |
DropdownMinimalPerf.default | 1419 | 1441 | 0.98:1 |
ListMinimalPerf.default | 304 | 311 | 0.98:1 |
ListNestedPerf.default | 326 | 333 | 0.98:1 |
MenuMinimalPerf.default | 493 | 502 | 0.98:1 |
AvatarMinimalPerf.default | 105 | 108 | 0.97:1 |
ButtonOverridesMissPerf.default | 650 | 673 | 0.97:1 |
ItemLayoutMinimalPerf.default | 691 | 715 | 0.97:1 |
SplitButtonMinimalPerf.default | 2222 | 2290 | 0.97:1 |
TooltipMinimalPerf.default | 1253 | 1291 | 0.97:1 |
AttachmentSlotsPerf.default | 626 | 654 | 0.96:1 |
BoxMinimalPerf.default | 191 | 198 | 0.96:1 |
LayoutMinimalPerf.default | 200 | 208 | 0.96:1 |
GridMinimalPerf.default | 184 | 193 | 0.95:1 |
HeaderSlotsPerf.default | 455 | 477 | 0.95:1 |
TextMinimalPerf.default | 192 | 202 | 0.95:1 |
LabelMinimalPerf.default | 211 | 225 | 0.94:1 |
StatusMinimalPerf.default | 375 | 405 | 0.93:1 |
TreeWith60ListItems.default | 84 | 95 | 0.88:1 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 626 | 622 | 5000 | |
Button | mount | 312 | 316 | 5000 | |
Field | mount | 1150 | 1125 | 5000 | |
FluentProvider | mount | 703 | 718 | 5000 | |
FluentProviderWithTheme | mount | 84 | 95 | 10 | |
FluentProviderWithTheme | virtual-rerender | 33 | 34 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 75 | 10 | |
MakeStyles | mount | 877 | 858 | 50000 | |
Persona | mount | 1767 | 1705 | 5000 | |
SpinButton | mount | 1380 | 1355 | 5000 | |
SwatchPicker | mount | 1657 | 1615 | 5000 |
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Oct 7, 2024
change/@fluentui-react-carousel-973e8fc6-d327-490f-a135-a9100a53033c.json
Show resolved
Hide resolved
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 639 | 622 | 5000 | |
Breadcrumb | mount | 1714 | 1719 | 1000 | |
Checkbox | mount | 1715 | 1699 | 5000 | |
CheckboxBase | mount | 1506 | 1516 | 5000 | |
ChoiceGroup | mount | 2941 | 3005 | 5000 | |
ComboBox | mount | 695 | 690 | 1000 | |
CommandBar | mount | 6629 | 6592 | 1000 | |
ContextualMenu | mount | 12552 | 12669 | 1000 | |
DefaultButton | mount | 804 | 806 | 5000 | |
DetailsRow | mount | 2227 | 2289 | 5000 | |
DetailsRowFast | mount | 2275 | 2274 | 5000 | |
DetailsRowNoStyles | mount | 2080 | 2043 | 5000 | |
Dialog | mount | 2803 | 2873 | 1000 | |
DocumentCardTitle | mount | 230 | 232 | 1000 | |
Dropdown | mount | 2023 | 2100 | 5000 | |
FocusTrapZone | mount | 1154 | 1181 | 5000 | |
FocusZone | mount | 1117 | 1088 | 5000 | |
GroupedList | mount | 43445 | 43524 | 2 | |
GroupedList | virtual-rerender | 20774 | 20971 | 2 | |
GroupedList | virtual-rerender-with-unmount | 52080 | 53055 | 2 | |
GroupedListV2 | mount | 221 | 242 | 2 | |
GroupedListV2 | virtual-rerender | 222 | 214 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 227 | 233 | 2 | |
IconButton | mount | 1128 | 1161 | 5000 | |
Label | mount | 348 | 349 | 5000 | |
Layer | mount | 2833 | 2806 | 5000 | |
Link | mount | 406 | 393 | 5000 | |
MenuButton | mount | 988 | 1007 | 5000 | |
MessageBar | mount | 21369 | 21384 | 5000 | |
Nav | mount | 2054 | 2073 | 1000 | |
OverflowSet | mount | 789 | 790 | 5000 | |
Panel | mount | 1903 | 1804 | 1000 | |
Persona | mount | 790 | 765 | 1000 | |
Pivot | mount | 896 | 903 | 1000 | |
PrimaryButton | mount | 946 | 930 | 5000 | |
Rating | mount | 4691 | 4761 | 5000 | |
SearchBox | mount | 944 | 933 | 5000 | |
Shimmer | mount | 1920 | 1897 | 5000 | |
Slider | mount | 1363 | 1324 | 5000 | |
SpinButton | mount | 2988 | 3038 | 5000 | |
Spinner | mount | 391 | 399 | 5000 | |
SplitButton | mount | 1877 | 1839 | 5000 | |
Stack | mount | 423 | 413 | 5000 | |
StackWithIntrinsicChildren | mount | 868 | 862 | 5000 | |
StackWithTextChildren | mount | 2756 | 2761 | 5000 | |
SwatchColorPicker | mount | 6500 | 6409 | 5000 | |
TagPicker | mount | 1459 | 1462 | 5000 | |
Text | mount | 386 | 387 | 5000 | |
TextField | mount | 942 | 966 | 5000 | |
ThemeProvider | mount | 884 | 861 | 5000 | |
ThemeProvider | virtual-rerender | 596 | 598 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1294 | 1295 | 5000 | |
Toggle | mount | 615 | 598 | 5000 | |
buttonNative | mount | 200 | 197 | 5000 |
packages/react-components/react-carousel/library/src/components/useEmblaCarousel.ts
Outdated
Show resolved
Hide resolved
.../react-components/react-carousel/stories/src/Carousel/CarouselFirstRunExperience.stories.tsx
Outdated
Show resolved
Hide resolved
.../react-components/react-carousel/stories/src/Carousel/CarouselFirstRunExperience.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-carousel/library/src/components/useEmblaCarousel.ts
Outdated
Show resolved
Hide resolved
.../react-components/react-carousel/stories/src/Carousel/CarouselFirstRunExperience.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Oct 10, 2024
fabricteam
reviewed
Oct 10, 2024
change/@fluentui-react-carousel-973e8fc6-d327-490f-a135-a9100a53033c.json
Show resolved
Hide resolved
Hotell
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for v-build owned files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior