Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to nx 19.8.4 #33014

Merged
merged 2 commits into from
Oct 9, 2024
Merged

chore: migrate to nx 19.8.4 #33014

merged 2 commits into from
Oct 9, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 9, 2024

@github-actions github-actions bot added this to the October Project Cycle Q4 2024 milestone Oct 9, 2024
@Hotell Hotell marked this pull request as ready for review October 9, 2024 11:20
@Hotell Hotell requested a review from a team as a code owner October 9, 2024 11:20
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 9, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 39 35 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 656 638 5000
Button mount 319 303 5000
Field mount 1185 1143 5000
FluentProvider mount 757 709 5000
FluentProviderWithTheme mount 95 98 10
FluentProviderWithTheme virtual-rerender 39 35 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 93 92 10
MakeStyles mount 839 858 50000
Persona mount 1803 1756 5000
SpinButton mount 1440 1391 5000
SwatchPicker mount 1715 1694 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 9, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 9, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 98 86 1.14:1
FlexMinimalPerf.default 168 149 1.13:1
PortalMinimalPerf.default 94 85 1.11:1
ChatWithPopoverPerf.default 206 191 1.08:1
ButtonSlotsPerf.default 323 309 1.05:1
StatusMinimalPerf.default 399 380 1.05:1
TextAreaMinimalPerf.default 300 285 1.05:1
VideoMinimalPerf.default 452 431 1.05:1
CheckboxMinimalPerf.default 1172 1129 1.04:1
LoaderMinimalPerf.default 202 194 1.04:1
RefMinimalPerf.default 114 110 1.04:1
AvatarMinimalPerf.default 107 104 1.03:1
DatepickerMinimalPerf.default 3729 3632 1.03:1
DialogMinimalPerf.default 455 443 1.03:1
ImageMinimalPerf.default 234 227 1.03:1
ListNestedPerf.default 327 317 1.03:1
MenuButtonMinimalPerf.default 982 958 1.03:1
ReactionMinimalPerf.default 219 212 1.03:1
TableMinimalPerf.default 241 233 1.03:1
TreeMinimalPerf.default 496 481 1.03:1
AnimationMinimalPerf.default 303 296 1.02:1
EmbedMinimalPerf.default 1921 1885 1.02:1
FormMinimalPerf.default 231 227 1.02:1
LayoutMinimalPerf.default 208 203 1.02:1
ListWith60ListItems.default 368 362 1.02:1
SkeletonMinimalPerf.default 195 191 1.02:1
SliderMinimalPerf.default 750 734 1.02:1
TooltipMinimalPerf.default 1318 1297 1.02:1
CarouselMinimalPerf.default 272 270 1.01:1
ChatDuplicateMessagesPerf.default 155 153 1.01:1
HeaderSlotsPerf.default 460 457 1.01:1
InputMinimalPerf.default 539 534 1.01:1
LabelMinimalPerf.default 222 220 1.01:1
ListMinimalPerf.default 319 316 1.01:1
RadioGroupMinimalPerf.default 268 265 1.01:1
SplitButtonMinimalPerf.default 2268 2251 1.01:1
TableManyItemsPerf.default 1121 1108 1.01:1
AttachmentSlotsPerf.default 652 652 1:1
ButtonOverridesMissPerf.default 667 664 1:1
ChatMinimalPerf.default 444 442 1:1
DividerMinimalPerf.default 207 207 1:1
DropdownManyItemsPerf.default 398 399 1:1
DropdownMinimalPerf.default 1426 1425 1:1
CustomToolbarPrototype.default 1463 1464 1:1
BoxMinimalPerf.default 197 200 0.99:1
CardMinimalPerf.default 300 302 0.99:1
ItemLayoutMinimalPerf.default 708 715 0.99:1
MenuMinimalPerf.default 497 501 0.99:1
PopupMinimalPerf.default 357 361 0.99:1
SegmentMinimalPerf.default 197 199 0.99:1
IconMinimalPerf.default 386 389 0.99:1
HeaderMinimalPerf.default 209 214 0.98:1
RosterPerf.default 1599 1624 0.98:1
ProviderMergeThemesPerf.default 633 648 0.98:1
ProviderMinimalPerf.default 202 207 0.98:1
TextMinimalPerf.default 186 189 0.98:1
ToolbarMinimalPerf.default 546 559 0.98:1
GridMinimalPerf.default 185 192 0.96:1
AttachmentMinimalPerf.default 77 81 0.95:1
AlertMinimalPerf.default 147 156 0.94:1
ListCommonPerf.default 387 412 0.94:1
ButtonMinimalPerf.default 83 89 0.93:1
AccordionMinimalPerf.default 81 89 0.91:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 9, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 9, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 640 644 5000
Breadcrumb mount 1688 1742 1000
Checkbox mount 1689 1690 5000
CheckboxBase mount 1495 1535 5000
ChoiceGroup mount 2954 3019 5000
ComboBox mount 679 662 1000
CommandBar mount 6601 6566 1000
ContextualMenu mount 14496 13876 1000
DefaultButton mount 826 814 5000
DetailsRow mount 2232 2268 5000
DetailsRowFast mount 2293 2256 5000
DetailsRowNoStyles mount 2082 2039 5000
Dialog mount 2867 2755 1000
DocumentCardTitle mount 229 233 1000
Dropdown mount 1989 1999 5000
FocusTrapZone mount 1162 1158 5000
FocusZone mount 1089 1111 5000
GroupedList mount 42503 42646 2
GroupedList virtual-rerender 20226 20505 2
GroupedList virtual-rerender-with-unmount 52313 52121 2
GroupedListV2 mount 225 232 2
GroupedListV2 virtual-rerender 222 217 2
GroupedListV2 virtual-rerender-with-unmount 230 233 2
IconButton mount 1152 1163 5000
Label mount 326 347 5000
Layer mount 2777 2772 5000
Link mount 393 412 5000
MenuButton mount 972 979 5000
MessageBar mount 21451 21696 5000
Nav mount 2006 2042 1000
OverflowSet mount 800 779 5000
Panel mount 1898 1874 1000
Persona mount 737 771 1000
Pivot mount 899 907 1000
PrimaryButton mount 943 953 5000
Rating mount 4677 4751 5000
SearchBox mount 909 913 5000
Shimmer mount 1889 1916 5000
Slider mount 1364 1334 5000
SpinButton mount 3004 3002 5000
Spinner mount 397 415 5000
SplitButton mount 1852 1842 5000
Stack mount 445 425 5000
StackWithIntrinsicChildren mount 898 880 5000
StackWithTextChildren mount 2808 2801 5000
SwatchColorPicker mount 6463 6433 5000
TagPicker mount 1429 1504 5000
Text mount 383 386 5000
TextField mount 964 968 5000
ThemeProvider mount 853 881 5000
ThemeProvider virtual-rerender 581 593 5000
ThemeProvider virtual-rerender-with-unmount 1312 1307 5000
Toggle mount 607 630 5000
buttonNative mount 197 193 5000

@Hotell Hotell enabled auto-merge (squash) October 9, 2024 12:09
@Hotell Hotell merged commit 348f676 into microsoft:master Oct 9, 2024
23 checks passed
@Hotell Hotell deleted the nx/migrate/19_8_4 branch October 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees
No one assigned
Labels
Area: Build System NX: core
Projects
None yet
Milestone
October Project Cycle Q4 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @tudorpopams