-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(.github): migrate infra to GHA #33070
base: master
Are you sure you want to change the base?
Conversation
📊 Bundle size report✅ No changes found |
3d7ab27
to
17e2a2a
Compare
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
---|---|---|---|---|
InputMinimalPerf.default | 530 | 531 | 1:1 | analysis |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ListMinimalPerf.default | 325 | 297 | 1.09:1 |
ImageMinimalPerf.default | 232 | 214 | 1.08:1 |
RefMinimalPerf.default | 115 | 107 | 1.07:1 |
HeaderMinimalPerf.default | 219 | 206 | 1.06:1 |
SegmentMinimalPerf.default | 200 | 188 | 1.06:1 |
DropdownManyItemsPerf.default | 394 | 375 | 1.05:1 |
FlexMinimalPerf.default | 162 | 154 | 1.05:1 |
HeaderSlotsPerf.default | 462 | 440 | 1.05:1 |
BoxMinimalPerf.default | 202 | 195 | 1.04:1 |
CheckboxMinimalPerf.default | 1158 | 1115 | 1.04:1 |
ListNestedPerf.default | 326 | 313 | 1.04:1 |
ListWith60ListItems.default | 378 | 365 | 1.04:1 |
LoaderMinimalPerf.default | 199 | 191 | 1.04:1 |
ChatDuplicateMessagesPerf.default | 152 | 147 | 1.03:1 |
DialogMinimalPerf.default | 450 | 437 | 1.03:1 |
DividerMinimalPerf.default | 201 | 196 | 1.03:1 |
ProviderMergeThemesPerf.default | 661 | 639 | 1.03:1 |
VideoMinimalPerf.default | 441 | 428 | 1.03:1 |
AttachmentSlotsPerf.default | 655 | 640 | 1.02:1 |
CarouselMinimalPerf.default | 271 | 266 | 1.02:1 |
GridMinimalPerf.default | 198 | 194 | 1.02:1 |
PortalMinimalPerf.default | 85 | 83 | 1.02:1 |
TextMinimalPerf.default | 193 | 190 | 1.02:1 |
ButtonMinimalPerf.default | 96 | 95 | 1.01:1 |
ChatWithPopoverPerf.default | 197 | 196 | 1.01:1 |
DatepickerMinimalPerf.default | 3611 | 3558 | 1.01:1 |
DropdownMinimalPerf.default | 1433 | 1413 | 1.01:1 |
EmbedMinimalPerf.default | 1887 | 1870 | 1.01:1 |
LabelMinimalPerf.default | 220 | 218 | 1.01:1 |
MenuMinimalPerf.default | 512 | 506 | 1.01:1 |
PopupMinimalPerf.default | 353 | 348 | 1.01:1 |
StatusMinimalPerf.default | 398 | 394 | 1.01:1 |
CustomToolbarPrototype.default | 1475 | 1455 | 1.01:1 |
AvatarMinimalPerf.default | 110 | 110 | 1:1 |
ButtonOverridesMissPerf.default | 650 | 651 | 1:1 |
ChatMinimalPerf.default | 440 | 438 | 1:1 |
ItemLayoutMinimalPerf.default | 699 | 700 | 1:1 |
MenuButtonMinimalPerf.default | 944 | 942 | 1:1 |
SliderMinimalPerf.default | 741 | 741 | 1:1 |
TooltipMinimalPerf.default | 1268 | 1274 | 1:1 |
AlertMinimalPerf.default | 165 | 166 | 0.99:1 |
AnimationMinimalPerf.default | 302 | 305 | 0.99:1 |
ButtonSlotsPerf.default | 319 | 322 | 0.99:1 |
ListCommonPerf.default | 388 | 390 | 0.99:1 |
TableManyItemsPerf.default | 1088 | 1099 | 0.99:1 |
TreeMinimalPerf.default | 475 | 481 | 0.99:1 |
TreeWith60ListItems.default | 85 | 86 | 0.99:1 |
SplitButtonMinimalPerf.default | 2227 | 2263 | 0.98:1 |
IconMinimalPerf.default | 392 | 399 | 0.98:1 |
CardMinimalPerf.default | 309 | 318 | 0.97:1 |
FormMinimalPerf.default | 221 | 227 | 0.97:1 |
ProviderMinimalPerf.default | 200 | 206 | 0.97:1 |
RadioGroupMinimalPerf.default | 261 | 269 | 0.97:1 |
ToolbarMinimalPerf.default | 526 | 542 | 0.97:1 |
LayoutMinimalPerf.default | 193 | 201 | 0.96:1 |
RosterPerf.default | 1589 | 1655 | 0.96:1 |
TextAreaMinimalPerf.default | 285 | 297 | 0.96:1 |
ReactionMinimalPerf.default | 210 | 221 | 0.95:1 |
TableMinimalPerf.default | 231 | 242 | 0.95:1 |
SkeletonMinimalPerf.default | 189 | 201 | 0.94:1 |
AccordionMinimalPerf.default | 79 | 90 | 0.88:1 |
AttachmentMinimalPerf.default | 76 | 86 | 0.88:1 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 644 | 644 | 5000 | |
Button | mount | 316 | 315 | 5000 | |
Field | mount | 1178 | 1126 | 5000 | |
FluentProvider | mount | 707 | 724 | 5000 | |
FluentProviderWithTheme | mount | 81 | 90 | 10 | |
FluentProviderWithTheme | virtual-rerender | 30 | 33 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 83 | 10 | |
MakeStyles | mount | 858 | 851 | 50000 | |
Persona | mount | 1799 | 1695 | 5000 | |
SpinButton | mount | 1392 | 1419 | 5000 | |
SwatchPicker | mount | 1654 | 1673 | 5000 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 630 | 634 | 5000 | |
Breadcrumb | mount | 1738 | 1693 | 1000 | |
Checkbox | mount | 1730 | 1718 | 5000 | |
CheckboxBase | mount | 1484 | 1499 | 5000 | |
ChoiceGroup | mount | 2996 | 3042 | 5000 | |
ComboBox | mount | 684 | 682 | 1000 | |
CommandBar | mount | 6665 | 6713 | 1000 | |
ContextualMenu | mount | 14125 | 13853 | 1000 | |
DefaultButton | mount | 791 | 809 | 5000 | |
DetailsRow | mount | 2306 | 2286 | 5000 | |
DetailsRowFast | mount | 2244 | 2272 | 5000 | |
DetailsRowNoStyles | mount | 2068 | 2074 | 5000 | |
Dialog | mount | 2825 | 2725 | 1000 | |
DocumentCardTitle | mount | 224 | 237 | 1000 | |
Dropdown | mount | 2028 | 2036 | 5000 | |
FocusTrapZone | mount | 1167 | 1137 | 5000 | |
FocusZone | mount | 1093 | 1098 | 5000 | |
GroupedList | mount | 43408 | 43333 | 2 | |
GroupedList | virtual-rerender | 20681 | 20764 | 2 | |
GroupedList | virtual-rerender-with-unmount | 53161 | 58613 | 2 | |
GroupedListV2 | mount | 245 | 228 | 2 | |
GroupedListV2 | virtual-rerender | 212 | 228 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 234 | 243 | 2 | |
IconButton | mount | 1189 | 1176 | 5000 | |
Label | mount | 349 | 354 | 5000 | |
Layer | mount | 2790 | 2812 | 5000 | |
Link | mount | 412 | 405 | 5000 | |
MenuButton | mount | 1012 | 992 | 5000 | |
MessageBar | mount | 21805 | 21734 | 5000 | |
Nav | mount | 2103 | 2080 | 1000 | |
OverflowSet | mount | 810 | 786 | 5000 | |
Panel | mount | 1925 | 1906 | 1000 | |
Persona | mount | 772 | 764 | 1000 | |
Pivot | mount | 893 | 921 | 1000 | |
PrimaryButton | mount | 936 | 961 | 5000 | |
Rating | mount | 4677 | 4759 | 5000 | |
SearchBox | mount | 949 | 927 | 5000 | |
Shimmer | mount | 1961 | 1927 | 5000 | |
Slider | mount | 1332 | 1363 | 5000 | |
SpinButton | mount | 2989 | 2961 | 5000 | |
Spinner | mount | 388 | 386 | 5000 | |
SplitButton | mount | 1929 | 1859 | 5000 | |
Stack | mount | 427 | 422 | 5000 | |
StackWithIntrinsicChildren | mount | 896 | 891 | 5000 | |
StackWithTextChildren | mount | 2752 | 2827 | 5000 | |
SwatchColorPicker | mount | 6524 | 6473 | 5000 | |
TagPicker | mount | 1480 | 1464 | 5000 | |
Text | mount | 411 | 400 | 5000 | |
TextField | mount | 945 | 931 | 5000 | |
ThemeProvider | mount | 878 | 859 | 5000 | |
ThemeProvider | virtual-rerender | 587 | 587 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1305 | 1308 | 5000 | |
Toggle | mount | 632 | 614 | 5000 | |
buttonNative | mount | 195 | 199 | 5000 |
… affected on all projects when it changes
8c9189f
to
290c9aa
Compare
290c9aa
to
2a15aca
Compare
…ild within generate-api executor
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
…pr website deploy
@@ -44,6 +44,7 @@ steps: | |||
DANGER_GITHUB_API_TOKEN: $(DANGER_GITHUB_API_TOKEN) | |||
|
|||
- script: | | |||
yarn nx run workspace-plugin:test --nxBail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
@@ -167,8 +168,11 @@ describe('GenerateApi Executor', () => { | |||
skipLibCheck: false, | |||
}); | |||
expect(extractorConfig.skipLibCheck).toBe(false); | |||
|
|||
const actualLocalBuildValue = isCI() ? false : true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: this fix needs to land to master -> separate PR
Previous Behavior
New Behavior
pipelines migration status:
[ ] perf testsWont doAdditional tasks:
Related Issue(s)