Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts/monorepo): silent nx verbose messages when invoking getAffectedPackages to emit valid JSON #33103

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(scripts/monorepo): silent nx verbose messages when invoking getAffectedPackages to emit valid JSON #33103

merged 1 commit into from
Oct 23, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 22, 2024 •
edited
Loading

Previous Behavior

New Behavior

Related Issue(s)

@Hotell Hotell changed the title fix(scripts/monorepo): silent nx verbose messages when incoking getAf… fix(scripts/monorepo): silent nx verbose messages when incoking getAffectedPackages to emit valid JSON Oct 22, 2024
@Hotell Hotell changed the title fix(scripts/monorepo): silent nx verbose messages when incoking getAffectedPackages to emit valid JSON fix(scripts/monorepo): silent nx verbose messages when invoking getAffectedPackages to emit valid JSON Oct 22, 2024
@Hotell Hotell marked this pull request as ready for review October 22, 2024 08:22
@Hotell Hotell requested a review from a team as a code owner October 22, 2024 08:22
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 654 649 5000
Button mount 306 305 5000
Field mount 1137 1148 5000
FluentProvider mount 738 729 5000
FluentProviderWithTheme mount 80 97 10
FluentProviderWithTheme virtual-rerender 40 37 10
FluentProviderWithTheme virtual-rerender-with-unmount 83 71 10
MakeStyles mount 876 889 50000
Persona mount 1787 1779 5000
SpinButton mount 1355 1381 5000
SwatchPicker mount 1669 1672 5000

@fabricteam
Copy link
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 3 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
LayoutMinimalPerf.default 211 196 1.08:1 analysis
AttachmentMinimalPerf.default 86 81 1.06:1 analysis
PortalMinimalPerf.default 89 88 1.01:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 101 86 1.17:1
RefMinimalPerf.default 125 108 1.16:1
BoxMinimalPerf.default 206 185 1.11:1
SkeletonMinimalPerf.default 207 192 1.08:1
TextAreaMinimalPerf.default 297 275 1.08:1
ListWith60ListItems.default 383 363 1.06:1
TooltipMinimalPerf.default 1300 1231 1.06:1
AvatarMinimalPerf.default 116 111 1.05:1
ChatDuplicateMessagesPerf.default 158 150 1.05:1
DividerMinimalPerf.default 209 200 1.05:1
ListNestedPerf.default 331 316 1.05:1
AnimationMinimalPerf.default 310 298 1.04:1
TableMinimalPerf.default 246 236 1.04:1
AttachmentSlotsPerf.default 647 630 1.03:1
ButtonSlotsPerf.default 329 318 1.03:1
FlexMinimalPerf.default 163 159 1.03:1
ListMinimalPerf.default 317 309 1.03:1
ReactionMinimalPerf.default 221 215 1.03:1
StatusMinimalPerf.default 392 379 1.03:1
ButtonOverridesMissPerf.default 654 644 1.02:1
ChatWithPopoverPerf.default 205 200 1.02:1
FormMinimalPerf.default 225 220 1.02:1
MenuMinimalPerf.default 509 500 1.02:1
ToolbarMinimalPerf.default 550 541 1.02:1
TreeWith60ListItems.default 86 84 1.02:1
CarouselMinimalPerf.default 263 260 1.01:1
InputMinimalPerf.default 541 537 1.01:1
ItemLayoutMinimalPerf.default 718 712 1.01:1
ProviderMergeThemesPerf.default 654 647 1.01:1
DatepickerMinimalPerf.default 3546 3557 1:1
EmbedMinimalPerf.default 1894 1900 1:1
RosterPerf.default 1593 1592 1:1
PopupMinimalPerf.default 349 350 1:1
RadioGroupMinimalPerf.default 264 263 1:1
SliderMinimalPerf.default 751 752 1:1
TableManyItemsPerf.default 1101 1105 1:1
CheckboxMinimalPerf.default 1135 1141 0.99:1
DialogMinimalPerf.default 443 448 0.99:1
DropdownManyItemsPerf.default 390 395 0.99:1
DropdownMinimalPerf.default 1420 1435 0.99:1
HeaderMinimalPerf.default 212 214 0.99:1
HeaderSlotsPerf.default 468 472 0.99:1
ProviderMinimalPerf.default 205 208 0.99:1
SegmentMinimalPerf.default 197 199 0.99:1
SplitButtonMinimalPerf.default 2263 2283 0.99:1
ListCommonPerf.default 385 392 0.98:1
LoaderMinimalPerf.default 193 197 0.98:1
MenuButtonMinimalPerf.default 948 964 0.98:1
IconMinimalPerf.default 389 395 0.98:1
CustomToolbarPrototype.default 1442 1472 0.98:1
TreeMinimalPerf.default 483 492 0.98:1
LabelMinimalPerf.default 229 235 0.97:1
VideoMinimalPerf.default 440 452 0.97:1
AccordionMinimalPerf.default 79 82 0.96:1
CardMinimalPerf.default 301 314 0.96:1
GridMinimalPerf.default 183 191 0.96:1
ImageMinimalPerf.default 224 234 0.96:1
TextMinimalPerf.default 190 197 0.96:1
AlertMinimalPerf.default 156 170 0.92:1
ChatMinimalPerf.default 432 468 0.92:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 650 652 5000
Breadcrumb mount 1704 1710 1000
Checkbox mount 1725 1747 5000
CheckboxBase mount 1499 1500 5000
ChoiceGroup mount 3071 2988 5000
ComboBox mount 707 693 1000
CommandBar mount 6727 6704 1000
ContextualMenu mount 13821 15075 1000
DefaultButton mount 804 834 5000
DetailsRow mount 2267 2257 5000
DetailsRowFast mount 2280 2245 5000
DetailsRowNoStyles mount 2037 2066 5000
Dialog mount 2866 2874 1000
DocumentCardTitle mount 229 228 1000
Dropdown mount 2083 2036 5000
FocusTrapZone mount 1166 1179 5000
FocusZone mount 1075 1059 5000
GroupedList mount 42877 43334 2
GroupedList virtual-rerender 20480 20632 2
GroupedList virtual-rerender-with-unmount 52178 52346 2
GroupedListV2 mount 226 230 2
GroupedListV2 virtual-rerender 214 221 2
GroupedListV2 virtual-rerender-with-unmount 234 234 2
IconButton mount 1149 1139 5000
Label mount 336 344 5000
Layer mount 2758 2779 5000
Link mount 401 405 5000
MenuButton mount 995 996 5000
MessageBar mount 21643 21561 5000
Nav mount 2036 2090 1000
OverflowSet mount 796 788 5000
Panel mount 1884 1847 1000
Persona mount 779 772 1000
Pivot mount 922 910 1000
PrimaryButton mount 936 931 5000
Rating mount 4783 4764 5000
SearchBox mount 946 930 5000
Shimmer mount 1910 1863 5000
Slider mount 1363 1359 5000
SpinButton mount 3108 2977 5000
Spinner mount 400 392 5000
SplitButton mount 1978 1893 5000
Stack mount 424 430 5000
StackWithIntrinsicChildren mount 875 896 5000
StackWithTextChildren mount 2836 2821 5000
SwatchColorPicker mount 6525 6452 5000
TagPicker mount 1447 1474 5000
Text mount 391 386 5000
TextField mount 981 953 5000
ThemeProvider mount 877 853 5000
ThemeProvider virtual-rerender 598 590 5000
ThemeProvider virtual-rerender-with-unmount 1302 1333 5000
Toggle mount 644 626 5000
buttonNative mount 190 201 5000

@Hotell Hotell merged commit e659bb6 into microsoft:master Oct 23, 2024
21 checks passed
@Hotell Hotell deleted the scripts/monorepo/mute-verbose-mode branch October 23, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@dmytrokirpa dmytrokirpa dmytrokirpa approved these changes

Assignees
No one assigned
Labels
Area: Build System
Projects
None yet
Milestone
October Project Cycle Q4 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @dmytrokirpa