Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onOverflowChange callback #33106

Merged

Conversation

ling1726
Copy link
Member

Adds a callback to inform userland about overflow state to power features that are outside of the overflow component that need to know about overflow state.

Adds a callback to inform userland about overflow state to power
features that are outside of the overflow component that need to know
about overflow state.
@ling1726 ling1726 marked this pull request as ready for review October 22, 2024 12:35
@ling1726 ling1726 requested review from a team as code owners October 22, 2024 12:35
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 22, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.159 MB
290.307 kB
1.159 MB
290.329 kB
45 B
22 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-breadcrumb
@fluentui/react-breadcrumb - package
114.291 kB
31.695 kB
react-components
react-components: Button, FluentProvider & webLightTheme
69.21 kB
20.174 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
220.616 kB
63.902 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-overflow
hooks only
12.808 kB
4.819 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
107.387 kB
35.758 kB
🤖 This report was generated against 23f7636c9eec05ec96691b32be169e7186b0f918

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 22, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 614 634 5000
Button mount 304 304 5000
Field mount 1150 1129 5000
FluentProvider mount 697 730 5000
FluentProviderWithTheme mount 80 90 10
FluentProviderWithTheme virtual-rerender 36 36 10
FluentProviderWithTheme virtual-rerender-with-unmount 71 81 10
MakeStyles mount 862 863 50000
Persona mount 1760 1698 5000
SpinButton mount 1422 1365 5000
SwatchPicker mount 1633 1639 5000

@ling1726 ling1726 merged commit 84f915c into microsoft:master Oct 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants