Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic test cases to donut chart #33127

Open
wants to merge 4 commits into
base: charting/web-components
Choose a base branch
from

Conversation

v-baambati
Copy link
Contributor

@v-baambati v-baambati commented Oct 24, 2024

Added basic test cases to donut chart and horizontalbar chart

@v-baambati v-baambati requested a review from a team as a code owner October 24, 2024 06:45
@v-baambati v-baambati changed the title Charting/web components Added basic test cases to donut chart Oct 24, 2024
});

test('Should render chart properly', async ({ page }) => {
const element = page.locator('fluent-donut-chart');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the page render all donut-chart stories by default? We should have separate examples for testing to avoid modifying the test file whenever the stories change.

See this:

await page.setContent(/* html */ `
<fluent-accordion expand-mode="multi">
<fluent-accordion-item>
<span slot="heading">Heading 1</span>
<div>Content 1</div>
</fluent-accordion-item>
<fluent-accordion-item>
<span slot="heading">Heading 2</span>
<div>Content 2</div>
</fluent-accordion-item>
</fluent-accordion>
`);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now added test cases on existing example which is there in the stories.

@krkshitij krkshitij removed the request for review from a team October 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants