-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Popover): opacity transition was not happening #33421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertpenner
force-pushed
the
fix/popover-fade
branch
from
December 6, 2024 20:38
6c44635
to
4893a91
Compare
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
robertpenner
changed the title
fix(Popover): correct opacity keyframes in
fix(Popover): opacity transition in Dec 6, 2024
createSlideStyles()
createSlideStyles()
was not happening
fabricteam
reviewed
Dec 6, 2024
packages/react-components/react-positioning/src/createSlideStyles.ts
Outdated
Show resolved
Hide resolved
robertpenner
changed the title
fix(Popover): opacity transition in
fix(Popover): opacity transition in was not happening
Dec 6, 2024
createSlideStyles()
was not happening
robertpenner
changed the title
fix(Popover): opacity transition in was not happening
fix(Popover): opacity transition was not happening
Dec 6, 2024
robertpenner
force-pushed
the
fix/popover-fade
branch
from
December 7, 2024 22:55
92df9f4
to
0ca6fb1
Compare
robertpenner
requested review from
layershifter,
ling1726 and
pixel-perfectionist
December 9, 2024 00:19
layershifter
reviewed
Dec 9, 2024
packages/react-components/react-positioning/src/createSlideStyles.ts
Outdated
Show resolved
Hide resolved
layershifter
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find, but let's improve the fix 👍
layershifter
approved these changes
Dec 9, 2024
/azp run CI / main (pull_request) |
No pipelines are associated with this pull request. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects all components that use
createSlideStyles
(e.g. viaPopover
orMenuPopover
):AvatarGroup
,InfoLabel
,Popover
,TeachingPopover
,Menu
,MenuButton
,SplitButton
,Breadcrumb
, and various charts.Current Behavior
There is no fade during the slide of a Popover. (public Storybook)
Popover.fade.isn.t.happening.-.2024-11-26.mp4
New Behavior
The popover transition has a fade-in while sliding. (PR Storybook)
Popover.fade.fixed.-.2024-11-26.mp4
Related Issue(s)