Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vr-tests): set a fixed value for culture prop in charts #33690

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

krkshitij
Copy link
Contributor

@krkshitij krkshitij commented Jan 20, 2025

This PR resolves the following error:

image

Copy link

Pull request demo site: URL

@krkshitij krkshitij changed the title update culture in vr-tests stories [Draft] update culture in vr-tests stories Jan 20, 2025
@krkshitij krkshitij marked this pull request as ready for review January 20, 2025 12:48
@krkshitij krkshitij requested a review from a team as a code owner January 20, 2025 12:48
@krkshitij krkshitij marked this pull request as draft January 20, 2025 12:54
@krkshitij krkshitij changed the title [Draft] update culture in vr-tests stories update culture in vr-tests stories Jan 20, 2025
@krkshitij krkshitij changed the base branch from user/atisjai/stronglyTypePlotly to master January 20, 2025 13:03
Copy link

github-actions bot commented Jan 20, 2025

📊 Bundle size report

✅ No changes found

@krkshitij krkshitij closed this Jan 20, 2025
@krkshitij krkshitij reopened this Jan 21, 2025
@krkshitij krkshitij requested a review from a team January 21, 2025 06:24
@krkshitij krkshitij changed the title update culture in vr-tests stories fix(vr-tests): set a fixed value for culture prop in charts Jan 21, 2025
@krkshitij krkshitij marked this pull request as ready for review January 21, 2025 08:06
@krkshitij krkshitij merged commit 397cadb into microsoft:master Jan 23, 2025
16 checks passed
marcosmoura added a commit that referenced this pull request Jan 23, 2025
…/chore--slot-API-react-v17/18-support

* chore/react-18-support: (516 commits)
  update some deps to React 18
  test(react-color-picker): Added cy and a11y tests for sliders (#33609)
  fix(react-charting): Centre align Gauge chart (#33710)
  fix(vr-tests): set a fixed value for culture prop in charts (#33690)
  release: applying package updates - react v8
  feat(react-charting): Heatmap text color based on Contrast Ratio (#33659)
  test(color-picker): Added VR tests for ColorSlider and AlphaSlider (#33672)
  fix: remove forced synchronous layout in Drawer (#33665)
  feat(declarative-chart): Support for Dashed and Dotted lines (#33694)
  release: applying package updates - react-components
  feat: add vite sandbox template (#33631)
  ci: trigger VRT PR workflow only against testing branch (#33701)
  chore(deps-dev): bump vite from 6.0.7 to 6.0.9 (#33698)
  release: applying package updates - react v8
  BaseFloatingPicker - Release references held by Async (#33685)
  feature(react-tag-picker): single line layout (#32247)
  feature(react-tree): introduces navigationMode property (#33658)
  bugfix: secondaryContent not displaying properly (#33689)
  release: applying package updates - react v8
  fix(react-charting): resolve overlapping bars issue in histogram (#33695)
  ...
marcosmoura added a commit that referenced this pull request Jan 23, 2025
…/chore--slot-API-react-v17/18-support

* chore/react-18-support: (516 commits)
  update some deps to React 18
  test(react-color-picker): Added cy and a11y tests for sliders (#33609)
  fix(react-charting): Centre align Gauge chart (#33710)
  fix(vr-tests): set a fixed value for culture prop in charts (#33690)
  release: applying package updates - react v8
  feat(react-charting): Heatmap text color based on Contrast Ratio (#33659)
  test(color-picker): Added VR tests for ColorSlider and AlphaSlider (#33672)
  fix: remove forced synchronous layout in Drawer (#33665)
  feat(declarative-chart): Support for Dashed and Dotted lines (#33694)
  release: applying package updates - react-components
  feat: add vite sandbox template (#33631)
  ci: trigger VRT PR workflow only against testing branch (#33701)
  chore(deps-dev): bump vite from 6.0.7 to 6.0.9 (#33698)
  release: applying package updates - react v8
  BaseFloatingPicker - Release references held by Async (#33685)
  feature(react-tag-picker): single line layout (#32247)
  feature(react-tree): introduces navigationMode property (#33658)
  bugfix: secondaryContent not displaying properly (#33689)
  release: applying package updates - react v8
  fix(react-charting): resolve overlapping bars issue in histogram (#33695)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants