Skip to content

fix(declarative-chart): Remove Duplicate keys warning #33722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2025
Merged

fix(declarative-chart): Remove Duplicate keys warning #33722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22302e1
fix: Remove Duplicate keys warning
Anush2303 Jan 24, 2025
660eae2
Add change file
Anush2303 Jan 24, 2025
ec175dd
Merge branch 'master' into usr/agupta/duplicateKeys
Anush2303 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-2caf6b30-798c-40cb-98ca-64aade9cc329.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix Duplicate keys warning",
"packageName": "@fluentui/react-charting",
"email": "74965306+Anush2303@users.noreply.github.com",
"dependentChangeType": "patch"
}
6 changes: 3 additions & 3 deletions packages/charts/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ export class VerticalBarChartBase
const gradientId = getId('VBC_Gradient') + `_${index}_${startColor}`;

return (
<g key={point.x as string}>
<g key={`${point.x}_${index}` as string}>
{this.props.enableGradient && (
<defs>
<linearGradient id={gradientId} x1="0%" y1="100%" x2="0%" y2="0%">
Expand Down Expand Up @@ -892,7 +892,7 @@ export class VerticalBarChartBase

return (
<g
key={point.x instanceof Date ? point.x.getTime() : point.x}
key={point.x instanceof Date ? `${point.x.getTime()}_${index}` : `${point.x}_${index}`}
transform={`translate(${0.5 * (xBarScale.bandwidth() - this._barWidth)}, 0)`}
>
{this.props.enableGradient && (
Expand Down Expand Up @@ -1005,7 +1005,7 @@ export class VerticalBarChartBase
const gradientId = getId('VBC_Gradient') + `_${index}_${startColor}`;

return (
<g key={point.x instanceof Date ? point.x.getTime() : point.x}>
<g key={point.x instanceof Date ? `${point.x.getTime()}_${index}` : `${point.x}_${index}`}>
{this.props.enableGradient && (
<defs>
<linearGradient id={gradientId} x1="0%" y1="100%" x2="0%" y2="0%">
Expand Down
Loading