Autofill component should also listen to onInput, just like the other input components do #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dzearing |
|
This fix (supplying both onChange and onInput) does not work because of the non-standard way the Autofill component controls its input (the value of the input is not necessarily what the user is typing) If I just provide the onInput property, this works correctly. Is it only because of the legacy IE10 document mode we have to support this? :( |
added 2 commits
February 27, 2018 16:53
joschect
approved these changes
Feb 28, 2018
added 2 commits
February 27, 2018 17:21
cschleiden
approved these changes
Feb 28, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Mar 1, 2018
* master: ResizeGroup SCSS to MergeStyles Part 2: Style Conversion (microsoft#4072) Applying package updates. Import Unstyled Component for Layer, Nav, Image, ScrollablePane, ResizeGroup, and Rating (microsoft#4135) FocusZone: isDefaultPrevented is now respected (microsoft#4133) Website: Left nav scroll improvements (microsoft#4132) AutoFill: Component should also listen to onInput, just like the other input components do (microsoft#4129) GroupedList: Fixed chevron animation (microsoft#4123) CoachMarkStyles: Use ... instead of assign for IE compatibility" (microsoft#4130) Applying package updates.
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
…r input components do (microsoft#4129) * Autofill should use oninput * Changefile * Use both handlers * Autofill * Update comment * Update tests and snapshots * Update snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
We should also listen to the onInput event, so that IE11 is guaranteed to receive all the correct keystrokes
See #744 and facebook/react#7027