Calendar bug fixes #9328
Merged
Calendar bug fixes #9328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Component perf results:
|
|
andrewhwng
approved these changes
Jun 4, 2019
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
fixing text overflow bug in date-time Calendar component when user inputs text that is very long. Before there was no overflow behavior so text overlaps itself. Now the text hides overflow and adds ellipsis.
in both OUFR and date-time calendars, adding tooltips for buttons that have no text in them. Note that Narrator is slightly slower in reading this text out than before with it being an aria-label, but as noted here: 'title' attribute value should not be read when 'aria-label' is available in [Chrome] and [Firefox] nvaccess/nvda#7841, we generally don't want to have the same aria-label and title text because screen readers will read it twice, and title text does get read.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow