Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G1GC Archive regions #211

Closed
kcpeppe opened this issue Feb 20, 2022 · 5 comments · Fixed by #369
Closed

G1GC Archive regions #211

kcpeppe opened this issue Feb 20, 2022 · 5 comments · Fixed by #369
Labels
enhancement New feature or request

Comments

@kcpeppe
Copy link
Collaborator

kcpeppe commented Feb 20, 2022

GCToolkit recognized but does not use the data to account for G1 archive regions when calculating the size and occupancy of tenured.

GCToolkit's calculation of tenured should subtract archive regions from the tenured total.
@karianna karianna added the enhancement New feature or request label Mar 23, 2022
@kkdlau
Copy link
Contributor

kkdlau commented Jun 22, 2024

I would love to work on this issue! Could you please point me to the specific file(s) that would need to be modified for this issue?

@karianna
Copy link
Member

@kcpeppe for guidance :-)

@kkdlau
Copy link
Contributor

kkdlau commented Jul 5, 2024 •
edited
Loading

@kcpeppe appreciate if you could provide guidance!

@dsgrieve
Copy link
Member

dsgrieve commented Jul 8, 2024

@kkdlau - G1GCPauseEvent#getTenured()

kkdlau added a commit to kkdlau/gctoolkit that referenced this issue Jul 15, 2024
@kkdlau
improve archive region calculation (microsoft#211)
6478e57
karianna added a commit that referenced this issue Aug 6, 2024
@kkdlau @karianna
Improve Archive Region Calculation (#211) (#369)
aaeb875 
* improve archive region calculation (#211)

* Add comment for Archive Region availability

* Update parser/src/main/java/com/microsoft/gctoolkit/parser/UnifiedG1GCParser.java

* Update parser/src/main/java/com/microsoft/gctoolkit/parser/UnifiedG1GCParser.java

* Update parser/src/main/java/com/microsoft/gctoolkit/parser/UnifiedG1GCParser.java

* Update parser/src/main/java/com/microsoft/gctoolkit/parser/UnifiedG1GCParser.java

---------

Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
@dsgrieve dsgrieve linked a pull request Aug 8, 2024 that will close this issue
Improve Archive Region Calculation (#211) #369
Merged
@dsgrieve dsgrieve closed this as completed Aug 8, 2024
@dsgrieve
Copy link
Member

dsgrieve commented Aug 8, 2024

Thanks, @kkdlau, for your contribution and for you patience with us!

@karianna karianna mentioned this issue Oct 1, 2024
Merged
@karianna karianna mentioned this issue Dec 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Archive Region Calculation (#211) kkdlau/gctoolkit
4 participants
@karianna @kcpeppe @dsgrieve @kkdlau