Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrecognised ZGC file #382

Closed
AlinaHovakimyan opened this issue Sep 2, 2024 · 3 comments · Fixed by #419
Closed

Unrecognised ZGC file #382

AlinaHovakimyan opened this issue Sep 2, 2024 · 3 comments · Fixed by #419

Comments

@AlinaHovakimyan
Copy link
Contributor

gctoolkit is not being able to recognize ZGC file generated with non-debug mode. Issue is because it indicates ZGC file by looking for "Initializing The Z Garbage Collector" line, which is not there if you just generate zgc log by bin/java -XX:+UseZGC , but if I generate it on debug mode, then all is good: bin/java -XX:+UseZGC -Xlog:gc*,gc+director=debug:file=cms_generated.log:time,level,tags. The line that exists in both files and I guess could be used is "Using The Z Garbage Collector"
@dsgrieve
Copy link
Member

dsgrieve commented Sep 4, 2024

ZGC coverage is weak. We do need more/better tests for ZGC. We do have tests for this, but it is very light. Again, a log file would help.

@AlinaHovakimyan
Copy link
Contributor Author

@dsgrieve please see the log attached:
zgc_generated.log

@j-bahr
Copy link
Collaborator

j-bahr commented Feb 28, 2025

ZGC currently requires the use of "gc+init" to discover the type due to the start tag regex.

[info][gc,init] Initializing The Z Garbage Collector

I think this could easily be moved to simply the the "gc" log tag of

[info][gc     ] Using The Z Garbage Collector

j-bahr added a commit to j-bahr/gctoolkit that referenced this issue Feb 28, 2025
@j-bahr
Add missing GC causes from gcCause.cpp
155e182 
1) Adding new GC causes from /src/jdk/src/hotspot/share/gc/shared/gcCause.cpp in JDK 21. This may help fix issues seen in microsoft#382.

2) Create GCCauses map programmatically from enum value list. This is less error prone in the event of adding causes.
@j-bahr j-bahr mentioned this issue Feb 28, 2025
Merged
j-bahr added a commit to j-bahr/gctoolkit that referenced this issue Feb 28, 2025
@j-bahr
Add missing GC causes from gcCause.cpp
0fd71e2 
1) Adding new GC causes from /src/jdk/src/hotspot/share/gc/shared/gcCause.cpp in JDK 21. This may help fix issues seen in microsoft#382.

2) Create GCCauses map programmatically from enum value list. This is less error prone in the event of adding causes.
kcpeppe pushed a commit that referenced this issue Mar 3, 2025
@j-bahr
Add missing GC causes from gcCause.cpp (#420)
ce45b93 
1) Adding new GC causes from /src/jdk/src/hotspot/share/gc/shared/gcCause.cpp in JDK 21. This may help fix issues seen in #382.

2) Create GCCauses map programmatically from enum value list. This is less error prone in the event of adding causes.

Note: This is a potentially breaking change for Aggregation classes that care about GCCause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change ZGC start tag j-bahr/gctoolkit
3 participants
@dsgrieve @AlinaHovakimyan @j-bahr