Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GenerationalHeapParser #332

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix GenerationalHeapParser #332

merged 1 commit into from
Mar 4, 2024

Conversation

loyispa
Copy link
Contributor

@loyispa loyispa commented Feb 23, 2024

Hello, i found that GenerationalHeapParser couldn't parse following CMS concurrent-mode-failure logs:

case1:

83.371: [CMS-concurrent-abortable-preclean-start]
83.751: [GC 83.751: [ParNew: 17024K->17024K(19136K), 0.0000236 secs]83.751: [CMS83.751: [CMS-concurrent-abortable-preclean: 0.026/0.380 secs] [Times: user=0.41 sys=0.04, real=0.38 secs] 
 (concurrent mode failure): 103355K->96073K(107776K), 0.5668205 secs] 120379K->96073K(126912K), [CMS Perm : 15591K->15585K(28412K)], 0.5669586 secs] [Times: user=0.57 sys=0.00, real=0.57 secs] 

case2:

2024-02-23T16:14:07.550+0800: 15897423.337: [GC (CMS Initial Mark) [1 CMS-initial-mark: 1398143K(1398144K)] 1957374K(1957376K), 0.4527312 secs] [Times: user=0.57 sys=0.00, real=0.45 secs]
2024-02-23T16:14:08.003+0800: 15897423.790: [CMS-concurrent-mark-start]
2024-02-23T16:14:08.172+0800: 15897423.959: [Full GC (Allocation Failure) 2024-02-23T16:14:08.172+0800: 15897423.959: [CMS2024-02-23T16:14:10.825+0800: 15897426.612: [CMS-concurrent-mark: 2.820/2.822 secs] [Times: user=2.57 sys=0.00, real=2.82 secs]
 (concurrent mode failure): 1398144K->1398143K(1398144K), 8.7753717 secs] 1957375K->1957374K(1957376K), [Metaspace: 63759K->63759K(1107968K)], 8.7755118 secs] [Times: user=8.17 sys=0.00, real=8.78 secs]

In these cases, there will be an extra SPACE before (concurrent mode failure), so CONCURRENT_MODE_FAILURE_DETAILS and CONCURRENT_MODE_FAILURE_DETAILS_META failed to recognize them. Please take a look :)

@karianna karianna requested a review from kcpeppe February 23, 2024 08:46
@loyispa
Copy link
Contributor Author

loyispa commented Feb 27, 2024

@kcpeppe do you have time to take a look? It's very easy to verify this issue.

@dsgrieve dsgrieve merged commit 1476fc1 into microsoft:main Mar 4, 2024
8 checks passed
@karianna karianna mentioned this pull request Mar 28, 2024
@karianna karianna mentioned this pull request May 9, 2024
@karianna karianna mentioned this pull request Jul 3, 2024
@karianna karianna mentioned this pull request Oct 1, 2024
@karianna karianna mentioned this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants