Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse of CMSParser into GenerationHeapParser #337

Merged
merged 18 commits into from
Mar 11, 2024
Merged

Conversation

kcpeppe
Copy link
Collaborator

@kcpeppe kcpeppe commented Mar 11, 2024

The CMSParser was originally designed to manage the CMS phase events. This was helpful in dealing with all of the different types of corruption in the logs that occurred as a result of running 2 collectors concurrently. However, in GCToolKit this lead to duplicated pause events being published. Collapsing the CMS parser into the generational parser solves this problem. And since there are no more updates to pre-unified JVMs, all of the corruptions are well documented and understood so this problem is not stable.

@karianna karianna merged commit b8f9f91 into microsoft:main Mar 11, 2024
8 checks passed
@karianna karianna mentioned this pull request Mar 28, 2024
@karianna karianna mentioned this pull request May 9, 2024
@karianna karianna mentioned this pull request Jul 3, 2024
@karianna karianna mentioned this pull request Oct 1, 2024
@karianna karianna mentioned this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants