Collapse of CMSParser into GenerationHeapParser #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the timestamp is missing
Fixes DateTimeStamp
dsgrieve
approved these changes
Mar 11, 2024
karianna
approved these changes
Mar 11, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMSParser was originally designed to manage the CMS phase events. This was helpful in dealing with all of the different types of corruption in the logs that occurred as a result of running 2 collectors concurrently. However, in GCToolKit this lead to duplicated pause events being published. Collapsing the CMS parser into the generational parser solves this problem. And since there are no more updates to pre-unified JVMs, all of the corruptions are well documented and understood so this problem is not stable.