-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I need a title #344
I need a title #344
Conversation
…the timestamp is missing
Fixes DateTimeStamp
…ertain conditions
} | ||
|
||
public void count(CMSRemark event) { | ||
System.out.println(event.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not quite yet... I'd say depreciated for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take that last comment back as this integration test is being used by the GenerationalHeapParser testing
|
||
machine.getAggregation(CMSCycleAggregation.class).ifPresent(cmsCycleCounts -> { | ||
Assertions.assertEquals( 1, cmsCycleCounts.getInitialMark(), "Initial Mark events count"); | ||
//Assertions.assertEquals( 1, cmsCycleCounts.getRemark(), "Remark events count"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these commented out because they don't give the expected result?
more debugging and more tests