Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreUnified now works with DateStamps only #347

Merged
merged 32 commits into from
Apr 19, 2024
Merged

Conversation

kcpeppe
Copy link
Collaborator

@kcpeppe kcpeppe commented Apr 11, 2024

Previous to this work, GCToolKit required TimeStamp even in the presence of DateStamp. This PR removes that dependency. PreUnified logs can now have a TimeStamp or a DateStamp or both.

kcpeppe and others added 27 commits January 8, 2024 22:35
@kcpeppe kcpeppe marked this pull request as draft April 11, 2024 20:10
@kcpeppe kcpeppe marked this pull request as ready for review April 11, 2024 20:34
return new DateTimeStamp(dateStamp, convertToDouble(timeStamp));
} else if ( dateStamp != null)
return new DateTimeStamp(dateStamp);
//}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

recordRescanStepTimes(collection, line);
collection.add(extractCPUSummary(line));
publish(collection);
CMSRemark collection = (gcCause == GCCause.UNKNOWN_GCCAUSE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CMSRemark collection = (gcCause == GCCause.UNKNOWN_GCCAUSE)
CMSRemark collection = (gcCause == GCCause.UNKNOWN_GCCAUSE)


assertTrue(true);
}


/* Code that is useful when testing individual records */

@Test
//@Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ATIgnore but still run from your IDE?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATIgnore is not being recognized in my IDE...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ignore I mean..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kcpeppe you want @Test @Ignore

…gTrace.java

Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
@karianna karianna requested a review from dsgrieve April 17, 2024 11:24
@dsgrieve
Copy link
Member

@kcpeppe You've marked several (but not all) of @karianna's comments as 'resolved', but I don't see any changes. Is there a commit you haven't pushed?

@dsgrieve dsgrieve merged commit 64dd6dd into microsoft:main Apr 19, 2024
8 checks passed
@karianna karianna mentioned this pull request May 9, 2024
@karianna karianna mentioned this pull request Jul 3, 2024
@karianna karianna mentioned this pull request Oct 1, 2024
@karianna karianna mentioned this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants