PreUnified now works with DateStamps only #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the timestamp is missing
Fixes DateTimeStamp
…ertain conditions
karianna
requested changes
Apr 12, 2024
parser/src/main/java/com/microsoft/gctoolkit/parser/AbstractLogTrace.java
Show resolved
Hide resolved
parser/src/main/java/com/microsoft/gctoolkit/parser/AbstractLogTrace.java
Outdated
Show resolved
Hide resolved
| return new DateTimeStamp(dateStamp, convertToDouble(timeStamp)); | ||
| } else if ( dateStamp != null) | ||
| return new DateTimeStamp(dateStamp); | ||
| //} |
parser/src/main/java/com/microsoft/gctoolkit/parser/CMSTenuredPoolParser.java
Outdated
Show resolved
Hide resolved
parser/src/main/java/com/microsoft/gctoolkit/parser/CMSTenuredPoolParser.java
Show resolved
Hide resolved
| recordRescanStepTimes(collection, line); | ||
| collection.add(extractCPUSummary(line)); | ||
| publish(collection); | ||
| CMSRemark collection = (gcCause == GCCause.UNKNOWN_GCCAUSE) |
There was a problem hiding this comment.
Suggested change
| CMSRemark collection = (gcCause == GCCause.UNKNOWN_GCCAUSE) | |
| CMSRemark collection = (gcCause == GCCause.UNKNOWN_GCCAUSE) |
parser/src/main/java/com/microsoft/gctoolkit/parser/UnifiedG1GCParser.java
Show resolved
Hide resolved
|
|
||
| assertTrue(true); | ||
| } | ||
|
|
||
|
|
||
| /* Code that is useful when testing individual records */ | ||
|
|
||
| @Test | ||
| //@Test |
There was a problem hiding this comment.
Can you ATIgnore but still run from your IDE?
There was a problem hiding this comment.
ATIgnore is not being recognized in my IDE...
There was a problem hiding this comment.
@kcpeppe you want @Test @Ignore
...er/src/test/java/com/microsoft/gctoolkit/parser/ConcurrentMarkSweepPhaseParserRulesTest.java
Outdated
Show resolved
Hide resolved
parser/src/test/java/com/microsoft/gctoolkit/parser/G1GCParserRulesTest.java
Outdated
Show resolved
Hide resolved
…gTrace.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
karianna
approved these changes
Apr 17, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this work, GCToolKit required TimeStamp even in the presence of DateStamp. This PR removes that dependency. PreUnified logs can now have a TimeStamp or a DateStamp or both.