-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PreUnified now works with DateStamps only #347
Conversation
…the timestamp is missing
Fixes DateTimeStamp
…ertain conditions
parser/src/main/java/com/microsoft/gctoolkit/parser/AbstractLogTrace.java
Show resolved
Hide resolved
parser/src/main/java/com/microsoft/gctoolkit/parser/AbstractLogTrace.java
Outdated
Show resolved
Hide resolved
return new DateTimeStamp(dateStamp, convertToDouble(timeStamp)); | ||
} else if ( dateStamp != null) | ||
return new DateTimeStamp(dateStamp); | ||
//} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
parser/src/main/java/com/microsoft/gctoolkit/parser/CMSTenuredPoolParser.java
Outdated
Show resolved
Hide resolved
parser/src/main/java/com/microsoft/gctoolkit/parser/CMSTenuredPoolParser.java
Show resolved
Hide resolved
recordRescanStepTimes(collection, line); | ||
collection.add(extractCPUSummary(line)); | ||
publish(collection); | ||
CMSRemark collection = (gcCause == GCCause.UNKNOWN_GCCAUSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMSRemark collection = (gcCause == GCCause.UNKNOWN_GCCAUSE) | |
CMSRemark collection = (gcCause == GCCause.UNKNOWN_GCCAUSE) |
parser/src/main/java/com/microsoft/gctoolkit/parser/UnifiedG1GCParser.java
Show resolved
Hide resolved
|
||
assertTrue(true); | ||
} | ||
|
||
|
||
/* Code that is useful when testing individual records */ | ||
|
||
@Test | ||
//@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you ATIgnore but still run from your IDE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ATIgnore is not being recognized in my IDE...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ignore I mean..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcpeppe you want @Test @Ignore
...er/src/test/java/com/microsoft/gctoolkit/parser/ConcurrentMarkSweepPhaseParserRulesTest.java
Outdated
Show resolved
Hide resolved
parser/src/test/java/com/microsoft/gctoolkit/parser/G1GCParserRulesTest.java
Outdated
Show resolved
Hide resolved
…gTrace.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Previous to this work, GCToolKit required TimeStamp even in the presence of DateStamp. This PR removes that dependency. PreUnified logs can now have a TimeStamp or a DateStamp or both.