Unified Serial GC correction #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the timestamp is missing
Fixes DateTimeStamp
…ertain conditions
…gTrace.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
karianna
reviewed
Dec 20, 2024
| switch (forwardReference.getGarbageCollectionType()) { | ||
| case PSFull: | ||
| return fillOutFullGC(new PSFullGC(forwardReference.getStartTime(), forwardReference.getGCCause(), forwardReference.getDuration()), forwardReference); | ||
| if ( forwardReference.getGCCause().equals(GCCause.JAVA_LANG_SYSTEM)) |
There was a problem hiding this comment.
It feels like some of this is DRY / could be squashed down, on the other hand it's readable, so that wins!
|
|
||
| private static final int[][] serialCounts = { | ||
| // 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17 | ||
| { 0, 13, 0, 0, 0, 0, 0, 0, 0, 0, 4, 0, 0, 0, 0, 0, 0, 0}, |
There was a problem hiding this comment.
A new developer coming into this will struggle, can we add a comment stating what this array effectively tests?
karianna
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of fixes but the important one is the fix to produce System GC full events.