Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic for all deployments set to zero during any deployment #182

Open
LittleColin opened this issue Jul 11, 2024 · 0 comments
Open

Traffic for all deployments set to zero during any deployment #182

LittleColin opened this issue Jul 11, 2024 · 0 comments

Comments

@LittleColin
Copy link
Contributor

The begin_create_or_update call for the endpoint is always made during deployment. If there are existing deployments, because these are not being specified as part of this update call, this call causes the traffic to be set to 0% for existing deployments. This is shortly followed up by a call to set the traffic to 100% again, but there is a window during deployment where traffic is 0%.

https://github.com/microsoft/llmops-promptflow-template/blob/d8ee083a730f00e9cd23a4ec39c2f884eab2e56f/llmops/common/deployment/provision_endpoint.py#L74

Propose that the endpoint is not updated if it already exists since there are no properties on the endpoint that need updating on each deployment, except perhaps for the build id tag, but it's likely to be more appropriate to leave that tag pointing to the build that caused the endpoint to be created anyway.

LittleColin added a commit that referenced this issue Jul 15, 2024
Only create the endpoint if it does not already exist, fixes #182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant