Skip to content

Conversation

@pelikhan
Copy link
Member

No description provided.

pelikhan and others added 30 commits April 1, 2025 03:35
Added logging for unknown reference types in activateChatParticipant.
- Added support for AZURE_AI_INFERENCE_VERSION constant.
- Expanded documentation with API version and configuration examples.
Refined Azure API version fallback and URL parameter parsing.
Adjusted debug imports and corrected doc indentation and spacing.
Modified slice behavior for balanced content display in limited rows.
Enhanced debug logging across services and refined GCC script messaging.
Added detailed container operations logging and improved dbg usage.
Enhanced parsing to ignore versions with curly braces in URLs.
- Adjusted logic to add ellipsis only when necessary.
Added indicator for hidden lines count in trimmed message content.
Adjusted handling to display one hidden line or summarize excess.
Refined line truncation logic for better clarity and maintainability.
@@ -48,14 +45,22 @@ import { normalizeInt } from "./cleaners"
export async function resolveFileContent(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed code. Consider adding updated tests to ensure no functionality is broken.

AI-generated content by linters variable-names may be incorrect. Use reactions to eval.

@@ -48,14 +45,22 @@ import { normalizeInt } from "./cleaners"
export async function resolveFileContent(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment or rationale explaining why the directory case was removed. It helps future readers understand the purpose of this change.

AI-generated content by linters comments may be incorrect. Use reactions to eval.

@pelikhan pelikhan requested a review from bzorn April 25, 2025 21:35
@github-actions
Copy link
Contributor

1. Annotations

Linter: no-fix-mes

No // fixme comments were identified in the provided diff. Code passes this check.


Linter: grumpy-dev

Feedback on changes:

  1. .github/prompts/genaiscript.prompt.md

    • Removing doc links without replacement? You're breaking documentation references. Genius move.
  2. .github/workflows changes

    • Every workflow is riddled with env deletions. If you're doing environment cleanup, you better be darn sure nobody needs those variables... otherwise, congrats, you've just created endless debugging joy for others.
    • Random removals of scripts? What's the rationale? Nobody documents anything anymore, huh? Sure, it's fine—if your goal is mass confusion.
    • Missing descriptions of added workflow files. Basic courtesy.
  3. README.md

    • No updates to reflect changes in workflows? Back in my day, we'd at least try to keep documentation usable.
  4. docs/* changes

    • "Blog-image.genai.mts" had half its brains torn out (code removed) but for what? Without comments or replacements, it's a guessing game. A+ on creating headaches.

Linter: comments

Commenting Issues Observed:

  • Workflow scripts and .mts files are woefully under-commented. Replace or remove functions without explaining? Brilliant way to obfuscate code.
  • Diff removes functionality (e.g., genai-blog-post scripts), yet fails to explain new workflows (genai-linters.yml, genai-docs.yml). Comments or documentation were needed here.

Warning

Removed run commands lack explanation. Add appropriate comments to describe rationale and replacement functionality. (.github/workflows/azure.yml#L1 missing_comments)

Warning

Removed logic from blog-image script. Explain new logic/intent to avoid confusion. (docs/genaisrc/blog-image.genai.mts#L1 missing_comments)


Linter: variable-names

Variable sanity check passes. File names and variables look correctly named but lack explanatory tests.


Linter: stats

Metric Count
Files Modified 19
New File Additions 6
Code Deletions ~100+
New Functions/Commands 0
New Comments/Docstrings 0

Linter: diagrams

Added workflows, .mts utilities reorganization requires diagram representation.

graph TD;
    A[Workflows .github]
    B[Removed Variables/`env` scripts]
    C[Added Placeholder .github/workflows/genai-docs.yml]
    D[Updated CLI ("GenAI/mts workspace")]
    A -->|Cleanup| B
    B --> C
    C -->|Hook to CLI changes| D
Loading

AI-generated content by linters may be incorrect. Use reactions to eval.

Copy link
Collaborator

@bzorn bzorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look comprehensive. Nice to have so much documentation.

@pelikhan pelikhan merged commit 0a49370 into main Apr 25, 2025
15 checks passed
@pelikhan pelikhan deleted the dev branch April 25, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants