-
Notifications
You must be signed in to change notification settings - Fork 217
dev branch #1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev branch #1460
Conversation
Added logging for unknown reference types in activateChatParticipant.
- Added support for AZURE_AI_INFERENCE_VERSION constant. - Expanded documentation with API version and configuration examples.
Refined Azure API version fallback and URL parameter parsing.
Adjusted debug imports and corrected doc indentation and spacing.
Modified slice behavior for balanced content display in limited rows.
Enhanced debug logging across services and refined GCC script messaging.
Added detailed container operations logging and improved dbg usage.
Enhanced parsing to ignore versions with curly braces in URLs.
- Adjusted logic to add ellipsis only when necessary.
Added indicator for hidden lines count in trimmed message content.
Adjusted handling to display one hidden line or summarize excess.
Refined line truncation logic for better clarity and maintainability.
Refactored the function to improve clarity and type consistency.
| @@ -48,14 +45,22 @@ import { normalizeInt } from "./cleaners" | |||
| export async function resolveFileContent( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed code. Consider adding updated tests to ensure no functionality is broken.
AI-generated content by linters
variable-namesmay be incorrect. Use reactions to eval.
| @@ -48,14 +45,22 @@ import { normalizeInt } from "./cleaners" | |||
| export async function resolveFileContent( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a comment or rationale explaining why the directory case was removed. It helps future readers understand the purpose of this change.
AI-generated content by linters
commentsmay be incorrect. Use reactions to eval.
- Changed MIME type for .js from text/javascript to application/javascript
Replaced 'yarn compile:cli' with 'yarn compile' for build consistency.
* ✨ feat: add tokenize command to CLI for token processing Adds a new tokenize command to parse text into hex tokens with options. * docs generator * remove comments * updated docs prompt
1. AnnotationsLinter: no-fix-mesNo Linter: grumpy-devFeedback on changes:
Linter: commentsCommenting Issues Observed:
Warning Removed Warning Removed logic from blog-image script. Explain new logic/intent to avoid confusion. (docs/genaisrc/blog-image.genai.mts#L1 missing_comments) Linter: variable-namesVariable sanity check passes. File names and variables look correctly named but lack explanatory tests. Linter: stats
Linter: diagramsAdded workflows, graph TD;
A[Workflows .github]
B[Removed Variables/`env` scripts]
C[Added Placeholder .github/workflows/genai-docs.yml]
D[Updated CLI ("GenAI/mts workspace")]
A -->|Cleanup| B
B --> C
C -->|Hook to CLI changes| D
|
bzorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look comprehensive. Nice to have so much documentation.
No description provided.