Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- oia examples only contain OpenAI imports+calls #648

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmerkle
Copy link
Contributor

@bmerkle bmerkle commented Dec 9, 2024

Copy link

github-actions bot commented Dec 9, 2024

👋 Thanks for contributing @bmerkle! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Dec 9, 2024

Check Broken URLs

We have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue.

Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.

File Full Path Issues
02-exploring-and-comparing-different-llms/README.md
#LinkLine Number
1https://www.anthropic.com/index/claude-2?WT.mc_id=academic-105485-koreyst70
02-exploring-and-comparing-different-llms/translations/ko/README.md
#LinkLine Number
1https://www.anthropic.com/index/claude-2?WT.mc_id=academic-105485-koreyst66
02-exploring-and-comparing-different-llms/translations/tw/README.md
#LinkLine Number
1https://www.anthropic.com/index/claude-2?WT.mc_id=academic-105485-koreyst69
02-exploring-and-comparing-different-llms/translations/ja-jp/README.md
#LinkLine Number
1https://www.anthropic.com/index/claude-2?WT.mc_id=academic-105485-yoterada67
02-exploring-and-comparing-different-llms/translations/cn/README.md
#LinkLine Number
1https://www.anthropic.com/index/claude-267
02-exploring-and-comparing-different-llms/translations/pt-br/README.md
#LinkLine Number
1https://www.anthropic.com/index/claude-2?WT.mc_id=academic-105485-koreyst70

@bmerkle
Copy link
Contributor Author

bmerkle commented Dec 10, 2024

Please note that i did not change anything in chapter 2 but....meanwhile URLs of chapter 2 have been changed by anthropic.
e.g. curl -v https://www.anthropic.com/index/claude-2
results in HTTP/1.1 308 Permanent Redirect

@koreyspace two questions:

  • should we always correct the urls if they get redirected or
  • can we modifiy the "Check Broken URL" task to accept HTTP 308 Redirects ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants