Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: add installer validation #526

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

ldennington
Copy link
Collaborator

@ldennington ldennington commented Aug 17, 2022

Add basic installer validation to release pipeline for Windows, macOS, and
Linux (Debian package only). Validation runs the installers/any necessary
setup and checks that the installed version matches the expected version.

You can find a successful test run of these changes here.

@ldennington ldennington requested a review from dscho August 17, 2022 23:29
Add basic installer validation to release pipeline for Windows, macOS, and
Linux (Debian package only). Validation runs the installers/any necessary
setup and checks that the installed version matches the expected version.
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Just one suggestion: could you mark it as a fixup! (or squash!) so that it gets squashed during the next rebase?

Copy link
Collaborator

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just one suggestion: could you mark it as a fixup! (or squash!) so that it gets squashed during the next rebase?

I could take it either way. It's kind of nice to have the installer validation split as its own change, since it's not just a few lines tweaked. We might want to reorder the patch to be in the same "topic" as the other installer changes when we do the next rebase, but that's optional.

@ldennington
Copy link
Collaborator Author

Looks great!

Just one suggestion: could you mark it as a fixup! (or squash!) so that it gets squashed during the next rebase?

I could take it either way. It's kind of nice to have the installer validation split as its own change, since it's not just a few lines tweaked. We might want to reorder the patch to be in the same "topic" as the other installer changes when we do the next rebase, but that's optional.

@dscho and I talked about this offline. We're going to take as-is, and I've added a reminder to my calendar to work with the person executing the next rebase to re-order the patch.

@ldennington ldennington merged commit 1f91deb into microsoft:vfs-2.37.2 Aug 19, 2022
derrickstolee pushed a commit that referenced this pull request Aug 31, 2022
dscho added a commit to dscho/git-sdk-32 that referenced this pull request Aug 31, 2022
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git-sdk-32 that referenced this pull request Aug 31, 2022
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git-sdk-32 that referenced this pull request Aug 31, 2022
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git-sdk-64 that referenced this pull request Aug 31, 2022
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git-sdk-64 that referenced this pull request Sep 1, 2022
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git-sdk-32 that referenced this pull request Sep 1, 2022
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git-sdk-32 that referenced this pull request Sep 1, 2022
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git-sdk-32 that referenced this pull request Sep 1, 2022
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git-sdk-64 that referenced this pull request Sep 1, 2022
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
shannonmae80 pushed a commit to shannonmae80/git-sdk-32 that referenced this pull request Jan 13, 2023
This builds on the excellent work at
microsoft/git#526

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants