-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: add installer validation #526
release: add installer validation #526
Conversation
Add basic installer validation to release pipeline for Windows, macOS, and Linux (Debian package only). Validation runs the installers/any necessary setup and checks that the installed version matches the expected version.
06b3d57
to
1b6a023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Just one suggestion: could you mark it as a fixup!
(or squash!
) so that it gets squashed during the next rebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Just one suggestion: could you mark it as a
fixup!
(orsquash!
) so that it gets squashed during the next rebase?
I could take it either way. It's kind of nice to have the installer validation split as its own change, since it's not just a few lines tweaked. We might want to reorder the patch to be in the same "topic" as the other installer changes when we do the next rebase, but that's optional.
@dscho and I talked about this offline. We're going to take as-is, and I've added a reminder to my calendar to work with the person executing the next rebase to re-order the patch. |
release: add installer validation
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This builds on the excellent work at microsoft/git#526 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Add basic installer validation to release pipeline for Windows, macOS, and
Linux (Debian package only). Validation runs the installers/any necessary
setup and checks that the installed version matches the expected version.
You can find a successful test run of these changes here.