Remove deprecated parts of Actions workflows #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace deprecated 'echo "::set-output name=...' syntax with new 'echo "<name>=<value>" >>$GITHUB_OUTPUT' syntax [1], clearing the deprecation warning appearing in the 'release-homebrew.yml' workflow. [1] https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Replace deprecated 'echo "::set-output name=...' syntax with new 'echo "<name>=<value>" >>$GITHUB_OUTPUT' syntax [1]. A second fixup patch will remove the one remaining instance of the old syntax to clear the deprecation warning in 'build-git-installers.yml'. [1] https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Finish replacing deprecated 'echo "::set-output name=...' syntax with new 'echo "<name>=<value>" >>$GITHUB_OUTPUT' syntax [1], clearing the deprecation warning appearing in the 'build-git-installers.yml' workflow. [1] https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Update 'actions/checkout' to v3 to stop using a deprecated Node.js 12 version of the action.
Update 'actions/checkout' to v3 to stop using a deprecated Node.js 12 version of the action.
Update 'actions/checkout' to v3 to stop using a deprecated Node.js 12 version of the action.
Update 'actions/checkout' to v3 to stop using a deprecated Node.js 12 version of the action.
Update 'actions/checkout' to v3 to stop using a deprecated Node.js 12 version of the action.
Upgrade 'actions/github-script' from v4 to v6 to silence the Node.js 12
deprecation warning. Note that this also includes an update to how the
'github' object is accessed in the script ('github' -> 'github.rest') due to
a breaking change introduced in v5 [1].
[1] https://github.com/actions/github-script#breaking-changes-in-v5
Upgrade the 'actions/setup-dotnet' Action to v3 to stop using Node.js 12 (deprecated). Signed-off-by: Victoria Dye <vdye@github.com>
Upgrade the 'actions/upload-artifact' Action to v3 to stop using Node.js 12 (deprecated). Signed-off-by: Victoria Dye <vdye@github.com>
Update to Node.js 16 versions of 'mjcheetham/asset-hash' [1] and 'mjcheetham/update-homebrew' [2]. [1] mjcheetham/asset-hash#342 [2] mjcheetham/update-homebrew#17
Update the runner versions for the Scalar Functional tests to supported versions. For MacOS, update to the main supported version (macos-11). For Ubuntu, ensure we're still testing the two latest LTS versions by replacing 18.04 with 22.04. Also update the installed dotnet version to the latest v3.1 patch version. Signed-off-by: Victoria Dye <vdye@github.com>
dscho
approved these changes
Mar 7, 2023
| @@ -797,7 +797,7 @@ jobs: | |||
|
|
|||
| // Create the release | |||
| var tagName = "${{ needs.prereqs.outputs.tag_name }}"; | |||
| var createdRelease = await github.repos.createRelease({ | |||
| var createdRelease = await github.rest.repos.createRelease({ | |||
There was a problem hiding this comment.
I hope you did not have a hard time finding out about that; I should have remembered to point out that I had to fix plenty of those in the corresponding git/git patch.
ldennington
approved these changes
Mar 7, 2023
| @@ -20,17 +20,17 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| # Order by runtime (in descending order) | |||
| os: [windows-2019, macos-10.15, ubuntu-18.04, ubuntu-20.04] | |||
| os: [windows-2019, macos-11, ubuntu-20.04, ubuntu-22.04] | |||
There was a problem hiding this comment.
Nit: To reduce future churn, perhaps use ubuntu-<previous LTS>, ubuntu-latest .
There was a problem hiding this comment.
GitHub Actions isn't consistent about which LTS release ubuntu-latest refers to (for example, ubuntu-latest right now is ubuntu-20.04, but IIRC before 22.04 was available ubuntu-latest was still ubuntu-20.04), so we can't really rely on it. If we need to manually update one of the version numbers anyway, hopefully it's not too disruptive to update both.
derrickstolee
approved these changes
Mar 8, 2023
|
I updated the required builds to the latest names with this change. Merging now. |
dscho
added a commit
that referenced
this pull request
Mar 20, 2023
This is a companion to #566. I pushed a tag to trigger [a build](https://github.com/microsoft/git/actions/runs/4447499276) that demonstrates that all the deprecation warnings are gone (for now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixups should fix all of the deprecation warnings found across this repository's workflows with the exception of
check-whitespace(fixed upstream) andgit-artifacts(removed upstream).set-outputsyntaxactions/checkoutactions/github-scriptand updates usage of thegithubinstanceactions/setup-dotnetto v3actions/upload-artifactto v3mjcheetham/*actions (see the pull requests updatingasset-hashandupdate-homebrewfor more details).