Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gvfs-helper: add gvfs.fallback config option #664

Closed

Commits on Jun 28, 2024

  1. gvfs-helper: don't fallback with new config

    By default, GVFS Protocol-enabled Scalar clones will fall back to the
    origin server if there is a network issue with the cache servers.
    However (and especially for the prefetch endpoint) this may be a very
    expensive operation for the origin server, leading to the user being
    throttled. This shows up later in cases such as 'git push' or other web
    operations.
    
    To avoid this, create a new config option, 'gvfs.fallback', which
    defaults to true. When set to 'false', pass '--no-fallback' from the
    gvfs-helper client to the child gvfs-helper server process.
    
    This will allow users who have hit this problem to avoid it in the
    future. In case this becomes a more widespread problem, engineering
    systems can enable the config option more broadly.
    
    Enabling the config will of course lead to immediate failures for users,
    but at least that will help diagnose the problem when it occurs instead
    of later when the throttling shows up and the server load has already
    passed, damage done.
    
    Signed-off-by: Derrick Stolee <stolee@gmail.com>
    derrickstolee committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0472084 View commit details
    Browse the repository at this point in the history